diff options
| author | Aaron Kennedy <aaron.kennedy@nokia.com> | 2012-05-30 10:16:13 +0100 |
|---|---|---|
| committer | Qt by Nokia <qt-info@nokia.com> | 2012-08-29 06:38:54 +0200 |
| commit | 04774bb14c81688f86a2b31b8624bde8ebf59062 (patch) | |
| tree | 9d04d18712988caca2a3f193feb94cfaa35b47bb /src/qml/qml/v4/qv4instruction_p.h | |
| parent | d65fb68de12b6d811f7b94ba3209847f73ca94cc (diff) | |
Evaluate bindings more intelligently during construction
Instead of just evaluating bindings in a fixed order, and possibly
having to evaluate a single binding multiple times, prior to reading
a property, we check if there are any bindings "pending" on it and
evaluate them then. A pending binding is one that has been assigned
to the property, but not yet evaluated.
To minimize side effects we only do this for "safe" bindings. A
safe binding is one that has no side effects, which we currently
define as not calling functions or otherwise assigning values during
its evaluation. This isn't an entirely foolproof way to ensure that
the evaluation has no side effects, but it should be good enough.
Change-Id: I98aa76a95719e5d182e8941738d64f8d409f404a
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Diffstat (limited to 'src/qml/qml/v4/qv4instruction_p.h')
| -rw-r--r-- | src/qml/qml/v4/qv4instruction_p.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/qml/qml/v4/qv4instruction_p.h b/src/qml/qml/v4/qv4instruction_p.h index 34d483b079..a918992b9d 100644 --- a/src/qml/qml/v4/qv4instruction_p.h +++ b/src/qml/qml/v4/qv4instruction_p.h @@ -67,7 +67,6 @@ QT_BEGIN_NAMESPACE #define FOR_EACH_V4_INSTR(F) \ F(Noop, common) \ F(BindingId, id) \ - F(Subscribe, subscribeop) \ F(SubscribeId, subscribeop) \ F(FetchAndSubscribe, fetchAndSubscribe) \ F(LoadId, load) \ @@ -291,6 +290,8 @@ union Q_AUTOTEST_EXPORT V4Instr { quint8 exceptionId; quint8 valueType; quint32 index; + quint16 subOffset; + quint32 subIndex; }; struct instr_copy { |