Fix memory corruption in qjsvalueprivate

When converting to a memory managed string, we need to add
the PersistentValuePrivate to the chain of persistent objects.
Otherwise the string stored in the JSValue can get garbage
collected.

Change-Id: I159fd77a7ae6f29e4121969cac962bd12b0f9bc7
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>

1 files changed, 1 insertions, 11 deletions

diff --git a/src/qml/qml/v8/qjsvalue_p.h b/src/qml/qml/v8/qjsvalue_p.h
index 3b05af21e8..a1cd471785 100644
--- a/src/qml/qml/v8/qjsvalue_p.h
+++ b/src/qml/qml/v8/qjsvalue_p.h
@@ -89,17 +89,7 @@ public:
         value = QV4::Value::fromString(&string);
     }
 
-    QV4::Value getValue(QV4::ExecutionEngine *e) {
-        if (!this->e)
-            this->e = e;
-        else if (this->e != e) {
-            qWarning("JSValue can't be reassigned to another engine.");
-            return QV4::Value::emptyValue();
-        }
-        if (value.asString() == &string)
-            value = QV4::Value::fromString(e->newString(string.toQString()));
-        return value;
-    }
+    QV4::Value getValue(QV4::ExecutionEngine *e);
 
     bool checkEngine(QV4::ExecutionEngine *otherEngine) {
         if (!e) {