diff options
| author | Lars Knoll <lars.knoll@qt.io> | 2018-04-06 13:41:29 +0200 |
|---|---|---|
| committer | Lars Knoll <lars.knoll@qt.io> | 2018-05-02 14:18:06 +0000 |
| commit | b58711804e9cca641927dbdebe281488e475352b (patch) | |
| tree | cb7671cb6edc52e5e744a370704ec068c7ab45eb /src/qml/qml/v8/qv8engine.cpp | |
| parent | 238b1cb1cb8915995b6dfe4e404f1771c62b3169 (diff) | |
Use Identifier by value and don't new them anymore
Change-Id: Ib25c08027013217657beb2675dafa9a8c85cbaf9
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Diffstat (limited to 'src/qml/qml/v8/qv8engine.cpp')
| -rw-r--r-- | src/qml/qml/v8/qv8engine.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/qml/qml/v8/qv8engine.cpp b/src/qml/qml/v8/qv8engine.cpp index 7106583e6d..81f1f89c92 100644 --- a/src/qml/qml/v8/qv8engine.cpp +++ b/src/qml/qml/v8/qv8engine.cpp @@ -207,9 +207,9 @@ void QV8Engine::initializeGlobal() { for (uint i = 0; i < m_v4Engine->globalObject->internalClass()->size; ++i) { - if (m_v4Engine->globalObject->internalClass()->nameMap.at(i)) { - QV4::Identifier *id = m_v4Engine->globalObject->internalClass()->nameMap.at(i); - m_illegalNames.insert(m_v4Engine->identifierTable->stringFromIdentifier(id)->toQString()); + if (m_v4Engine->globalObject->internalClass()->nameMap.at(i).isValid()) { + QV4::Identifier id = m_v4Engine->globalObject->internalClass()->nameMap.at(i); + m_illegalNames.insert(m_v4Engine->identifierTable->stringForId(id)->toQString()); } } } |