aboutsummaryrefslogtreecommitdiffstats
path: root/src/qmltest/quicktestresult_p.h
diff options
context:
space:
mode:
authorJason McDonald <jason.mcdonald@nokia.com>2012-02-09 16:17:32 +1000
committerQt by Nokia <qt-info@nokia.com>2012-02-13 04:20:25 +0100
commit5572b4c9ed6041d23c79c9cd93d196653a690a43 (patch)
treecaa4c2ad98bdc6dd2d313fe86a9f3688b38272be /src/qmltest/quicktestresult_p.h
parent09923aec384ae8b972c85e9912aa89a8c2eeba8b (diff)
qmltest: Count passes, fails and skips consistently.
This commit changes qmltest to count one pass per data row, rather than a single pass for an entire data-driven test function. This makes counting of passes consistent with counting of fails and skips which were already counted once per data row. This change also means that the plain-text, xml and light-xml output formats will now show one result per data row, so that every data row executed will be shown in the test output with either a pass, fail or skip result. Previously data rows that passed were not shown in the output, preventing analysis of total number of tests runs, pass-rates, and various other metrics. This commit corresponds to (and depends on) a commit in the qtbase module which changes the behaviour of qtestlib in the same way. Task-number: QTBUG-21848 Task-number: QTBUG-22124 Change-Id: I3c1f0e68bdff4087b9ccfc80a3f96f4541335b6f Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com> Reviewed-by: Yunqiao Yin <charles.yin@nokia.com>
Diffstat (limited to 'src/qmltest/quicktestresult_p.h')
-rw-r--r--src/qmltest/quicktestresult_p.h3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/qmltest/quicktestresult_p.h b/src/qmltest/quicktestresult_p.h
index f6f0c3a1b3..3bc6f9c7cb 100644
--- a/src/qmltest/quicktestresult_p.h
+++ b/src/qmltest/quicktestresult_p.h
@@ -61,7 +61,6 @@ class Q_QUICK_TEST_EXPORT QuickTestResult : public QObject
Q_PROPERTY(QString functionName READ functionName WRITE setFunctionName NOTIFY functionNameChanged)
Q_PROPERTY(QString dataTag READ dataTag WRITE setDataTag NOTIFY dataTagChanged)
Q_PROPERTY(bool failed READ isFailed)
- Q_PROPERTY(bool dataFailed READ isDataFailed)
Q_PROPERTY(bool skipped READ isSkipped WRITE setSkipped NOTIFY skippedChanged)
Q_PROPERTY(int passCount READ passCount)
Q_PROPERTY(int failCount READ failCount)
@@ -88,7 +87,6 @@ public:
void setDataTag(const QString &tag);
bool isFailed() const;
- bool isDataFailed() const;
bool isSkipped() const;
void setSkipped(bool skip);
@@ -109,6 +107,7 @@ public Q_SLOTS:
void clearTestTable();
void finishTestData();
+ void finishTestDataCleanup();
void finishTestFunction();
void fail(const QString &message, const QUrl &location, int line);