diff options
| author | Jesus Fernandez <jesus.fernandez@qt.io> | 2017-08-14 06:18:41 +0200 |
|---|---|---|
| committer | Jesus Fernandez <Jesus.Fernandez@qt.io> | 2017-10-27 09:24:00 +0000 |
| commit | ec596406c03714dbd6865c18c83bf61d615e5791 (patch) | |
| tree | 77964e83c30f07184c8baa9d5bdcb1474da3edee /src/quick/handlers/qquickpointerhandler.cpp | |
| parent | 3e20d1059a612ba5a6d3c049fe93f780f3ba3e58 (diff) | |
Fix Logically dead code
The indicated dead code may have performed some action; that action will never occur.
In QQuickPointerHandler::onGrabChanged(QQuickPointerHandler *, QQuickEventPoint::GrabState, QQuickEventPoint *): Code can never be reached because of a logical contradiction
Coverity-Id: 182646
Change-Id: Ic3ccffddf3052337d22d5dd7fabb8bfa7af35dbe
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
Diffstat (limited to 'src/quick/handlers/qquickpointerhandler.cpp')
| -rw-r--r-- | src/quick/handlers/qquickpointerhandler.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/quick/handlers/qquickpointerhandler.cpp b/src/quick/handlers/qquickpointerhandler.cpp index c32bec665c..faebdf3621 100644 --- a/src/quick/handlers/qquickpointerhandler.cpp +++ b/src/quick/handlers/qquickpointerhandler.cpp @@ -98,7 +98,6 @@ void QQuickPointerHandler::onGrabChanged(QQuickPointerHandler *grabber, QQuickEv Q_ASSERT(point); if (grabber == this) { bool wasCanceled = false; - emit grabChanged(point); switch (stateChange) { case QQuickEventPoint::GrabPassive: case QQuickEventPoint::GrabExclusive: @@ -115,6 +114,7 @@ void QQuickPointerHandler::onGrabChanged(QQuickPointerHandler *grabber, QQuickEv par->setKeepMouseGrab(m_hadKeepMouseGrab); par->setKeepTouchGrab(m_hadKeepTouchGrab); } + break; case QQuickEventPoint::OverrideGrabPassive: // Passive grab is still there, but we won't receive point updates right now. // No need to notify about this. |