diff options
author | Shawn Rutledge <shawn.rutledge@qt.io> | 2018-07-26 16:33:13 +0200 |
---|---|---|
committer | Shawn Rutledge <shawn.rutledge@qt.io> | 2018-07-27 10:42:54 +0000 |
commit | 0e1f83dcade8cb6428513eea4452dcd500f9e486 (patch) | |
tree | 227c4848145b23fde12ad33d3bea3a60c04cb36e /src/quick/handlers/qquicktaphandler.cpp | |
parent | 447e2e024609a22fe052cf458c27efdef2e3d3eb (diff) |
Fix PointerHandler constructors and destructors
- Constructors should take QQuickItem* not QObject* to be symmetric
with the parentItem() accessor (and other code) which assumes its type
- Use header initialization everywhere possible
- Reorder variables to minimize padding (somewhat)
- Remove empty destructor bodies (the compiler can write them)
- Remove override and virtual from destructors in accordance with
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rh-override
Change-Id: I682a53a803d65e29136bfaec3a5b534e975ecf30
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
Diffstat (limited to 'src/quick/handlers/qquicktaphandler.cpp')
-rw-r--r-- | src/quick/handlers/qquicktaphandler.cpp | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/src/quick/handlers/qquicktaphandler.cpp b/src/quick/handlers/qquicktaphandler.cpp index 1d3375314f..992bc5e438 100644 --- a/src/quick/handlers/qquicktaphandler.cpp +++ b/src/quick/handlers/qquicktaphandler.cpp @@ -84,13 +84,8 @@ int QQuickTapHandler::m_touchMultiTapDistanceSquared(-1); \sa MouseArea */ -QQuickTapHandler::QQuickTapHandler(QObject *parent) +QQuickTapHandler::QQuickTapHandler(QQuickItem *parent) : QQuickSinglePointHandler(parent) - , m_pressed(false) - , m_gesturePolicy(DragThreshold) - , m_tapCount(0) - , m_longPressThreshold(-1) - , m_lastTapTimestamp(0.0) { if (m_mouseMultiClickDistanceSquared < 0) { m_multiTapInterval = qApp->styleHints()->mouseDoubleClickInterval() / 1000.0; @@ -103,10 +98,6 @@ QQuickTapHandler::QQuickTapHandler(QObject *parent) } } -QQuickTapHandler::~QQuickTapHandler() -{ -} - static bool dragOverThreshold(const QQuickEventPoint *point) { QPointF delta = point->scenePosition() - point->scenePressPosition(); |