diff options
author | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-01-15 15:41:29 +0300 |
---|---|---|
committer | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-01-18 07:57:56 +0000 |
commit | f644f86c84287065535fbd8c3478a5b2550437ac (patch) | |
tree | 54640dd88fa7e4cc3ce03b15d6ed3a7c2b005070 /src/quick/items/qquickdrag.cpp | |
parent | 1cbf064cdf6d24ddbb6bf30b08a88ec1bf03d3df (diff) |
Quick: fix expensive iteration over QHash::keys() and QMap::keys()
Change-Id: I21c48214bfddde01f71710705fe01418818a6581
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
Diffstat (limited to 'src/quick/items/qquickdrag.cpp')
-rw-r--r-- | src/quick/items/qquickdrag.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/quick/items/qquickdrag.cpp b/src/quick/items/qquickdrag.cpp index 279f5e5299..e44c0b216f 100644 --- a/src/quick/items/qquickdrag.cpp +++ b/src/quick/items/qquickdrag.cpp @@ -715,9 +715,8 @@ Qt::DropAction QQuickDragAttachedPrivate::startDrag(Qt::DropActions supportedAct QDrag *drag = new QDrag(q); QMimeData *mimeData = new QMimeData(); - Q_FOREACH (const QString &key, externalMimeData.keys()) { - mimeData->setData(key, externalMimeData[key].toString().toUtf8()); - } + for (auto it = externalMimeData.cbegin(), end = externalMimeData.cend(); it != end; ++it) + mimeData->setData(it.key(), it.value().toString().toUtf8()); drag->setMimeData(mimeData); |