diff options
author | Michael Brasser <michael.brasser@live.com> | 2013-08-01 08:44:27 -0500 |
---|---|---|
committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-08-01 20:53:03 +0200 |
commit | 55edeb68e2aba81724ccbada98c1bf021b3a2b7d (patch) | |
tree | 37fd16f8b8aea5f60ad8f48137f8bb0cf0df1f51 /src/quick/items/qquickimplicitsizeitem.cpp | |
parent | 472950ecab88fc41a99f2a1deb861a4abd273174 (diff) |
Avoid using connect in QQuickImplicitSizeItem.
In the past connect has shown up as a noticeable cost in item
creation. Avoid the use here by refactoring to call base class
implementation and emit override signal as well.
Task-number: QTBUG-32764
Change-Id: If3e5a1cc55c113d812705fcfdc7a17aee9d6f51c
Reviewed-by: Alan Alpert (Personal) <416365416c@gmail.com>
Diffstat (limited to 'src/quick/items/qquickimplicitsizeitem.cpp')
-rw-r--r-- | src/quick/items/qquickimplicitsizeitem.cpp | 16 |
1 files changed, 2 insertions, 14 deletions
diff --git a/src/quick/items/qquickimplicitsizeitem.cpp b/src/quick/items/qquickimplicitsizeitem.cpp index b330b3929f..62dddb4a3b 100644 --- a/src/quick/items/qquickimplicitsizeitem.cpp +++ b/src/quick/items/qquickimplicitsizeitem.cpp @@ -47,32 +47,20 @@ QT_BEGIN_NAMESPACE void QQuickImplicitSizeItemPrivate::implicitWidthChanged() { Q_Q(QQuickImplicitSizeItem); - for (int ii = 0; ii < changeListeners.count(); ++ii) { - const QQuickItemPrivate::ChangeListener &change = changeListeners.at(ii); - if (change.types & QQuickItemPrivate::ImplicitWidth) { - change.listener->itemImplicitWidthChanged(q); - } - } + QQuickItemPrivate::implicitWidthChanged(); emit q->implicitWidthChanged2(); } void QQuickImplicitSizeItemPrivate::implicitHeightChanged() { Q_Q(QQuickImplicitSizeItem); - for (int ii = 0; ii < changeListeners.count(); ++ii) { - const QQuickItemPrivate::ChangeListener &change = changeListeners.at(ii); - if (change.types & QQuickItemPrivate::ImplicitHeight) { - change.listener->itemImplicitHeightChanged(q); - } - } + QQuickItemPrivate::implicitHeightChanged(); emit q->implicitHeightChanged2(); } QQuickImplicitSizeItem::QQuickImplicitSizeItem(QQuickImplicitSizeItemPrivate &dd, QQuickItem *parent) : QQuickItem(dd, parent) { - connect(this, SIGNAL(implicitHeightChanged2()), this, SIGNAL(implicitHeightChanged())); - connect(this, SIGNAL(implicitWidthChanged2()), this, SIGNAL(implicitWidthChanged())); } QT_END_NAMESPACE |