diff options
| author | Sérgio Martins <sergio.martins.qnx@kdab.com> | 2012-09-07 12:00:30 +0100 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2012-10-11 16:07:33 +0200 |
| commit | 2c9886dfb9d448b08794d88ea112076c2744f194 (patch) | |
| tree | b569067de827a34cc24c37014d77bf4de30afea7 /src/quick/items/qquickitem_p.h | |
| parent | cad818ae17c5537a2bbf733806719eafa8227032 (diff) | |
Fix performance bottleneck in QQuickWindow::mouseMoveEvent().
When a mouse move event is received, a lot of time is spent looking
for items with cursors, recursively.
With this patch, it will only recur into item hierarchies that
contain cursors.
Not having cursors is much more common than having them.
Benchmark included:
Before: 15 msecs per iteration (total: 62, iterations: 4)
After: 0.000064 msecs per iteration (total: 68, iterations: 1048576)
Task-number: QTBUG-27054
Change-Id: I3a5441652ca1c0b8d2cbc5683013562174f5af4a
Reviewed-by: Alan Alpert <416365416c@gmail.com>
Diffstat (limited to 'src/quick/items/qquickitem_p.h')
| -rw-r--r-- | src/quick/items/qquickitem_p.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/quick/items/qquickitem_p.h b/src/quick/items/qquickitem_p.h index 6f2642e1ae..1f372b5764 100644 --- a/src/quick/items/qquickitem_p.h +++ b/src/quick/items/qquickitem_p.h @@ -344,6 +344,7 @@ public: mutable QQuickItemLayer *layer; #ifndef QT_NO_CURSOR QCursor cursor; + int numItemsWithCursor; #endif QPointF userTransformOriginPoint; @@ -574,6 +575,8 @@ public: static void start(QElapsedTimer &); static qint64 elapsed(QElapsedTimer &); static qint64 restart(QElapsedTimer &); + + void incrementCursorCount(int delta); }; /* |