diff options
| author | Fabian Kosmale <fabian.kosmale@qt.io> | 2022-05-03 14:37:26 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-06-04 09:13:47 +0000 |
| commit | 2ee660bec2e89cfa02edbe6a6e681c2aed137ec2 (patch) | |
| tree | a82c72b34dfdeced1d4db97fff132d8c18aa264c /src/quick/items/qquickitemview.cpp | |
| parent | 23dc924a0c1a924816e5ae08fe2dfec52edd5eaa (diff) | |
Avoid double applyDelegateChange in QQIV::setDelegate
If a QQmlDelegateModel is used together with QQuickItemView, then we
will already call applyDelegateChange when the DelegateModel's
delegateChanged signal is emitted from QQmlDelegateModel::setDelegate.
Calling it manually in QQuickItemView's setDelegate is thus superfluous.
Fixes: QTBUG-102793
Change-Id: Ifffb23661813c4e71287538ec5342215dfbbdad6
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 2664b1988f031366c2616581e65b0e02e37e3ff1)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src/quick/items/qquickitemview.cpp')
| -rw-r--r-- | src/quick/items/qquickitemview.cpp | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/quick/items/qquickitemview.cpp b/src/quick/items/qquickitemview.cpp index 61f7608de8..137c1675a8 100644 --- a/src/quick/items/qquickitemview.cpp +++ b/src/quick/items/qquickitemview.cpp @@ -290,8 +290,6 @@ void QQuickItemView::setDelegate(QQmlComponent *delegate) if (QQmlDelegateModel *dataModel = qobject_cast<QQmlDelegateModel*>(d->model)) { int oldCount = dataModel->count(); dataModel->setDelegate(delegate); - if (isComponentComplete()) - d->applyDelegateChange(); if (oldCount != dataModel->count()) emit countChanged(); } |