aboutsummaryrefslogtreecommitdiffstats
path: root/src/quick/items/qquickitemview.cpp
diff options
context:
space:
mode:
authorJ-P Nurmi <jpnurmi@digia.com>2014-05-06 12:22:32 +0200
committerThe Qt Project <gerrit-noreply@qt-project.org>2014-05-07 14:46:50 +0200
commit556846aa1fd5594156116c33ebf57b1f58fff53e (patch)
tree96ca09ac395959bccdfcb929c3a993786723fef7 /src/quick/items/qquickitemview.cpp
parentac9f1332c2a66203d3039626512773a28fd8dca0 (diff)
Item views: prevent negative cache buffer
A negative cache buffer does not make much sense, and the item views would go crazy and start creating/destructing delegates endlessly. Task-number: QTBUG-38725 Change-Id: I1fbba1f3130a99af67fbc4c2aba4d3199d0554a9 Reviewed-by: Liang Qi <liang.qi@digia.com> Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Diffstat (limited to 'src/quick/items/qquickitemview.cpp')
-rw-r--r--src/quick/items/qquickitemview.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/quick/items/qquickitemview.cpp b/src/quick/items/qquickitemview.cpp
index b4f6c34c6a..87e6728f86 100644
--- a/src/quick/items/qquickitemview.cpp
+++ b/src/quick/items/qquickitemview.cpp
@@ -454,6 +454,11 @@ int QQuickItemView::cacheBuffer() const
void QQuickItemView::setCacheBuffer(int b)
{
Q_D(QQuickItemView);
+ if (b < 0) {
+ qmlInfo(this) << "Cannot set a negative cache buffer";
+ return;
+ }
+
if (d->buffer != b) {
d->buffer = b;
if (isComponentComplete()) {