diff options
| author | Richard Moe Gustavsen <richard.gustavsen@qt.io> | 2018-09-07 13:55:23 +0200 |
|---|---|---|
| committer | Richard Moe Gustavsen <richard.gustavsen@qt.io> | 2018-09-10 09:30:58 +0000 |
| commit | 2aaf007c1367f58ce80bc660c56ab2c3284d1388 (patch) | |
| tree | bde3db0fd685eda84ab35712ce19bd7c03a4c1e0 /src/quick/items/qquicktableview_p_p.h | |
| parent | 8415875d286f2ecc78e77e9c19972f323f76054a (diff) | |
QQuickTableView: don't override margins API in TableView
Flickable has a margins API with the exact same naming as
the margins API in TableView. This means that overriding those
properties in TableView was an oversight, and a mistake.
This patch will therefore remove the margins API from
TableView. However, since the API already exists is in
Flickable, the resulting API remains unchanged. But it
will ease the TableView implementation a bit, since we
can then remove code that takes margins into account (since
Flickable does this automatically for us).
The only real difference that will take effect from this
change, is that any overlay or underlay items inside the
flickable will need to have negative coordinates if you
want to position them on top of the margins (e.g to create
a header on top of the table).
Change-Id: I43af66e49f5ddff90739a1c789aacb77ed18b4ce
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'src/quick/items/qquicktableview_p_p.h')
| -rw-r--r-- | src/quick/items/qquicktableview_p_p.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/quick/items/qquicktableview_p_p.h b/src/quick/items/qquicktableview_p_p.h index 1e8c10c285..e7b2c57086 100644 --- a/src/quick/items/qquicktableview_p_p.h +++ b/src/quick/items/qquicktableview_p_p.h @@ -227,7 +227,6 @@ public: QPoint contentSizeBenchMarkPoint = QPoint(-1, -1); QSizeF cellSpacing = QSizeF(0, 0); - QMarginsF tableMargins; QQmlTableInstanceModel::ReusableFlag reusableFlag = QQmlTableInstanceModel::Reusable; |