Create rectangle nodes in the text editing through the context

Unfortunately we can't re-use the QSGSimpleRectNode, as it doesn't provide us
with virtual methods to move it's creation into the context. But's since it's
only 20 lines of code anyway, this is still a nice cleanup. And it also allows
the re-use of any optimizations in the renderer for QSGRectangleNode.

Change-Id: I957777fbbeb0a994a9c257baf3bfe87fce8cc9e8
Reviewed-by: Lars Knoll <lars.knoll@digia.com>

1 files changed, 11 insertions, 5 deletions

diff --git a/src/quick/items/qquicktextinput.cpp b/src/quick/items/qquicktextinput.cpp
index f2cf89c1b9..c63e1c87e6 100644
--- a/src/quick/items/qquicktextinput.cpp
+++ b/src/quick/items/qquicktextinput.cpp
@@ -1861,7 +1861,7 @@ QSGNode *QQuickTextInput::updatePaintNode(QSGNode *oldNode, UpdatePaintNodeData
     d->textNode = node;
 
     if (!d->textLayoutDirty && oldNode != 0) {
-        QSGSimpleRectNode *cursorNode = node->cursorNode();
+        QSGRectangleNode *cursorNode = node->cursorNode();
         if (cursorNode != 0 && !isReadOnly()) {
             cursorNode->setRect(cursorRectangle());
 
@@ -2706,14 +2706,20 @@ void QQuickTextInput::selectionChanged()
 
 void QQuickTextInputPrivate::showCursor()
 {
-    if (textNode != 0 && textNode->cursorNode() != 0)
-        textNode->cursorNode()->setColor(color);
+    if (textNode != 0 && textNode->cursorNode() != 0) {
+        QSGRectangleNode *cursor = textNode->cursorNode();
+        cursor->setColor(color);
+        cursor->update();
+    }
 }
 
 void QQuickTextInputPrivate::hideCursor()
 {
-    if (textNode != 0 && textNode->cursorNode() != 0)
-        textNode->cursorNode()->setColor(QColor(0, 0, 0, 0));
+    if (textNode != 0 && textNode->cursorNode() != 0) {
+        QSGRectangleNode *cursor = textNode->cursorNode();
+        cursor->setColor(QColor(0, 0, 0, 0));
+        cursor->update();
+    }
 }
 
 QRectF QQuickTextInput::boundingRect() const