diff options
author | Andrew den Exter <andrew.den-exter@nokia.com> | 2012-03-15 15:55:24 +1000 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-03-15 09:01:23 +0100 |
commit | 1c7b0362b8a1d230e52b7ee5df2aa36a3217b79b (patch) | |
tree | 7543fc01024be8c61a2b62dcb0ec62e61dd517d3 /src/quick/items/qquickvisualdatamodel_p_p.h | |
parent | d7f2a77f2b236de6b08b4c8905722280d9c44541 (diff) |
Don't leak function objects created by VisualDataModel.
Function objects created from a FunctionTemplate are not short lived,
and the objects created by a VisualDataModel can change between
instances meaning a template is needed per instance. So use an object
template as a constructor instead of a function.
Change-Id: I364c6e4f714a623b7adb7475a3ee9862eeeeb119
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Diffstat (limited to 'src/quick/items/qquickvisualdatamodel_p_p.h')
-rw-r--r-- | src/quick/items/qquickvisualdatamodel_p_p.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/quick/items/qquickvisualdatamodel_p_p.h b/src/quick/items/qquickvisualdatamodel_p_p.h index c53ed5bdbb..c2db04511d 100644 --- a/src/quick/items/qquickvisualdatamodel_p_p.h +++ b/src/quick/items/qquickvisualdatamodel_p_p.h @@ -92,7 +92,7 @@ public: QV8Engine * const v8Engine; QMetaObject *metaObject; const QStringList groupNames; - v8::Persistent<v8::Function> constructor; + v8::Persistent<v8::ObjectTemplate> constructor; }; class QQuickVisualAdaptorModel; |