aboutsummaryrefslogtreecommitdiffstats
path: root/src/quick/items/qquickwindow_p.h
diff options
context:
space:
mode:
authorJan Arve Saether <jan-arve.saether@qt.io>2017-11-06 14:20:59 +0100
committerShawn Rutledge <shawn.rutledge@qt.io>2017-11-07 05:03:01 +0000
commit75cc5fdc219c42ae26ec8497647eda5440c324f2 (patch)
tree8a4cb5a57afabe36ddb6fff23792ce3951ddcd21 /src/quick/items/qquickwindow_p.h
parent37d25a5112cdf13620715c03d6bdbd1bc3cde515 (diff)
Never create pointer events from mouseGrabberItem()
Normally, this was not a problem, but it is problematic during QQuickWindow destruction: The list of pointer event instances are destroyed, but later the grabber is removed (through call to removeGrabber()). This queries the mouseGrabberItem(), which would create a new pointer event instance. It also has the benefit that d->pointerEventInstances are now only populated due to actual incoming events. Task-number: QTBUG-61434 Change-Id: I4e7b6f5643f3b971138a1f7c7237ee734d29783c Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Diffstat (limited to 'src/quick/items/qquickwindow_p.h')
-rw-r--r--src/quick/items/qquickwindow_p.h1
1 files changed, 1 insertions, 0 deletions
diff --git a/src/quick/items/qquickwindow_p.h b/src/quick/items/qquickwindow_p.h
index b3ff5a2b35..e47dde6464 100644
--- a/src/quick/items/qquickwindow_p.h
+++ b/src/quick/items/qquickwindow_p.h
@@ -164,6 +164,7 @@ public:
// the device-specific event instances which are reused during event delivery
mutable QVector<QQuickPointerEvent *> pointerEventInstances;
+ QQuickPointerEvent *queryPointerEventInstance(QQuickPointerDevice *device) const;
QQuickPointerEvent *pointerEventInstance(QQuickPointerDevice *device) const;
// delivery of pointer events: