Use QStringBuilder more

Reduce allocations.

Change-Id: I8b8a0d0360e618c65894f1f7c12476b41a1dbc5d
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>

3 files changed, 15 insertions, 22 deletions

diff --git a/src/quick/items/qquickopenglshadereffect.cpp b/src/quick/items/qquickopenglshadereffect.cpp
index b974641cca..42fcee3c0d 100644
--- a/src/quick/items/qquickopenglshadereffect.cpp
+++ b/src/quick/items/qquickopenglshadereffect.cpp
@@ -284,14 +284,14 @@ void QQuickOpenGLShaderEffectCommon::updateParseLog(bool ignoreAttributes)
     parseLog.clear();
     if (!ignoreAttributes) {
         if (!attributes.contains(qtPositionAttributeName())) {
-            parseLog += QLatin1String("Warning: Missing reference to \'");
-            parseLog += QLatin1String(qtPositionAttributeName());
-            parseLog += QLatin1String("\'.\n");
+            parseLog += QLatin1String("Warning: Missing reference to \'")
+                        + QLatin1String(qtPositionAttributeName())
+                        + QLatin1String("\'.\n");
         }
         if (!attributes.contains(qtTexCoordAttributeName())) {
-            parseLog += QLatin1String("Warning: Missing reference to \'");
-            parseLog += QLatin1String(qtTexCoordAttributeName());
-            parseLog += QLatin1String("\'.\n");
+            parseLog += QLatin1String("Warning: Missing reference to \'")
+                        + QLatin1String(qtTexCoordAttributeName())
+                        + QLatin1String("\'.\n");
         }
     }
     bool respectsMatrix = false;
@@ -918,9 +918,7 @@ QSGNode *QQuickOpenGLShaderEffect::handleUpdatePaintNode(QSGNode *oldNode, QQuic
         if (!mesh->validateAttributes(m_common.attributes, &posIndex)) {
             QString log = mesh->log();
             if (!log.isNull()) {
-                m_log = parseLog();
-                m_log += QLatin1String("*** Mesh ***\n");
-                m_log += log;
+                m_log = parseLog() + QLatin1String("*** Mesh ***\n") + log;
                 m_status = QQuickShaderEffect::Error;
                 emit m_item->logChanged();
                 emit m_item->statusChanged();
diff --git a/src/quick/items/qquickopenglshadereffectnode.cpp b/src/quick/items/qquickopenglshadereffectnode.cpp
index 02b76b2dbc..e01ecc59e3 100644
--- a/src/quick/items/qquickopenglshadereffectnode.cpp
+++ b/src/quick/items/qquickopenglshadereffectnode.cpp
@@ -261,13 +261,11 @@ void QQuickCustomMaterialShader::compile()
     m_log.clear();
     m_compiled = true;
     if (!program()->addShaderFromSourceCode(QOpenGLShader::Vertex, vertexShader())) {
-        m_log += QLatin1String("*** Vertex shader ***\n");
-        m_log += program()->log();
+        m_log += QLatin1String("*** Vertex shader ***\n") + program()->log();
         m_compiled = false;
     }
     if (!program()->addShaderFromSourceCode(QOpenGLShader::Fragment, fragmentShader())) {
-        m_log += QLatin1String("*** Fragment shader ***\n");
-        m_log += program()->log();
+        m_log += QLatin1String("*** Fragment shader ***\n") + program()->log();
         m_compiled = false;
     }
 
diff --git a/src/quick/items/qquickshadereffectmesh.cpp b/src/quick/items/qquickshadereffectmesh.cpp
index 8616bf8022..c1499579e6 100644
--- a/src/quick/items/qquickshadereffectmesh.cpp
+++ b/src/quick/items/qquickshadereffectmesh.cpp
@@ -95,9 +95,8 @@ bool QQuickGridMesh::validateAttributes(const QVector<QByteArray> &attributes, i
         return false;
     case 1:
         if (positionIndex != 0) {
-            m_log = QLatin1String("Error: Missing \'");
-            m_log += QLatin1String(qtPositionAttributeName());
-            m_log += QLatin1String("\' attribute.\n");
+            m_log = QLatin1String("Error: Missing \'") + QLatin1String(qtPositionAttributeName())
+                    + QLatin1String("\' attribute.\n");
             return false;
         }
         break;
@@ -105,14 +104,12 @@ bool QQuickGridMesh::validateAttributes(const QVector<QByteArray> &attributes, i
         if (positionIndex == -1 || texCoordIndex == -1) {
             m_log.clear();
             if (positionIndex == -1) {
-                m_log = QLatin1String("Error: Missing \'");
-                m_log += QLatin1String(qtPositionAttributeName());
-                m_log += QLatin1String("\' attribute.\n");
+                m_log = QLatin1String("Error: Missing \'") + QLatin1String(qtPositionAttributeName())
+                        + QLatin1String("\' attribute.\n");
             }
             if (texCoordIndex == -1) {
-                m_log += QLatin1String("Error: Missing \'");
-                m_log += QLatin1String(qtTexCoordAttributeName());
-                m_log += QLatin1String("\' attribute.\n");
+                m_log += QLatin1String("Error: Missing \'") + QLatin1String(qtTexCoordAttributeName())
+                         + QLatin1String("\' attribute.\n");
             }
             return false;
         }