diff options
author | Gabriel de Dietrich <gabriel.dedietrich@digia.com> | 2013-10-03 17:04:40 +0200 |
---|---|---|
committer | The Qt Project <gerrit-noreply@qt-project.org> | 2013-10-03 17:48:34 +0200 |
commit | 4ce2c0310c55c78b783b79c1f3fa2e0aa40fe6a2 (patch) | |
tree | 87377c239ce939b9ccb11680e326ca90ca9d44c0 /src/quick/items | |
parent | df0347a9ed8be8e1d3d771c3d2abcfebec9ed87d (diff) |
Remane private QQuickAction into QQuickStateAction
This avoid symbol conflicts when statically linking with Qt Quick
Controls, that has its own QQuickAction class and which may become
public some day. (QQuickPropertyAction might be a more apt name, but
it's already taken).
Change-Id: Ia9514d63d38295603a89d8ec5a88815a651380f7
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
Reviewed-by: Jens Bache-Wiig <jens.bache-wiig@digia.com>
Diffstat (limited to 'src/quick/items')
-rw-r--r-- | src/quick/items/qquickflickable.cpp | 2 | ||||
-rw-r--r-- | src/quick/items/qquickitemanimation.cpp | 30 | ||||
-rw-r--r-- | src/quick/items/qquickitemviewtransition.cpp | 4 | ||||
-rw-r--r-- | src/quick/items/qquickstateoperations.cpp | 50 | ||||
-rw-r--r-- | src/quick/items/qquickstateoperations_p.h | 14 |
5 files changed, 50 insertions, 50 deletions
diff --git a/src/quick/items/qquickflickable.cpp b/src/quick/items/qquickflickable.cpp index d1caa824e7..9b5532c27f 100644 --- a/src/quick/items/qquickflickable.cpp +++ b/src/quick/items/qquickflickable.cpp @@ -211,7 +211,7 @@ public: axisData->transitionToSet = true; actions.clear(); - actions << QQuickAction(fp->contentItem, propName, toPos); + actions << QQuickStateAction(fp->contentItem, propName, toPos); QQuickTransitionManager::transition(actions, fp->rebound, fp->contentItem); return true; } diff --git a/src/quick/items/qquickitemanimation.cpp b/src/quick/items/qquickitemanimation.cpp index ae1233463e..534ad0e2f4 100644 --- a/src/quick/items/qquickitemanimation.cpp +++ b/src/quick/items/qquickitemanimation.cpp @@ -221,7 +221,7 @@ QAbstractAnimationJob* QQuickParentAnimation::transition(QQuickStateActions &act virtual void doAction() { for (int ii = 0; ii < actions.count(); ++ii) { - const QQuickAction &action = actions.at(ii); + const QQuickStateAction &action = actions.at(ii); if (reverse) action.event->reverse(); else @@ -236,7 +236,7 @@ QAbstractAnimationJob* QQuickParentAnimation::transition(QQuickStateActions &act bool hasExplicit = false; if (d->target && d->newParent) { data->reverse = false; - QQuickAction myAction; + QQuickStateAction myAction; QQuickParentChange *pc = new QQuickParentChange; pc->setObject(d->target); pc->setParent(d->newParent); @@ -246,7 +246,7 @@ QAbstractAnimationJob* QQuickParentAnimation::transition(QQuickStateActions &act hasExplicit = true; if (d->via) { viaData->reverse = false; - QQuickAction myVAction; + QQuickStateAction myVAction; QQuickParentChange *vpc = new QQuickParentChange; vpc->setObject(d->target); vpc->setParent(d->via); @@ -260,12 +260,12 @@ QAbstractAnimationJob* QQuickParentAnimation::transition(QQuickStateActions &act if (!hasExplicit) for (int i = 0; i < actions.size(); ++i) { - QQuickAction &action = actions[i]; - if (action.event && action.event->type() == QQuickActionEvent::ParentChange + QQuickStateAction &action = actions[i]; + if (action.event && action.event->type() == QQuickStateActionEvent::ParentChange && (!d->target || static_cast<QQuickParentChange*>(action.event)->object() == d->target)) { QQuickParentChange *pc = static_cast<QQuickParentChange*>(action.event); - QQuickAction myAction = action; + QQuickStateAction myAction = action; data->reverse = action.reverseEvent; //### this logic differs from PropertyAnimation @@ -285,18 +285,18 @@ QAbstractAnimationJob* QQuickParentAnimation::transition(QQuickStateActions &act if (d->via) { viaData->reverse = false; - QQuickAction myAction; + QQuickStateAction myAction; QQuickParentChange *vpc = new QQuickParentChange; vpc->setObject(pc->object()); vpc->setParent(d->via); myAction.event = vpc; viaData->pc << vpc; viaData->actions << myAction; - QQuickAction dummyAction; - QQuickAction &xAction = pc->xIsSet() && i < actions.size()-1 ? actions[++i] : dummyAction; - QQuickAction &yAction = pc->yIsSet() && i < actions.size()-1 ? actions[++i] : dummyAction; - QQuickAction &sAction = pc->scaleIsSet() && i < actions.size()-1 ? actions[++i] : dummyAction; - QQuickAction &rAction = pc->rotationIsSet() && i < actions.size()-1 ? actions[++i] : dummyAction; + QQuickStateAction dummyAction; + QQuickStateAction &xAction = pc->xIsSet() && i < actions.size()-1 ? actions[++i] : dummyAction; + QQuickStateAction &yAction = pc->yIsSet() && i < actions.size()-1 ? actions[++i] : dummyAction; + QQuickStateAction &sAction = pc->scaleIsSet() && i < actions.size()-1 ? actions[++i] : dummyAction; + QQuickStateAction &rAction = pc->rotationIsSet() && i < actions.size()-1 ? actions[++i] : dummyAction; QQuickItem *target = pc->object(); QQuickItem *targetParent = action.reverseEvent ? pc->originalParent() : pc->parent(); @@ -535,8 +535,8 @@ QAbstractAnimationJob* QQuickAnchorAnimation::transition(QQuickStateActions &act data->fromDefined = false; for (int ii = 0; ii < actions.count(); ++ii) { - QQuickAction &action = actions[ii]; - if (action.event && action.event->type() == QQuickActionEvent::AnchorChanges + QQuickStateAction &action = actions[ii]; + if (action.event && action.event->type() == QQuickStateActionEvent::AnchorChanges && (d->targets.isEmpty() || d->targets.contains(static_cast<QQuickAnchorChanges*>(action.event)->object()))) { data->actions << static_cast<QQuickAnchorChanges*>(action.event)->additionalActions(); } @@ -868,7 +868,7 @@ QAbstractAnimationJob* QQuickPathAnimation::transition(QQuickStateActions &actio int origModifiedSize = modified.count(); for (int i = 0; i < actions.count(); ++i) { - QQuickAction &action = actions[i]; + QQuickStateAction &action = actions[i]; if (action.event) continue; if (action.specifiedObject == target && action.property.name() == QLatin1String("x")) { diff --git a/src/quick/items/qquickitemviewtransition.cpp b/src/quick/items/qquickitemviewtransition.cpp index 22c0f9426e..0940fe0d22 100644 --- a/src/quick/items/qquickitemviewtransition.cpp +++ b/src/quick/items/qquickitemviewtransition.cpp @@ -127,8 +127,8 @@ void QQuickItemViewTransitionJob::startTransition(QQuickItemViewTransitionableIt } QQuickStateOperation::ActionList actions; - actions << QQuickAction(item->item, QLatin1String("x"), QVariant(to.x())); - actions << QQuickAction(item->item, QLatin1String("y"), QVariant(to.y())); + actions << QQuickStateAction(item->item, QLatin1String("x"), QVariant(to.x())); + actions << QQuickStateAction(item->item, QLatin1String("y"), QVariant(to.y())); m_transitioner->runningJobs << this; QQuickTransitionManager::transition(actions, trans, item->item); diff --git a/src/quick/items/qquickstateoperations.cpp b/src/quick/items/qquickstateoperations.cpp index 705d2e490e..00c2103289 100644 --- a/src/quick/items/qquickstateoperations.cpp +++ b/src/quick/items/qquickstateoperations.cpp @@ -350,7 +350,7 @@ QQuickStateOperation::ActionList QQuickParentChange::actions() ActionList actions; - QQuickAction a; + QQuickStateAction a; a.event = this; actions << a; @@ -358,13 +358,13 @@ QQuickStateOperation::ActionList QQuickParentChange::actions() bool ok = false; qreal x = d->xString.value.numberLiteral(&ok); if (ok) { - QQuickAction xa(d->target, QLatin1String("x"), x); + QQuickStateAction xa(d->target, QLatin1String("x"), x); actions << xa; } else { QQmlBinding *newBinding = new QQmlBinding(d->xString.value, d->target, qmlContext(this)); QQmlProperty property(d->target, QLatin1String("x")); newBinding->setTarget(property); - QQuickAction xa; + QQuickStateAction xa; xa.property = property; xa.toBinding = QQmlAbstractBinding::getPointer(newBinding); xa.fromValue = xa.property.read(); @@ -377,13 +377,13 @@ QQuickStateOperation::ActionList QQuickParentChange::actions() bool ok = false; qreal y = d->yString.value.numberLiteral(&ok); if (ok) { - QQuickAction ya(d->target, QLatin1String("y"), y); + QQuickStateAction ya(d->target, QLatin1String("y"), y); actions << ya; } else { QQmlBinding *newBinding = new QQmlBinding(d->yString.value, d->target, qmlContext(this)); QQmlProperty property(d->target, QLatin1String("y")); newBinding->setTarget(property); - QQuickAction ya; + QQuickStateAction ya; ya.property = property; ya.toBinding = QQmlAbstractBinding::getPointer(newBinding); ya.fromValue = ya.property.read(); @@ -396,13 +396,13 @@ QQuickStateOperation::ActionList QQuickParentChange::actions() bool ok = false; qreal scale = d->scaleString.value.numberLiteral(&ok); if (ok) { - QQuickAction sa(d->target, QLatin1String("scale"), scale); + QQuickStateAction sa(d->target, QLatin1String("scale"), scale); actions << sa; } else { QQmlBinding *newBinding = new QQmlBinding(d->scaleString.value, d->target, qmlContext(this)); QQmlProperty property(d->target, QLatin1String("scale")); newBinding->setTarget(property); - QQuickAction sa; + QQuickStateAction sa; sa.property = property; sa.toBinding = QQmlAbstractBinding::getPointer(newBinding); sa.fromValue = sa.property.read(); @@ -415,13 +415,13 @@ QQuickStateOperation::ActionList QQuickParentChange::actions() bool ok = false; qreal rotation = d->rotationString.value.numberLiteral(&ok); if (ok) { - QQuickAction ra(d->target, QLatin1String("rotation"), rotation); + QQuickStateAction ra(d->target, QLatin1String("rotation"), rotation); actions << ra; } else { QQmlBinding *newBinding = new QQmlBinding(d->rotationString.value, d->target, qmlContext(this)); QQmlProperty property(d->target, QLatin1String("rotation")); newBinding->setTarget(property); - QQuickAction ra; + QQuickStateAction ra; ra.property = property; ra.toBinding = QQmlAbstractBinding::getPointer(newBinding); ra.fromValue = ra.property.read(); @@ -434,13 +434,13 @@ QQuickStateOperation::ActionList QQuickParentChange::actions() bool ok = false; qreal width = d->widthString.value.numberLiteral(&ok); if (ok) { - QQuickAction wa(d->target, QLatin1String("width"), width); + QQuickStateAction wa(d->target, QLatin1String("width"), width); actions << wa; } else { QQmlBinding *newBinding = new QQmlBinding(d->widthString.value, d->target, qmlContext(this)); QQmlProperty property(d->target, QLatin1String("width")); newBinding->setTarget(property); - QQuickAction wa; + QQuickStateAction wa; wa.property = property; wa.toBinding = QQmlAbstractBinding::getPointer(newBinding); wa.fromValue = wa.property.read(); @@ -453,13 +453,13 @@ QQuickStateOperation::ActionList QQuickParentChange::actions() bool ok = false; qreal height = d->heightString.value.numberLiteral(&ok); if (ok) { - QQuickAction ha(d->target, QLatin1String("height"), height); + QQuickStateAction ha(d->target, QLatin1String("height"), height); actions << ha; } else { QQmlBinding *newBinding = new QQmlBinding(d->heightString.value, d->target, qmlContext(this)); QQmlProperty property(d->target, QLatin1String("height")); newBinding->setTarget(property); - QQuickAction ha; + QQuickStateAction ha; ha.property = property; ha.toBinding = QQmlAbstractBinding::getPointer(newBinding); ha.fromValue = ha.property.read(); @@ -479,7 +479,7 @@ void QQuickParentChange::saveOriginals() d->origStackBefore = d->rewindStackBefore; } -/*void QQuickParentChange::copyOriginals(QQuickActionEvent *other) +/*void QQuickParentChange::copyOriginals(QQuickStateActionEvent *other) { Q_D(QQuickParentChange); QQuickParentChange *pc = static_cast<QQuickParentChange*>(other); @@ -507,12 +507,12 @@ void QQuickParentChange::reverse(Reason) d->doChange(d->origParent, d->origStackBefore); } -QQuickActionEvent::EventType QQuickParentChange::type() const +QQuickStateActionEvent::EventType QQuickParentChange::type() const { return ParentChange; } -bool QQuickParentChange::override(QQuickActionEvent*other) +bool QQuickParentChange::override(QQuickStateActionEvent*other) { Q_D(QQuickParentChange); if (other->type() != ParentChange) @@ -926,7 +926,7 @@ QQuickAnchorChanges::ActionList QQuickAnchorChanges::actions() d->baselineBinding->setTarget(d->baselineProp); } - QQuickAction a; + QQuickStateAction a; a.event = this; return ActionList() << a; } @@ -1191,22 +1191,22 @@ void QQuickAnchorChanges::reverse(Reason reason) d->target->setY(d->origY); } -QQuickActionEvent::EventType QQuickAnchorChanges::type() const +QQuickStateActionEvent::EventType QQuickAnchorChanges::type() const { return AnchorChanges; } -QList<QQuickAction> QQuickAnchorChanges::additionalActions() +QList<QQuickStateAction> QQuickAnchorChanges::additionalActions() { Q_D(QQuickAnchorChanges); - QList<QQuickAction> extra; + QList<QQuickStateAction> extra; QQuickAnchors::Anchors combined = d->anchorSet->d_func()->usedAnchors | d->anchorSet->d_func()->resetAnchors; bool hChange = combined & QQuickAnchors::Horizontal_Mask; bool vChange = combined & QQuickAnchors::Vertical_Mask; if (d->target) { - QQuickAction a; + QQuickStateAction a; if (hChange && d->fromX != d->toX) { a.property = QQmlProperty(d->target, QLatin1String("x")); a.toValue = d->toX; @@ -1265,7 +1265,7 @@ void QQuickAnchorChanges::saveOriginals() saveCurrentValues(); } -void QQuickAnchorChanges::copyOriginals(QQuickActionEvent *other) +void QQuickAnchorChanges::copyOriginals(QQuickStateActionEvent *other) { Q_D(QQuickAnchorChanges); QQuickAnchorChanges *ac = static_cast<QQuickAnchorChanges*>(other); @@ -1301,7 +1301,7 @@ void QQuickAnchorChanges::copyOriginals(QQuickActionEvent *other) << acp->topBinding << acp->bottomBinding << acp->vCenterBinding << acp->baselineBinding; //clear old values from other - //### could this be generalized for all QQuickActionEvents, and called after copyOriginals? + //### could this be generalized for all QQuickStateActionEvents, and called after copyOriginals? acp->leftBinding = 0; acp->rightBinding = 0; acp->hCenterBinding = 0; @@ -1368,11 +1368,11 @@ void QQuickAnchorChanges::clearBindings() } } -bool QQuickAnchorChanges::override(QQuickActionEvent*other) +bool QQuickAnchorChanges::override(QQuickStateActionEvent*other) { if (other->type() != AnchorChanges) return false; - if (static_cast<QQuickActionEvent*>(this) == other) + if (static_cast<QQuickStateActionEvent*>(this) == other) return true; if (static_cast<QQuickAnchorChanges*>(other)->object() == object()) return true; diff --git a/src/quick/items/qquickstateoperations_p.h b/src/quick/items/qquickstateoperations_p.h index d1d69f061d..bb81be7a18 100644 --- a/src/quick/items/qquickstateoperations_p.h +++ b/src/quick/items/qquickstateoperations_p.h @@ -52,7 +52,7 @@ QT_BEGIN_NAMESPACE class QQuickParentChangePrivate; -class Q_AUTOTEST_EXPORT QQuickParentChange : public QQuickStateOperation, public QQuickActionEvent +class Q_AUTOTEST_EXPORT QQuickParentChange : public QQuickStateOperation, public QQuickStateActionEvent { Q_OBJECT Q_DECLARE_PRIVATE(QQuickParentChange) @@ -104,12 +104,12 @@ public: virtual ActionList actions(); virtual void saveOriginals(); - //virtual void copyOriginals(QQuickActionEvent*); + //virtual void copyOriginals(QQuickStateActionEvent*); virtual void execute(Reason reason = ActualChange); virtual bool isReversable(); virtual void reverse(Reason reason = ActualChange); virtual EventType type() const; - virtual bool override(QQuickActionEvent*other); + virtual bool override(QQuickStateActionEvent*other); virtual void rewind(); virtual void saveCurrentValues(); }; @@ -169,7 +169,7 @@ private: }; class QQuickAnchorChangesPrivate; -class Q_AUTOTEST_EXPORT QQuickAnchorChanges : public QQuickStateOperation, public QQuickActionEvent +class Q_AUTOTEST_EXPORT QQuickAnchorChanges : public QQuickStateOperation, public QQuickStateActionEvent { Q_OBJECT Q_DECLARE_PRIVATE(QQuickAnchorChanges) @@ -192,16 +192,16 @@ public: virtual bool isReversable(); virtual void reverse(Reason reason = ActualChange); virtual EventType type() const; - virtual bool override(QQuickActionEvent*other); + virtual bool override(QQuickStateActionEvent*other); virtual bool changesBindings(); virtual void saveOriginals(); virtual bool needsCopy() { return true; } - virtual void copyOriginals(QQuickActionEvent*); + virtual void copyOriginals(QQuickStateActionEvent*); virtual void clearBindings(); virtual void rewind(); virtual void saveCurrentValues(); - QList<QQuickAction> additionalActions(); + QList<QQuickStateAction> additionalActions(); virtual void saveTargetValues(); }; |