aboutsummaryrefslogtreecommitdiffstats
path: root/src/quick/items
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@digia.com>2013-07-05 13:29:57 +0200
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-07-05 15:02:58 +0200
commit5d6f8b18fe77d2fc17a3c1d77d1c4baeff0e9704 (patch)
tree507f652c897825a7f6b3a09a5dd2c09d6c1797f4 /src/quick/items
parent2e4d1ccb18aba13f94670d3d1104839fecf2ab5c (diff)
Get rid of the first half of QQmlGuard usage
QQmlGuard was being used as a more performant replacement for QPointer. QPointer got now fixed in Qt 5.0, making this class obsolete. Change-Id: I77eef066c4823af4b074ef32d4d78dbd67c36cd0 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
Diffstat (limited to 'src/quick/items')
-rw-r--r--src/quick/items/qquickdrag.cpp6
-rw-r--r--src/quick/items/qquickdrag_p.h1
-rw-r--r--src/quick/items/qquickdroparea.cpp4
-rw-r--r--src/quick/items/qquickflipable.cpp7
-rw-r--r--src/quick/items/qquickgridview_p.h5
-rw-r--r--src/quick/items/qquickitemview_p_p.h2
-rw-r--r--src/quick/items/qquicklistview_p.h5
-rw-r--r--src/quick/items/qquickpathview_p_p.h5
-rw-r--r--src/quick/items/qquickrepeater_p_p.h2
-rw-r--r--src/quick/items/qquickstateoperations.cpp6
-rw-r--r--src/quick/items/qquicktextinput_p_p.h4
-rw-r--r--src/quick/items/qquickwindow.cpp2
-rw-r--r--src/quick/items/qquickwindow_p.h1
13 files changed, 24 insertions, 26 deletions
diff --git a/src/quick/items/qquickdrag.cpp b/src/quick/items/qquickdrag.cpp
index e828899204..f145ce259f 100644
--- a/src/quick/items/qquickdrag.cpp
+++ b/src/quick/items/qquickdrag.cpp
@@ -89,9 +89,9 @@ public:
QQuickDragGrabber dragGrabber;
- QQmlGuard<QObject> source;
- QQmlGuard<QObject> target;
- QQmlGuard<QQuickWindow> window;
+ QPointer<QObject> source;
+ QPointer<QObject> target;
+ QPointer<QQuickWindow> window;
QQuickItem *attachedItem;
QQuickDragMimeData *mimeData;
Qt::DropAction proposedAction;
diff --git a/src/quick/items/qquickdrag_p.h b/src/quick/items/qquickdrag_p.h
index b7fa60b748..3680fd5754 100644
--- a/src/quick/items/qquickdrag_p.h
+++ b/src/quick/items/qquickdrag_p.h
@@ -45,6 +45,7 @@
#include <QtQuick/qquickitem.h>
#include <private/qv8engine_p.h>
+#include <private/qqmlguard_p.h>
#include <QtCore/qmimedata.h>
#include <QtCore/qstringlist.h>
diff --git a/src/quick/items/qquickdroparea.cpp b/src/quick/items/qquickdroparea.cpp
index 659e606ef9..f453c42e5b 100644
--- a/src/quick/items/qquickdroparea.cpp
+++ b/src/quick/items/qquickdroparea.cpp
@@ -76,8 +76,8 @@ public:
QRegExp keyRegExp;
QPointF dragPosition;
QQuickDropAreaDrag *drag;
- QQmlGuard<QObject> source;
- QQmlGuard<QMimeData> mimeData;
+ QPointer<QObject> source;
+ QPointer<QMimeData> mimeData;
};
QQuickDropAreaPrivate::QQuickDropAreaPrivate()
diff --git a/src/quick/items/qquickflipable.cpp b/src/quick/items/qquickflipable.cpp
index 1ede6b0ea9..3428c66a62 100644
--- a/src/quick/items/qquickflipable.cpp
+++ b/src/quick/items/qquickflipable.cpp
@@ -42,7 +42,6 @@
#include "qquickflipable_p.h"
#include "qquickitem_p.h"
-#include <private/qqmlguard_p.h>
#include <QtQml/qqmlinfo.h>
@@ -78,9 +77,9 @@ public:
void setBackTransform();
QQuickFlipable::Side current;
- QQmlGuard<QQuickLocalTransform> backTransform;
- QQmlGuard<QQuickItem> front;
- QQmlGuard<QQuickItem> back;
+ QPointer<QQuickLocalTransform> backTransform;
+ QPointer<QQuickItem> front;
+ QPointer<QQuickItem> back;
bool sideDirty;
bool wantBackXFlipped;
diff --git a/src/quick/items/qquickgridview_p.h b/src/quick/items/qquickgridview_p.h
index d98de1050f..09e11adf90 100644
--- a/src/quick/items/qquickgridview_p.h
+++ b/src/quick/items/qquickgridview_p.h
@@ -42,9 +42,10 @@
#ifndef QQUICKGRIDVIEW_P_H
#define QQUICKGRIDVIEW_P_H
+#include <QtCore/qpointer.h>
+
#include "qquickitemview_p.h"
-#include <private/qqmlguard_p.h>
QT_BEGIN_NAMESPACE
@@ -133,7 +134,7 @@ Q_SIGNALS:
void viewChanged();
public:
- QQmlGuard<QQuickGridView> m_view;
+ QPointer<QQuickGridView> m_view;
};
diff --git a/src/quick/items/qquickitemview_p_p.h b/src/quick/items/qquickitemview_p_p.h
index 1fa933ebd1..6b734eab92 100644
--- a/src/quick/items/qquickitemview_p_p.h
+++ b/src/quick/items/qquickitemview_p_p.h
@@ -249,7 +249,7 @@ public:
q->polish();
}
- QQmlGuard<QQmlInstanceModel> model;
+ QPointer<QQmlInstanceModel> model;
QVariant modelVariant;
int itemCount;
int buffer;
diff --git a/src/quick/items/qquicklistview_p.h b/src/quick/items/qquicklistview_p.h
index 3e766f8068..f612e7eab9 100644
--- a/src/quick/items/qquicklistview_p.h
+++ b/src/quick/items/qquicklistview_p.h
@@ -43,8 +43,7 @@
#define QQUICKLISTVIEW_P_H
#include "qquickitemview_p.h"
-
-#include <private/qqmlguard_p.h>
+#include <qpointer.h>
QT_BEGIN_NAMESPACE
@@ -192,7 +191,7 @@ Q_SIGNALS:
void viewChanged();
public:
- QQmlGuard<QQuickListView> m_view;
+ QPointer<QQuickListView> m_view;
QQuickItem *m_sectionItem;
};
diff --git a/src/quick/items/qquickpathview_p_p.h b/src/quick/items/qquickpathview_p_p.h
index 26533057d1..aa539e7cfc 100644
--- a/src/quick/items/qquickpathview_p_p.h
+++ b/src/quick/items/qquickpathview_p_p.h
@@ -61,7 +61,6 @@
#include <QtCore/qcoreapplication.h>
#include <private/qquickanimation_p_p.h>
-#include <private/qqmlguard_p.h>
#include <private/qqmldelegatemodel_p.h>
#include <private/qquicktimeline_p_p.h>
@@ -132,7 +131,7 @@ public:
QQuickPath *path;
int currentIndex;
- QQmlGuard<QQuickItem> currentItem;
+ QPointer<QQuickItem> currentItem;
qreal currentItemOffset;
qreal startPc;
QPointF startPoint;
@@ -169,7 +168,7 @@ public:
qreal requestedZ;
QList<QQuickItem *> items;
QList<QQuickItem *> itemCache;
- QQmlGuard<QQmlInstanceModel> model;
+ QPointer<QQmlInstanceModel> model;
QVariant modelVariant;
enum MovementReason { Other, SetIndex, Mouse };
MovementReason moveReason;
diff --git a/src/quick/items/qquickrepeater_p_p.h b/src/quick/items/qquickrepeater_p_p.h
index a642f6479a..6430b3bc49 100644
--- a/src/quick/items/qquickrepeater_p_p.h
+++ b/src/quick/items/qquickrepeater_p_p.h
@@ -75,7 +75,7 @@ private:
QPointer<QQmlInstanceModel> model;
QVariant dataSource;
- QQmlGuard<QObject> dataSourceAsObject;
+ QPointer<QObject> dataSourceAsObject;
bool ownModel : 1;
bool inRequest : 1;
bool dataSourceIsObject : 1;
diff --git a/src/quick/items/qquickstateoperations.cpp b/src/quick/items/qquickstateoperations.cpp
index 24476b10a2..b1c548f95e 100644
--- a/src/quick/items/qquickstateoperations.cpp
+++ b/src/quick/items/qquickstateoperations.cpp
@@ -57,9 +57,9 @@ public:
rewindParent(0), rewindStackBefore(0) {}
QQuickItem *target;
- QQmlGuard<QQuickItem> parent;
- QQmlGuard<QQuickItem> origParent;
- QQmlGuard<QQuickItem> origStackBefore;
+ QPointer<QQuickItem> parent;
+ QPointer<QQuickItem> origParent;
+ QPointer<QQuickItem> origStackBefore;
QQuickItem *rewindParent;
QQuickItem *rewindStackBefore;
diff --git a/src/quick/items/qquicktextinput_p_p.h b/src/quick/items/qquicktextinput_p_p.h
index 11096cfa1d..7b3f61b1fb 100644
--- a/src/quick/items/qquicktextinput_p_p.h
+++ b/src/quick/items/qquicktextinput_p_p.h
@@ -189,9 +189,9 @@ public:
QPointF pressPos;
QPointF tripleClickStartPoint;
- QQmlGuard<QQmlComponent> cursorComponent;
+ QPointer<QQmlComponent> cursorComponent;
#ifndef QT_NO_VALIDATOR
- QQmlGuard<QValidator> m_validator;
+ QPointer<QValidator> m_validator;
#endif
qreal hscroll;
diff --git a/src/quick/items/qquickwindow.cpp b/src/quick/items/qquickwindow.cpp
index 619c72afb8..cf2526e5a7 100644
--- a/src/quick/items/qquickwindow.cpp
+++ b/src/quick/items/qquickwindow.cpp
@@ -783,7 +783,7 @@ void QQuickWindowPrivate::clearFocusInScope(QQuickItem *scope, QQuickItem *item,
void QQuickWindowPrivate::notifyFocusChangesRecur(QQuickItem **items, int remaining)
{
- QQmlGuard<QQuickItem> item(*items);
+ QPointer<QQuickItem> item(*items);
if (remaining)
notifyFocusChangesRecur(items + 1, remaining - 1);
diff --git a/src/quick/items/qquickwindow_p.h b/src/quick/items/qquickwindow_p.h
index 2dddd9ab68..aa7d7c5128 100644
--- a/src/quick/items/qquickwindow_p.h
+++ b/src/quick/items/qquickwindow_p.h
@@ -55,7 +55,6 @@
#include "qquickitem.h"
#include "qquickwindow.h"
-#include <private/qqmlguard_p.h>
#include <QtQuick/private/qsgcontext_p.h>
#include <private/qquickdrag_p.h>