diff options
author | Ulf Hermann <ulf.hermann@qt.io> | 2022-02-03 10:02:06 +0100 |
---|---|---|
committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-02-04 00:37:48 +0000 |
commit | cee33a6d621e1b3ec0fe120efe15ef4910b9c35f (patch) | |
tree | 9e432a77c3da2fd1c9eab0b928b278631eb1dc0a /src/quick/util/qquickdeliveryagent_p_p.h | |
parent | a02496b639f53433add799d3540687376fee0ba9 (diff) |
V4: Do not call dtor of an object we continue to use
After destroyObject(), the QObjectWrapper is still alive. We might use
its heap object again. Furthermore, the Heap::QObjectWrapper dtor does
not actually do anything defined. What we want to do here is clear the
QObject pointer because we've just gotten rid of the QObject. There is a
method for that: Heap::QObjectWrapper::destroy().
Finally, the internalClass must never ever be nullptr. Assert on that
rather than checking it.
Task-number: QTBUG-100431
Change-Id: I794a295c182b2ed4ba80673f58d6143c861b7391
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 6c197319f34b8098d034f1543eb5feb9d7be54c3)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src/quick/util/qquickdeliveryagent_p_p.h')
0 files changed, 0 insertions, 0 deletions