diff options
| author | Andrew den Exter <andrew.den-exter@nokia.com> | 2012-05-23 14:58:13 +1000 |
|---|---|---|
| committer | Qt by Nokia <qt-info@nokia.com> | 2012-05-24 04:04:33 +0200 |
| commit | 2542778d4837143a61dfcf143c32683acc8b998a (patch) | |
| tree | d8de075e1a1fc65a8a825eacafed928e1723d388 /src/quick/util/qquicklistcompositor_p.h | |
| parent | 5008fc55cf1ab1c776ccd431525fe54b7afeea00 (diff) | |
Fix crash in VisualDataModel drag selection example.
The crash was an assert on an invalid pre-condition, and that's simply
been removed. But it did highlight another issue when moving items
due to separate code paths for iterating forwards and backward in
a composited list. Basically when iterating backwards because we're
looking for the first instance of an index it's necessary to overshoot
a little to an index prior and then iterate forwards, and as such
there's little difference between iterating forward or backwards.
Change-Id: I6252e3e0170dc2c72d0204137c69275c8ccc519b
Reviewed-by: Martin Jones <martin.jones@nokia.com>
Diffstat (limited to 'src/quick/util/qquicklistcompositor_p.h')
| -rw-r--r-- | src/quick/util/qquicklistcompositor_p.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/quick/util/qquicklistcompositor_p.h b/src/quick/util/qquicklistcompositor_p.h index 5c9d679fa4..38ac0a5457 100644 --- a/src/quick/util/qquicklistcompositor_p.h +++ b/src/quick/util/qquicklistcompositor_p.h @@ -135,7 +135,6 @@ public: const Range *operator ->() const { return range; } iterator &operator +=(int difference); - iterator &operator -=(int difference); template<typename T> T *list() const { return static_cast<T *>(range->list); } int modelIndex() const { return range->index + offset; } @@ -170,7 +169,6 @@ public: inline ~insert_iterator() {} insert_iterator &operator +=(int difference); - insert_iterator &operator -=(int difference); }; struct Change |