init variables where they are declared when possible (clang-tidy)

clang-tidy -p compile_commands.json $file -checks='-*,modernize-use-default-member-init,readability-redundant-member-init'
 -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' -header-filter='qtdeclarative' -fix

Change-Id: I705f3235ff129ba68b0d8dad54a083e29fcead5f
Reviewed-by: Johan Helsing <johan.helsing@qt.io>

6 files changed, 54 insertions, 64 deletions

diff --git a/src/quick/util/qquickfontloader.cpp b/src/quick/util/qquickfontloader.cpp
index 72b9149886..2da541304d 100644
--- a/src/quick/util/qquickfontloader.cpp
+++ b/src/quick/util/qquickfontloader.cpp
@@ -77,8 +77,8 @@ Q_SIGNALS:
     void fontDownloaded(const QString&, QQuickFontLoader::Status);
 
 private:
-    int redirectCount;
-    QNetworkReply *reply;
+    int redirectCount = 0;
+    QNetworkReply *reply = nullptr;
 
 private Q_SLOTS:
     void replyFinished();
@@ -91,13 +91,8 @@ public:
 };
 
 QQuickFontObject::QQuickFontObject(int _id)
-    : QObject(nullptr)
-#if QT_CONFIG(qml_network)
-    ,redirectCount(0), reply(nullptr)
-#endif
-    ,id(_id)
+    : QObject(nullptr), id(_id)
 {
-
 }
 
 #if QT_CONFIG(qml_network)
@@ -148,11 +143,11 @@ class QQuickFontLoaderPrivate : public QObjectPrivate
     Q_DECLARE_PUBLIC(QQuickFontLoader)
 
 public:
-    QQuickFontLoaderPrivate() : status(QQuickFontLoader::Null) {}
+    QQuickFontLoaderPrivate() {}
 
     QUrl url;
     QString name;
-    QQuickFontLoader::Status status;
+    QQuickFontLoader::Status status = QQuickFontLoader::Null;
 };
 
 static void q_QFontLoaderFontsStaticReset();
diff --git a/src/quick/util/qquickimageprovider.cpp b/src/quick/util/qquickimageprovider.cpp
index e7891a6612..1a13f6395a 100644
--- a/src/quick/util/qquickimageprovider.cpp
+++ b/src/quick/util/qquickimageprovider.cpp
@@ -515,15 +515,12 @@ class QQuickImageProviderOptionsPrivate : public QSharedData
 {
 public:
     QQuickImageProviderOptionsPrivate()
-     : autoTransform(QQuickImageProviderOptions::UsePluginDefaultTransform)
-     , preserveAspectRatioCrop(false)
-     , preserveAspectRatioFit(false)
     {
     }
 
-    QQuickImageProviderOptions::AutoTransform autoTransform;
-    bool preserveAspectRatioCrop;
-    bool preserveAspectRatioFit;
+    QQuickImageProviderOptions::AutoTransform autoTransform = QQuickImageProviderOptions::UsePluginDefaultTransform;
+    bool preserveAspectRatioCrop = false;
+    bool preserveAspectRatioFit = false;
 };
 
 /*!
diff --git a/src/quick/util/qquickpath_p.h b/src/quick/util/qquickpath_p.h
index 06f6800a0e..f8b67ef945 100644
--- a/src/quick/util/qquickpath_p.h
+++ b/src/quick/util/qquickpath_p.h
@@ -90,7 +90,7 @@ class Q_QUICK_PRIVATE_EXPORT QQuickPathAttribute : public QQuickPathElement
     Q_PROPERTY(QString name READ name WRITE setName NOTIFY nameChanged)
     Q_PROPERTY(qreal value READ value WRITE setValue NOTIFY valueChanged)
 public:
-    QQuickPathAttribute(QObject *parent=nullptr) : QQuickPathElement(parent), _value(0) {}
+    QQuickPathAttribute(QObject *parent=nullptr) : QQuickPathElement(parent) {}
 
 
     QString name() const;
@@ -105,7 +105,7 @@ Q_SIGNALS:
 
 private:
     QString _name;
-    qreal _value;
+    qreal _value = 0;
 };
 
 class Q_QUICK_PRIVATE_EXPORT QQuickCurve : public QQuickPathElement
@@ -177,7 +177,7 @@ class Q_QUICK_PRIVATE_EXPORT QQuickPathQuad : public QQuickCurve
     Q_PROPERTY(qreal relativeControlX READ relativeControlX WRITE setRelativeControlX NOTIFY relativeControlXChanged)
     Q_PROPERTY(qreal relativeControlY READ relativeControlY WRITE setRelativeControlY NOTIFY relativeControlYChanged)
 public:
-    QQuickPathQuad(QObject *parent=nullptr) : QQuickCurve(parent), _controlX(0), _controlY(0) {}
+    QQuickPathQuad(QObject *parent=nullptr) : QQuickCurve(parent) {}
 
     qreal controlX() const;
     void setControlX(qreal x);
@@ -202,8 +202,8 @@ Q_SIGNALS:
     void relativeControlYChanged();
 
 private:
-    qreal _controlX;
-    qreal _controlY;
+    qreal _controlX = 0;
+    qreal _controlY = 0;
     QQmlNullableValue<qreal> _relativeControlX;
     QQmlNullableValue<qreal> _relativeControlY;
 };
@@ -221,7 +221,7 @@ class Q_QUICK_PRIVATE_EXPORT QQuickPathCubic : public QQuickCurve
     Q_PROPERTY(qreal relativeControl2X READ relativeControl2X WRITE setRelativeControl2X NOTIFY relativeControl2XChanged)
     Q_PROPERTY(qreal relativeControl2Y READ relativeControl2Y WRITE setRelativeControl2Y NOTIFY relativeControl2YChanged)
 public:
-    QQuickPathCubic(QObject *parent=nullptr) : QQuickCurve(parent), _control1X(0), _control1Y(0), _control2X(0), _control2Y(0) {}
+    QQuickPathCubic(QObject *parent=nullptr) : QQuickCurve(parent) {}
 
     qreal control1X() const;
     void setControl1X(qreal x);
@@ -264,10 +264,10 @@ Q_SIGNALS:
     void relativeControl2YChanged();
 
 private:
-    qreal _control1X;
-    qreal _control1Y;
-    qreal _control2X;
-    qreal _control2Y;
+    qreal _control1X = 0;
+    qreal _control1Y = 0;
+    qreal _control2X = 0;
+    qreal _control2Y = 0;
     QQmlNullableValue<qreal> _relativeControl1X;
     QQmlNullableValue<qreal> _relativeControl1Y;
     QQmlNullableValue<qreal> _relativeControl2X;
@@ -294,7 +294,7 @@ class Q_QUICK_PRIVATE_EXPORT QQuickPathArc : public QQuickCurve
 
 public:
     QQuickPathArc(QObject *parent=nullptr)
-        : QQuickCurve(parent), _radiusX(0), _radiusY(0), _useLargeArc(false), _direction(Clockwise), _xAxisRotation(0) {}
+        : QQuickCurve(parent) {}
 
     enum ArcDirection { Clockwise, Counterclockwise };
     Q_ENUM(ArcDirection)
@@ -324,11 +324,11 @@ Q_SIGNALS:
     Q_REVISION(2) void xAxisRotationChanged();
 
 private:
-    qreal _radiusX;
-    qreal _radiusY;
-    bool _useLargeArc;
-    ArcDirection _direction;
-    qreal _xAxisRotation;
+    qreal _radiusX = 0;
+    qreal _radiusY = 0;
+    bool _useLargeArc = false;
+    ArcDirection _direction = Clockwise;
+    qreal _xAxisRotation = 0;
 };
 
 class Q_QUICK_PRIVATE_EXPORT QQuickPathAngleArc : public QQuickCurve
@@ -344,7 +344,7 @@ class Q_QUICK_PRIVATE_EXPORT QQuickPathAngleArc : public QQuickCurve
 
 public:
     QQuickPathAngleArc(QObject *parent=nullptr)
-        : QQuickCurve(parent), _centerX(0), _centerY(0), _radiusX(0), _radiusY(0), _startAngle(0), _sweepAngle(0), _moveToStart(true) {}
+        : QQuickCurve(parent) {}
 
     qreal centerX() const;
     void setCenterX(qreal);
@@ -379,13 +379,13 @@ Q_SIGNALS:
     void moveToStartChanged();
 
 private:
-    qreal _centerX;
-    qreal _centerY;
-    qreal _radiusX;
-    qreal _radiusY;
-    qreal _startAngle;
-    qreal _sweepAngle;
-    bool _moveToStart;
+    qreal _centerX = 0;
+    qreal _centerY = 0;
+    qreal _radiusX = 0;
+    qreal _radiusY = 0;
+    qreal _startAngle = 0;
+    qreal _sweepAngle = 0;
+    bool _moveToStart = true;
 };
 
 class Q_QUICK_PRIVATE_EXPORT QQuickPathSvg : public QQuickCurve
@@ -412,7 +412,7 @@ class Q_QUICK_PRIVATE_EXPORT QQuickPathPercent : public QQuickPathElement
     Q_OBJECT
     Q_PROPERTY(qreal value READ value WRITE setValue NOTIFY valueChanged)
 public:
-    QQuickPathPercent(QObject *parent=nullptr) : QQuickPathElement(parent), _value(0) {}
+    QQuickPathPercent(QObject *parent=nullptr) : QQuickPathElement(parent) {}
 
     qreal value() const;
     void setValue(qreal value);
@@ -421,18 +421,18 @@ Q_SIGNALS:
     void valueChanged();
 
 private:
-    qreal _value;
+    qreal _value = 0;
 };
 
 struct QQuickCachedBezier
 {
-    QQuickCachedBezier() : isValid(false) {}
+    QQuickCachedBezier() {}
     QBezier bezier;
     int element;
     qreal bezLength;
     qreal currLength;
     qreal p;
-    bool isValid;
+    bool isValid = false;
 };
 
 class QQuickPathPrivate;
@@ -494,15 +494,15 @@ private Q_SLOTS:
 
 private:
     struct AttributePoint {
-        AttributePoint() : percent(0), scale(1), origpercent(0) {}
+        AttributePoint() {}
         AttributePoint(const AttributePoint &other)
             : percent(other.percent), scale(other.scale), origpercent(other.origpercent), values(other.values) {}
         AttributePoint &operator=(const AttributePoint &other) {
             percent = other.percent; scale = other.scale; origpercent = other.origpercent; values = other.values; return *this;
         }
-        qreal percent;      //massaged percent along the painter path
-        qreal scale;
-        qreal origpercent;  //'real' percent along the painter path
+        qreal percent = 0;      //massaged percent along the painter path
+        qreal scale = 1;
+        qreal origpercent = 0;  //'real' percent along the painter path
         QHash<QString, qreal> values;
     };
 
diff --git a/src/quick/util/qquickpath_p_p.h b/src/quick/util/qquickpath_p_p.h
index f5c9664223..9735d51264 100644
--- a/src/quick/util/qquickpath_p_p.h
+++ b/src/quick/util/qquickpath_p_p.h
@@ -72,7 +72,7 @@ public:
     static QQuickPathPrivate* get(QQuickPath *path) { return path->d_func(); }
     static const QQuickPathPrivate* get(const QQuickPath *path) { return path->d_func(); }
 
-    QQuickPathPrivate() : pathLength(0), closed(false), componentComplete(true), isShapePath(false) { }
+    QQuickPathPrivate() {}
 
     QPainterPath _path;
     QList<QQuickPathElement*> _pathElements;
@@ -83,10 +83,10 @@ public:
     mutable QQuickCachedBezier prevBez;
     QQmlNullableValue<qreal> startX;
     QQmlNullableValue<qreal> startY;
-    qreal pathLength;
-    bool closed;
-    bool componentComplete;
-    bool isShapePath;
+    qreal pathLength = 0;
+    bool closed = false;
+    bool componentComplete = true;
+    bool isShapePath = false;
 };
 
 QT_END_NAMESPACE
diff --git a/src/quick/util/qquickstyledtext_p.h b/src/quick/util/qquickstyledtext_p.h
index 821f95b6bf..51f1b7d8f9 100644
--- a/src/quick/util/qquickstyledtext_p.h
+++ b/src/quick/util/qquickstyledtext_p.h
@@ -67,9 +67,7 @@ class QQmlContext;
 class Q_AUTOTEST_EXPORT QQuickStyledTextImgTag
 {
 public:
-    QQuickStyledTextImgTag()
-        : position(0), offset(0.0), align(QQuickStyledTextImgTag::Bottom), pix(nullptr)
-    { }
+    QQuickStyledTextImgTag() { }
 
     ~QQuickStyledTextImgTag() { delete pix; }
 
@@ -82,10 +80,10 @@ public:
     QUrl url;
     QPointF pos;
     QSize size;
-    int position;
-    qreal offset; // this offset allows us to compensate for flooring reserved space
-    Align align;
-    QQuickPixmap *pix;
+    int position = 0;
+    qreal offset = 0.0; // this offset allows us to compensate for flooring reserved space
+    Align align = QQuickStyledTextImgTag::Bottom;
+    QQuickPixmap *pix = nullptr;
 };
 
 class Q_AUTOTEST_EXPORT QQuickStyledText
diff --git a/src/quick/util/qquicktimeline.cpp b/src/quick/util/qquicktimeline.cpp
index 93284c0685..ac9f75979e 100644
--- a/src/quick/util/qquicktimeline.cpp
+++ b/src/quick/util/qquicktimeline.cpp
@@ -104,11 +104,11 @@ struct QQuickTimeLinePrivate
     };
     struct TimeLine
     {
-        TimeLine() : length(0), consumedOpLength(0), base(0.) {}
+        TimeLine() {}
         QList<Op> ops;
-        int length;
-        int consumedOpLength;
-        qreal base;
+        int length = 0;
+        int consumedOpLength = 0;
+        qreal base = 0.;
     };
 
     int length;