Quick: fix expensive iteration over QHash::keys() and QMap::keys()

Change-Id: I21c48214bfddde01f71710705fe01418818a6581
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>

1 files changed, 4 insertions, 2 deletions

diff --git a/src/quick/util/qquickanimatorcontroller.cpp b/src/quick/util/qquickanimatorcontroller.cpp
index 74930fb373..355dba0215 100644
--- a/src/quick/util/qquickanimatorcontroller.cpp
+++ b/src/quick/util/qquickanimatorcontroller.cpp
@@ -72,11 +72,13 @@ QQuickAnimatorController::~QQuickAnimatorController()
 
     foreach (QQuickAnimatorProxyJob *proxy, m_animatorRoots)
         proxy->controllerWasDeleted();
-    qDeleteAll(m_animatorRoots.keys());
+    for (auto it = m_animatorRoots.keyBegin(), end = m_animatorRoots.keyEnd(); it != end; ++it)
+        delete *it;
 
     // Delete those who have been started, stopped and are now still
     // pending for restart.
-    foreach (QAbstractAnimationJob *job, m_starting.keys()) {
+    for (auto it = m_starting.keyBegin(), end = m_starting.keyEnd(); it != end; ++it) {
+        QAbstractAnimationJob *job = *it;
         if (!m_animatorRoots.contains(job))
             delete job;
     }