diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2022-07-13 10:54:17 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2022-07-14 01:01:04 +0000 |
| commit | c8a85f1f7a54177883c68158f923b2f530482b14 (patch) | |
| tree | 2d297a641e1c22878428e653b858f7d356c27cde /src/quick | |
| parent | 3503d6eff3232f031a2acc26840280cf19db9383 (diff) | |
Fix memory leak in QQuickItemViewTransitionableItem::completeTransition
As we're not storing the QQuickTransitionInstance anywhere, we better
delete it when the function returns.
Change-Id: Ife4d0eee559cffd26ddd9aab8c89729269bb93e1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 813ba0591893fcca2b427dee73106c8773c3b59f)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Diffstat (limited to 'src/quick')
| -rw-r--r-- | src/quick/items/qquickitemviewtransition.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/quick/items/qquickitemviewtransition.cpp b/src/quick/items/qquickitemviewtransition.cpp index cf3176201e..a074f77aea 100644 --- a/src/quick/items/qquickitemviewtransition.cpp +++ b/src/quick/items/qquickitemviewtransition.cpp @@ -524,7 +524,8 @@ void QQuickItemViewTransitionableItem::completeTransition(QQuickTransition *quic QQuickStateOperation::ActionList actions; // not used QList<QQmlProperty> after; // not used - auto instance = quickTransition->prepare(actions, after, transition, item); + QScopedPointer<QQuickTransitionInstance> instance( + quickTransition->prepare(actions, after, transition, item)); RETURN_IF_DELETED(instance->complete()); clearCurrentScheduledTransition(); |