diff options
author | J-P Nurmi <jpnurmi@qt.io> | 2016-10-20 21:38:30 +0200 |
---|---|---|
committer | J-P Nurmi <jpnurmi@qt.io> | 2016-10-24 10:39:01 +0000 |
commit | 55b9c7c1bdc7ccaf3126622e72843a3c247cbaf4 (patch) | |
tree | b203d4011c1e12709ba04aed31ee985e52fc94e5 /src | |
parent | bb8ae2d0a0ff9f36ffaf4ba64b03bd2160c99cd2 (diff) |
Make tst_qquicktextedit::mouseSelection() pass
Since qtbase commit beef975, QTestLib avoids generating accidental
double click events by adding 500ms timestamp delta on release events.
The test requires a press-and-drag-and-release type of sequence with
double and triple clicks. The triple-click case is handled fine with
QTest::mouseDClick() + press + move + release, but the double-click
case is using QTest::mouseClick() + press + move + release and relies
on the accidental double-click event generation that QTestLib now
deliberately prevents.
I can't think of a nice way to inject the move event in the middle of
a double-click sequence generated by QTest::mouseDClick(), so we just
send the missing double-click event by hand.
We can also remove the QStyleHints::mouseDoubleClickInterval waits,
which were there to prevent the aforementioned accidental double click
events that can no longer happen. This reduces the total execution
time of mouseSelection() by roughly 90%.
Task-number: QTBUG-50022
Change-Id: I252e87d6a49ea86a44cfa347a29eebee12fd36d1
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Frederik Gladhorn <frederik.gladhorn@qt.io>
Diffstat (limited to 'src')
0 files changed, 0 insertions, 0 deletions