Fix warnings about unused Qt containers

Fixes -Wclazy-unused-non-trivial warnings, in preparation for using
gcc/clang's warn_unused attribute in all containers.

Maintainers please check if some unused variable isn't hidding an
actual bug.

Change-Id: I83c5a11aa2328db3dce4c6c402295d86ef297c83
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>

4 files changed, 5 insertions, 12 deletions

diff --git a/src/qml/compiler/qqmlirbuilder.cpp b/src/qml/compiler/qqmlirbuilder.cpp
index 9021fd0284..9ff38db911 100644
--- a/src/qml/compiler/qqmlirbuilder.cpp
+++ b/src/qml/compiler/qqmlirbuilder.cpp
@@ -2514,8 +2514,6 @@ QmlIR::Object *IRLoader::loadObject(const QV4::CompiledData::Object *serializedO
         f->location = compiledFunction->location;
         f->nameIndex = compiledFunction->nameIndex;
 
-        const QString name = unit->stringAtInternal(compiledFunction->nameIndex);
-
         f->formals.allocate(pool, int(compiledFunction->nFormals));
         const quint32_le *formalNameIdx = compiledFunction->formalsTable();
         for (uint i = 0; i < compiledFunction->nFormals; ++i, ++formalNameIdx)
diff --git a/src/qml/compiler/qv4codegen.cpp b/src/qml/compiler/qv4codegen.cpp
index 8ec730a33d..63cdb78d27 100644
--- a/src/qml/compiler/qv4codegen.cpp
+++ b/src/qml/compiler/qv4codegen.cpp
@@ -2493,9 +2493,6 @@ bool Codegen::visit(ObjectPattern *ast)
 
     TailCallBlocker blockTailCalls(this);
 
-    QVector<QPair<Reference, ObjectPropertyValue>> computedProperties;
-    QMap<QString, ObjectPropertyValue> valueMap;
-
     RegisterScope scope(this);
 
     QStringList members;
diff --git a/src/qml/qml/qqmltypeloader.cpp b/src/qml/qml/qqmltypeloader.cpp
index 9df502f778..fc48957bcb 100644
--- a/src/qml/qml/qqmltypeloader.cpp
+++ b/src/qml/qml/qqmltypeloader.cpp
@@ -1891,8 +1891,6 @@ bool QQmlTypeLoader::fileExists(const QString &path, const QString &file)
     if (!fileSet)
         return false;
 
-    QString absoluteFilePath;
-
     bool *value = fileSet->object(file);
     if (value) {
         return *value;
diff --git a/src/quick/designer/qquickdesignersupportitems.cpp b/src/quick/designer/qquickdesignersupportitems.cpp
index 1c338fa79d..ed5fdf3a4a 100644
--- a/src/quick/designer/qquickdesignersupportitems.cpp
+++ b/src/quick/designer/qquickdesignersupportitems.cpp
@@ -192,19 +192,19 @@ static bool isCrashingType(const QQmlType &type)
 {
     QString name = type.qmlTypeName();
 
-    if (type.qmlTypeName() == QLatin1String("QtMultimedia/MediaPlayer"))
+    if (name == QLatin1String("QtMultimedia/MediaPlayer"))
         return true;
 
-    if (type.qmlTypeName() == QLatin1String("QtMultimedia/Audio"))
+    if (name == QLatin1String("QtMultimedia/Audio"))
         return true;
 
-    if (type.qmlTypeName() == QLatin1String("QtQuick.Controls/MenuItem"))
+    if (name == QLatin1String("QtQuick.Controls/MenuItem"))
         return true;
 
-    if (type.qmlTypeName() == QLatin1String("QtQuick.Controls/Menu"))
+    if (name == QLatin1String("QtQuick.Controls/Menu"))
         return true;
 
-    if (type.qmlTypeName() == QLatin1String("QtQuick/Timer"))
+    if (name == QLatin1String("QtQuick/Timer"))
         return true;
 
     return false;