diff options
author | Friedemann Kleint <Friedemann.Kleint@nokia.com> | 2012-03-29 11:16:37 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-03-30 11:18:26 +0200 |
commit | 5534768481f478e93b8b3bd0f7fb0327da5af221 (patch) | |
tree | 32abb7f1a0077e69f3862e26ebb941eb0aa428e1 /src | |
parent | 831c2bf6385177183b70052ec00a1666dbc61da6 (diff) |
Fix warnings in qtdeclarative.
- QString from ASCII conversions
- Unused variables
- Pointer mismatches
Change-Id: I5f76dce4f2ba481c2c2bce8681cf8107bd629566
Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
Diffstat (limited to 'src')
-rw-r--r-- | src/qml/qml/qqmldirparser.cpp | 12 | ||||
-rw-r--r-- | src/qml/qml/v8/qv8contextwrapper.cpp | 2 | ||||
-rw-r--r-- | src/quick/items/qquicktext.cpp | 6 | ||||
-rw-r--r-- | src/quick/items/qquickwindowmanager.cpp | 2 |
4 files changed, 9 insertions, 13 deletions
diff --git a/src/qml/qml/qqmldirparser.cpp b/src/qml/qml/qqmldirparser.cpp index df5f7f8ee9..82289311c9 100644 --- a/src/qml/qml/qqmldirparser.cpp +++ b/src/qml/qml/qqmldirparser.cpp @@ -297,16 +297,16 @@ QList<QQmlDirParser::TypeInfo> QQmlDirParser::typeInfos() const QDebug &operator<< (QDebug &debug, const QQmlDirParser::Component &component) { - return debug << qPrintable(QString("{%1 %2.%3}").arg(component.typeName) - .arg(component.majorVersion) - .arg(component.minorVersion)); + const QString output = QString::fromLatin1("{%1 %2.%3}"). + arg(component.typeName).arg(component.majorVersion).arg(component.minorVersion); + return debug << qPrintable(output); } QDebug &operator<< (QDebug &debug, const QQmlDirParser::Script &script) { - return debug << qPrintable(QString("{%1 %2.%3}").arg(script.nameSpace) - .arg(script.majorVersion) - .arg(script.minorVersion)); + const QString output = QString::fromLatin1("{%1 %2.%3}"). + arg(script.nameSpace).arg(script.majorVersion).arg(script.minorVersion); + return debug << qPrintable(output); } QT_END_NAMESPACE diff --git a/src/qml/qml/v8/qv8contextwrapper.cpp b/src/qml/qml/v8/qv8contextwrapper.cpp index 39392b8984..8a98727205 100644 --- a/src/qml/qml/v8/qv8contextwrapper.cpp +++ b/src/qml/qml/v8/qv8contextwrapper.cpp @@ -327,7 +327,7 @@ v8::Handle<v8::Value> QV8ContextWrapper::Getter(v8::Local<v8::String> property, const QVariant &value = cp->propertyValues.at(propertyIdx); if (value.userType() == qMetaTypeId<QList<QObject*> >()) { - QQmlListProperty<QObject> prop(context->asQQmlContext(), (void*)propertyIdx, + QQmlListProperty<QObject> prop(context->asQQmlContext(), (void*) qintptr(propertyIdx), 0, QQmlContextPrivate::context_count, QQmlContextPrivate::context_at); diff --git a/src/quick/items/qquicktext.cpp b/src/quick/items/qquicktext.cpp index e1a28a466a..864dde395e 100644 --- a/src/quick/items/qquicktext.cpp +++ b/src/quick/items/qquicktext.cpp @@ -748,7 +748,6 @@ QRectF QQuickTextPrivate::setupTextLayout(qreal *const naturalWidth) QTextLine line; int visibleCount = 0; bool elide; - bool widthChanged; qreal height = 0; QString elideText; bool once = true; @@ -776,7 +775,6 @@ QRectF QQuickTextPrivate::setupTextLayout(qreal *const naturalWidth) bool truncateHeight = false; truncated = false; elide = false; - widthChanged = false; int characterCount = 0; int unwrappedLineCount = 1; int maxLineCount = maximumLineCount(); @@ -911,10 +909,8 @@ QRectF QQuickTextPrivate::setupTextLayout(qreal *const naturalWidth) const qreal oldWidth = lineWidth; lineWidth = q->widthValid() && q->width() > 0 ? q->width() : FLT_MAX; - if (lineWidth != oldWidth && (singlelineElide || multilineElide || canWrap || horizontalFit)) { - widthChanged = true; + if (lineWidth != oldWidth && (singlelineElide || multilineElide || canWrap || horizontalFit)) continue; - } } // If the next needs to be elided and there's an abbreviated string available diff --git a/src/quick/items/qquickwindowmanager.cpp b/src/quick/items/qquickwindowmanager.cpp index bac5cc7582..d075d3b64b 100644 --- a/src/quick/items/qquickwindowmanager.cpp +++ b/src/quick/items/qquickwindowmanager.cpp @@ -1221,7 +1221,7 @@ void QQuickTrivialWindowManager::renderCanvas(QQuickCanvas *canvas) maybeUpdate(canvas); } -void QQuickTrivialWindowManager::exposureChanged(QQuickCanvas *canvas) +void QQuickTrivialWindowManager::exposureChanged(QQuickCanvas *) { } |