diff options
author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-10-22 12:33:52 +0200 |
---|---|---|
committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2020-10-22 16:00:22 +0200 |
commit | 1270a88cb3fa446ce2201d4204ff05b8b969f2ea (patch) | |
tree | aa14ad6fc6cb3eb2740a7803c598a8297ac36be1 /tests/auto/qml/animation | |
parent | 328759cdeb7b45eba5569b54ded35e38152ee0d0 (diff) |
Fix compile warnings from tests
Use streaming operators for debug/warnings to avoid qsizehint/int
conflicts.
Don't ignore return values from [[no_discard]] functions.
Don't copy elements from containers that return references.
Remove unused variables.
Change-Id: I7a0bef94a5e828bd8facee0c625ec48c3d1f1bdb
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'tests/auto/qml/animation')
-rw-r--r-- | tests/auto/qml/animation/qsequentialanimationgroupjob/tst_qsequentialanimationgroupjob.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/tests/auto/qml/animation/qsequentialanimationgroupjob/tst_qsequentialanimationgroupjob.cpp b/tests/auto/qml/animation/qsequentialanimationgroupjob/tst_qsequentialanimationgroupjob.cpp index add19273d9..4718eb33b4 100644 --- a/tests/auto/qml/animation/qsequentialanimationgroupjob/tst_qsequentialanimationgroupjob.cpp +++ b/tests/auto/qml/animation/qsequentialanimationgroupjob/tst_qsequentialanimationgroupjob.cpp @@ -610,9 +610,8 @@ static bool compareStates(const StateChangeListener& spy, const StateList &expec } } - qDebug("\n" - "expected (count == %d): %s\n" - "actual (count == %d): %s\n", expectedStates.count(), qPrintable(e), spy.count(), qPrintable(a)); + qDebug().noquote() << "\nexpected (count == " << expectedStates.count() << "): " << e + << "\nactual (count == " << spy.count() << "): " << a << "\n"; } return equals; } |