aboutsummaryrefslogtreecommitdiffstats
path: root/tests/auto/qml/ecmascripttests
diff options
context:
space:
mode:
authorLars Knoll <lars.knoll@qt.io>2018-09-05 14:56:24 +0200
committerLars Knoll <lars.knoll@qt.io>2018-09-07 10:31:53 +0000
commit15bdbd89639c29f88db1798de66066a4a95759c0 (patch)
treefd06324c900c9eb662f3f64cb1d1f1d45186ecb3 /tests/auto/qml/ecmascripttests
parent06e3ff28bb52500ae45f0c174ff8cd746593855c (diff)
Fix exception handling while destructuring
When an exception happens during destructuring, IteratorClose needs to be called, unless the exception happened inside the IteratorNext call (in that case the iterator is assumed to be invalid and we shouldn't call close on it). Implement this, by ensuring that we set the done return variable of IteratorNext to true whenever IteratorNext throws an exception. IteratorClose will check the done state and not do anything in that case. Change-Id: I73a27f855f2c4d3134b8cc8980e64bf797d03886 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Diffstat (limited to 'tests/auto/qml/ecmascripttests')
-rw-r--r--tests/auto/qml/ecmascripttests/TestExpectations12
1 files changed, 0 insertions, 12 deletions
diff --git a/tests/auto/qml/ecmascripttests/TestExpectations b/tests/auto/qml/ecmascripttests/TestExpectations
index 3a5ec521d3..e88bf14bf8 100644
--- a/tests/auto/qml/ecmascripttests/TestExpectations
+++ b/tests/auto/qml/ecmascripttests/TestExpectations
@@ -639,14 +639,9 @@ language/expressions/assignment/S11.13.1_A7_T3.js fails
language/expressions/assignment/destructuring/iterator-destructuring-property-reference-target-evaluation-order.js fails
language/expressions/assignment/destructuring/keyed-destructuring-property-reference-target-evaluation-order.js fails
language/expressions/assignment/dstr-array-elem-iter-rtrn-close-err.js fails
-language/expressions/assignment/dstr-array-elem-iter-rtrn-close-null.js fails
-language/expressions/assignment/dstr-array-elem-iter-rtrn-close.js fails
language/expressions/assignment/dstr-array-elem-iter-thrw-close-err.js fails
language/expressions/assignment/dstr-array-elem-iter-thrw-close.js fails
language/expressions/assignment/dstr-array-elem-put-let.js fails
-language/expressions/assignment/dstr-array-elem-trlg-iter-list-rtrn-close-err.js fails
-language/expressions/assignment/dstr-array-elem-trlg-iter-list-rtrn-close-null.js fails
-language/expressions/assignment/dstr-array-elem-trlg-iter-list-rtrn-close.js fails
language/expressions/assignment/dstr-array-elem-trlg-iter-list-thrw-close-err.js fails
language/expressions/assignment/dstr-array-elem-trlg-iter-list-thrw-close.js fails
language/expressions/assignment/dstr-array-elem-trlg-iter-rest-rtrn-close-err.js fails
@@ -1002,14 +997,9 @@ language/statements/for-in/head-lhs-let.js sloppyFails
language/statements/for-in/head-var-bound-names-let.js sloppyFails
language/statements/for-in/identifier-let-allowed-as-lefthandside-expression-not-strict.js sloppyFails
language/statements/for-of/dstr-array-elem-iter-rtrn-close-err.js fails
-language/statements/for-of/dstr-array-elem-iter-rtrn-close-null.js fails
-language/statements/for-of/dstr-array-elem-iter-rtrn-close.js fails
language/statements/for-of/dstr-array-elem-iter-thrw-close-err.js fails
language/statements/for-of/dstr-array-elem-iter-thrw-close.js fails
language/statements/for-of/dstr-array-elem-put-let.js fails
-language/statements/for-of/dstr-array-elem-trlg-iter-list-rtrn-close-err.js fails
-language/statements/for-of/dstr-array-elem-trlg-iter-list-rtrn-close-null.js fails
-language/statements/for-of/dstr-array-elem-trlg-iter-list-rtrn-close.js fails
language/statements/for-of/dstr-array-elem-trlg-iter-list-thrw-close-err.js fails
language/statements/for-of/dstr-array-elem-trlg-iter-list-thrw-close.js fails
language/statements/for-of/dstr-array-elem-trlg-iter-rest-rtrn-close-err.js fails
@@ -1029,9 +1019,7 @@ language/statements/for-of/dstr-obj-empty-undef.js fails
language/statements/for-of/dstr-obj-id-put-let.js fails
language/statements/for-of/dstr-obj-prop-put-let.js fails
language/statements/for-of/head-var-bound-names-let.js sloppyFails
-language/statements/for-of/iterator-next-error.js fails
language/statements/for-of/iterator-next-reference.js fails
-language/statements/for-of/iterator-next-result-value-attr-error.js fails
language/statements/for-of/yield-star-from-catch.js fails
language/statements/for-of/yield-star-from-finally.js fails
language/statements/for-of/yield-star-from-try.js fails