aboutsummaryrefslogtreecommitdiffstats
path: root/tests/auto/qml/qjsengine
diff options
context:
space:
mode:
authorMitch Curtis <mitch.curtis@digia.com>2013-09-18 15:53:38 +0200
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-09-18 16:04:40 +0200
commit52cc10589a8b3df2876dc7d3855e67bc91ee0e82 (patch)
treecd245f1fdab279a7e90daa8b99aebe3a78cf9e34 /tests/auto/qml/qjsengine
parent4241a5583623be758df3884c133acff2e11cd33f (diff)
Temporarily disable tst_QJSEngine tests to allow qtbase dev integration
Temporarily disables: - tst_QJSEngine::dateConversionJSQt() - tst_QJSEngine::dateConversionQtJS() so that https://codereview.qt-project.org/#change,65560 can merge. Change-Id: I415daf1c5bd137e1905773f88fe5ebaaab1e0a06 Reviewed-by: John Layt <jlayt@kde.org>
Diffstat (limited to 'tests/auto/qml/qjsengine')
-rw-r--r--tests/auto/qml/qjsengine/tst_qjsengine.cpp52
1 files changed, 28 insertions, 24 deletions
diff --git a/tests/auto/qml/qjsengine/tst_qjsengine.cpp b/tests/auto/qml/qjsengine/tst_qjsengine.cpp
index 4ae187c829..ecd1439177 100644
--- a/tests/auto/qml/qjsengine/tst_qjsengine.cpp
+++ b/tests/auto/qml/qjsengine/tst_qjsengine.cpp
@@ -2609,34 +2609,38 @@ void tst_QJSEngine::dateRoundtripQtJSQt()
void tst_QJSEngine::dateConversionJSQt()
{
-#ifdef Q_OS_WIN
- QSKIP("This test fails on Windows due to a bug in QDateTime.");
-#endif
- uint secs = QDateTime(QDate(2009, 1, 1)).toUTC().toTime_t();
- QJSEngine eng;
- for (int i = 0; i < 8000; ++i) {
- QJSValue jsDate = eng.evaluate(QString::fromLatin1("new Date(%0)").arg(secs * 1000.0));
- QDateTime qtDate = jsDate.toDateTime();
- QString qtUTCDateStr = qtDate.toUTC().toString(Qt::ISODate);
- QString jsUTCDateStr = jsDate.property("toISOString").callWithInstance(jsDate).toString();
- if (qtUTCDateStr != jsUTCDateStr)
- QFAIL(qPrintable(jsDate.toString()));
- secs += 2*60*60;
- }
+ // Disable temporarily so that https://codereview.qt-project.org/#change,65560 can merge.
+//#ifdef Q_OS_WIN
+// QSKIP("This test fails on Windows due to a bug in QDateTime.");
+//#endif
+// uint secs = QDateTime(QDate(2009, 1, 1)).toUTC().toTime_t();
+// QJSEngine eng;
+// for (int i = 0; i < 8000; ++i) {
+// QJSValue jsDate = eng.evaluate(QString::fromLatin1("new Date(%0)").arg(secs * 1000.0));
+// QDateTime qtDate = jsDate.toDateTime();
+// QString qtUTCDateStr = qtDate.toUTC().toString(Qt::ISODate);
+// QString jsUTCDateStr = jsDate.property("toISOString").callWithInstance(jsDate).toString();
+// jsUTCDateStr.remove(jsUTCDateStr.length() - 5, 4); // get rid of milliseconds (".000")
+// if (qtUTCDateStr != jsUTCDateStr)
+// QFAIL(qPrintable(jsDate.toString()));
+// secs += 2*60*60;
+// }
}
void tst_QJSEngine::dateConversionQtJS()
{
- QDateTime qtDate = QDateTime(QDate(2009, 1, 1));
- QJSEngine eng;
- for (int i = 0; i < 8000; ++i) {
- QJSValue jsDate = eng.toScriptValue(qtDate);
- QString jsUTCDateStr = jsDate.property("toISOString").callWithInstance(jsDate).toString();
- QString qtUTCDateStr = qtDate.toUTC().toString(Qt::ISODate);
- if (jsUTCDateStr != qtUTCDateStr)
- QFAIL(qPrintable(qtDate.toString()));
- qtDate = qtDate.addSecs(2*60*60);
- }
+// Disable temporarily so that https://codereview.qt-project.org/#change,65560 can merge.
+// QDateTime qtDate = QDateTime(QDate(2009, 1, 1));
+// QJSEngine eng;
+// for (int i = 0; i < 8000; ++i) {
+// QJSValue jsDate = eng.toScriptValue(qtDate);
+// QString jsUTCDateStr = jsDate.property("toISOString").callWithInstance(jsDate).toString();
+// QString qtUTCDateStr = qtDate.toUTC().toString(Qt::ISODate);
+// jsUTCDateStr.remove(jsUTCDateStr.length() - 5, 4); // get rid of milliseconds (".000")
+// if (jsUTCDateStr != qtUTCDateStr)
+// QFAIL(qPrintable(qtDate.toString()));
+// qtDate = qtDate.addSecs(2*60*60);
+// }
}
void tst_QJSEngine::functionPrototypeExtensions()