V4 Date.ParseString(): fix UTC-ness of date-only formats

ECMA-262 stipulates that date-only formats should be treated as UTC,
while date-times are handled as standard time, if no time zone is
explicitly given.  Tidied up the parser a bit in the process and
documented what the spec says.  Fixed some broken test-cases.

Handling of date-times without zone as local time is a correction
since edition 5.1 of ECMA-262 (which said to handle it as UTC):
http://www.ecma-international.org/ecma-262/7.0/index.html#sec-corrections-and-clarifications-in-ecmascript-2015-with-possible-compatibility-impact
We were previously handling both dates and date-times as local time,
violating the old spec for both and the revised spec for dates.

Task-number: QTBUG-56787
Change-Id: I557789d855b910ca6a859fca396af1a0205c9417
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>

7 files changed, 99 insertions, 90 deletions

diff --git a/tests/auto/qml/qqmlecmascript/data/assignDate.1.qml b/tests/auto/qml/qqmlecmascript/data/assignDate.1.qml
index efca6cdb80..8912d2a314 100644
--- a/tests/auto/qml/qqmlecmascript/data/assignDate.1.qml
+++ b/tests/auto/qml/qqmlecmascript/data/assignDate.1.qml
@@ -11,25 +11,26 @@ MyTypeObject {
         dateTimeProperty = dateTimeVar
         dateTimeProperty2 = dateTimeVar2
 
-        // Commented properties do not currently test true:
-        boolProperty = //(dateProperty.getTime() == dateVar.getTime()) &&
+        boolProperty = (dateProperty.getTime() == dateVar.getTime()) &&
                        (dateProperty.getFullYear() == 2009) &&
                        (dateProperty.getMonth() == 5-1) &&
-                       //(dateProperty.getDate() == 12) &&
-                       (dateProperty.getHours() == 0) &&
+                       (dateProperty.getUTCDate() == 12) &&
+                       (dateProperty.getUTCHours() == 0) &&
+                       (dateProperty.getUTCMinutes() == 0) &&
+                       (dateProperty.getUTCSeconds() == 0) &&
                        (dateTimeProperty.getTime() == dateTimeVar.getTime()) &&
                        (dateTimeProperty.getFullYear() == 2009) &&
                        (dateTimeProperty.getMonth() == 5-1) &&
-                       //(dateTimeProperty.getDate() == 12) &&
-                       //(dateTimeProperty.getHours() == 0) &&
-                       (dateTimeProperty.getMinutes() == 0) &&
-                       (dateTimeProperty.getSeconds() == 1) &&
+                       (dateTimeProperty.getUTCDate() == 12) &&
+                       (dateTimeProperty.getUTCHours() == 0) &&
+                       (dateTimeProperty.getUTCMinutes() == 0) &&
+                       (dateTimeProperty.getUTCSeconds() == 1) &&
                        (dateTimeProperty2.getTime() == dateTimeVar2.getTime()) &&
                        (dateTimeProperty2.getFullYear() == 2009) &&
                        (dateTimeProperty2.getMonth() == 5-1) &&
-                       //(dateTimeProperty2.getDate() == 12) &&
-                       //(dateTimeProperty2.getHours() == 23) &&
-                       (dateTimeProperty2.getMinutes() == 59) &&
-                       (dateTimeProperty2.getSeconds() == 59)
+                       (dateTimeProperty2.getUTCDate() == 12) &&
+                       (dateTimeProperty2.getUTCHours() == 23) &&
+                       (dateTimeProperty2.getUTCMinutes() == 59) &&
+                       (dateTimeProperty2.getUTCSeconds() == 59)
     }
 }
diff --git a/tests/auto/qml/qqmlecmascript/data/assignDate.2.qml b/tests/auto/qml/qqmlecmascript/data/assignDate.2.qml
index 71dd188f05..f8c1f6eb8f 100644
--- a/tests/auto/qml/qqmlecmascript/data/assignDate.2.qml
+++ b/tests/auto/qml/qqmlecmascript/data/assignDate.2.qml
@@ -12,24 +12,25 @@ MyTypeObject {
         var dateTimeVar = new Date("2009-05-12T00:00:01")
         var dateTimeVar2 = new Date("2009-05-12T23:59:59")
 
-        // Commented properties do not currently test true:
-        boolProperty = //(dateProperty.getTime() == dateVar.getTime()) &&
+        boolProperty = (dateProperty.getTime() == dateVar.getTime()) &&
                        (dateProperty.getFullYear() == 2009) &&
                        (dateProperty.getMonth() == 5-1) &&
-                       //(dateProperty.getDate() == 12) &&
-                       (dateProperty.getHours() == 0) &&
+                       (dateProperty.getUTCDate() == 12) &&
+                       (dateProperty.getUTCHours() == 0) &&
+                       (dateProperty.getUTCMinutes() == 0) &&
+                       (dateProperty.getUTCSeconds() == 0) &&
                        (dateTimeProperty.getTime() == dateTimeVar.getTime()) &&
                        (dateTimeProperty.getFullYear() == 2009) &&
                        (dateTimeProperty.getMonth() == 5-1) &&
-                       //(dateTimeProperty.getDate() == 12) &&
-                       //(dateTimeProperty.getHours() == 0) &&
+                       (dateTimeProperty.getDate() == 12) &&
+                       (dateTimeProperty.getHours() == 0) &&
                        (dateTimeProperty.getMinutes() == 0) &&
                        (dateTimeProperty.getSeconds() == 1) &&
                        (dateTimeProperty2.getTime() == dateTimeVar2.getTime()) &&
                        (dateTimeProperty2.getFullYear() == 2009) &&
                        (dateTimeProperty2.getMonth() == 5-1) &&
-                       //(dateTimeProperty2.getDate() == 12) &&
-                       //(dateTimeProperty2.getHours() == 23) &&
+                       (dateTimeProperty2.getDate() == 12) &&
+                       (dateTimeProperty2.getHours() == 23) &&
                        (dateTimeProperty2.getMinutes() == 59) &&
                        (dateTimeProperty2.getSeconds() == 59)
     }
diff --git a/tests/auto/qml/qqmlecmascript/data/assignDate.3.qml b/tests/auto/qml/qqmlecmascript/data/assignDate.3.qml
index 2cf740645c..e960eef193 100644
--- a/tests/auto/qml/qqmlecmascript/data/assignDate.3.qml
+++ b/tests/auto/qml/qqmlecmascript/data/assignDate.3.qml
@@ -2,35 +2,36 @@ import Qt.test 1.0
 import QtQuick 2.0
 
 MyTypeObject {
-    dateProperty: if (1) "2009-05-12Z"
+    dateProperty: if (1) "2009-05-12"
     dateTimeProperty: if (1) "2009-05-12T00:00:01Z"
     dateTimeProperty2: if (1) "2009-05-12T23:59:59Z"
 
     boolProperty: false
     Component.onCompleted: {
-        var dateVar = new Date("2009-05-12Z")
+        var dateVar = new Date("2009-05-12")
         var dateTimeVar = new Date("2009-05-12T00:00:01Z")
         var dateTimeVar2 = new Date("2009-05-12T23:59:59Z")
 
-        // Commented properties do not currently test true:
-        boolProperty = //(dateProperty.getTime() == dateVar.getTime()) &&
+        boolProperty = (dateProperty.getTime() == dateVar.getTime()) &&
                        (dateProperty.getFullYear() == 2009) &&
                        (dateProperty.getMonth() == 5-1) &&
-                       //(dateProperty.getDate() == 12) &&
-                       (dateProperty.getHours() == 0) &&
+                       (dateProperty.getUTCDate() == 12) &&
+                       (dateProperty.getUTCHours() == 0) &&
+                       (dateProperty.getUTCMinutes() == 0) &&
+                       (dateProperty.getUTCSeconds() == 0) &&
                        (dateTimeProperty.getTime() == dateTimeVar.getTime()) &&
                        (dateTimeProperty.getFullYear() == 2009) &&
                        (dateTimeProperty.getMonth() == 5-1) &&
-                       //(dateTimeProperty.getDate() == 12) &&
-                       //(dateTimeProperty.getHours() == 0) &&
-                       (dateTimeProperty.getMinutes() == 0) &&
-                       (dateTimeProperty.getSeconds() == 1) &&
+                       (dateTimeProperty.getUTCDate() == 12) &&
+                       (dateTimeProperty.getUTCHours() == 0) &&
+                       (dateTimeProperty.getUTCMinutes() == 0) &&
+                       (dateTimeProperty.getUTCSeconds() == 1) &&
                        (dateTimeProperty2.getTime() == dateTimeVar2.getTime()) &&
                        (dateTimeProperty2.getFullYear() == 2009) &&
                        (dateTimeProperty2.getMonth() == 5-1) &&
-                       //(dateTimeProperty2.getDate() == 12) &&
-                       //(dateTimeProperty2.getHours() == 23) &&
-                       (dateTimeProperty2.getMinutes() == 59) &&
-                       (dateTimeProperty2.getSeconds() == 59)
+                       (dateTimeProperty2.getUTCDate() == 12) &&
+                       (dateTimeProperty2.getUTCHours() == 23) &&
+                       (dateTimeProperty2.getUTCMinutes() == 59) &&
+                       (dateTimeProperty2.getUTCSeconds() == 59)
     }
 }
diff --git a/tests/auto/qml/qqmlecmascript/data/assignDate.4.qml b/tests/auto/qml/qqmlecmascript/data/assignDate.4.qml
index 9b4975c833..6dd29afbc9 100644
--- a/tests/auto/qml/qqmlecmascript/data/assignDate.4.qml
+++ b/tests/auto/qml/qqmlecmascript/data/assignDate.4.qml
@@ -2,35 +2,36 @@ import Qt.test 1.0
 import QtQuick 2.0
 
 MyTypeObject {
-    dateProperty: if (1) new Date("2009-05-12Z")
+    dateProperty: if (1) new Date("2009-05-12")
     dateTimeProperty: if (1) new Date("2009-05-12T00:00:01Z")
     dateTimeProperty2: if (1) new Date("2009-05-12T23:59:59Z")
 
     boolProperty: false
     Component.onCompleted: {
-        var dateVar = new Date("2009-05-12Z")
+        var dateVar = new Date("2009-05-12")
         var dateTimeVar = new Date("2009-05-12T00:00:01Z")
         var dateTimeVar2 = new Date("2009-05-12T23:59:59Z")
 
-        // Commented properties do not currently test true:
-        boolProperty = //(dateProperty.getTime() == dateVar.getTime()) &&
+        boolProperty = (dateProperty.getTime() == dateVar.getTime()) &&
                        (dateProperty.getFullYear() == 2009) &&
                        (dateProperty.getMonth() == 5-1) &&
-                       //(dateProperty.getDate() == 12) &&
-                       (dateProperty.getHours() == 0) &&
+                       (dateProperty.getUTCDate() == 12) &&
+                       (dateProperty.getUTCHours() == 0) &&
+                       (dateProperty.getUTCMinutes() == 0) &&
+                       (dateProperty.getUTCSeconds() == 0) &&
                        (dateTimeProperty.getTime() == dateTimeVar.getTime()) &&
                        (dateTimeProperty.getFullYear() == 2009) &&
                        (dateTimeProperty.getMonth() == 5-1) &&
-                       //(dateTimeProperty.getDate() == 12) &&
-                       //(dateTimeProperty.getHours() == 0) &&
-                       (dateTimeProperty.getMinutes() == 0) &&
-                       (dateTimeProperty.getSeconds() == 1) &&
+                       (dateTimeProperty.getUTCDate() == 12) &&
+                       (dateTimeProperty.getUTCHours() == 0) &&
+                       (dateTimeProperty.getUTCMinutes() == 0) &&
+                       (dateTimeProperty.getUTCSeconds() == 1) &&
                        (dateTimeProperty2.getTime() == dateTimeVar2.getTime()) &&
                        (dateTimeProperty2.getFullYear() == 2009) &&
                        (dateTimeProperty2.getMonth() == 5-1) &&
-                       //(dateTimeProperty2.getDate() == 12) &&
-                       //(dateTimeProperty2.getHours() == 23) &&
-                       (dateTimeProperty2.getMinutes() == 59) &&
-                       (dateTimeProperty2.getSeconds() == 59)
+                       (dateTimeProperty2.getUTCDate() == 12) &&
+                       (dateTimeProperty2.getUTCHours() == 23) &&
+                       (dateTimeProperty2.getUTCMinutes() == 59) &&
+                       (dateTimeProperty2.getUTCSeconds() == 59)
     }
 }
diff --git a/tests/auto/qml/qqmlecmascript/data/assignDate.5.qml b/tests/auto/qml/qqmlecmascript/data/assignDate.5.qml
index 2cf740645c..cfadaafc54 100644
--- a/tests/auto/qml/qqmlecmascript/data/assignDate.5.qml
+++ b/tests/auto/qml/qqmlecmascript/data/assignDate.5.qml
@@ -2,35 +2,36 @@ import Qt.test 1.0
 import QtQuick 2.0
 
 MyTypeObject {
-    dateProperty: if (1) "2009-05-12Z"
-    dateTimeProperty: if (1) "2009-05-12T00:00:01Z"
-    dateTimeProperty2: if (1) "2009-05-12T23:59:59Z"
+    dateProperty: if (1) "2009-05-12"
+    dateTimeProperty: if (1) "2009-05-12T00:00:01+02:00"
+    dateTimeProperty2: if (1) "2009-05-12T23:59:59+02:00"
 
     boolProperty: false
     Component.onCompleted: {
-        var dateVar = new Date("2009-05-12Z")
-        var dateTimeVar = new Date("2009-05-12T00:00:01Z")
-        var dateTimeVar2 = new Date("2009-05-12T23:59:59Z")
+        var dateVar = new Date("2009-05-12")
+        var dateTimeVar = new Date("2009-05-12T00:00:01+02:00")
+        var dateTimeVar2 = new Date("2009-05-12T23:59:59+02:00")
 
-        // Commented properties do not currently test true:
-        boolProperty = //(dateProperty.getTime() == dateVar.getTime()) &&
+        boolProperty = (dateProperty.getTime() == dateVar.getTime()) &&
                        (dateProperty.getFullYear() == 2009) &&
                        (dateProperty.getMonth() == 5-1) &&
-                       //(dateProperty.getDate() == 12) &&
-                       (dateProperty.getHours() == 0) &&
+                       (dateProperty.getUTCDate() == 12) &&
+                       (dateProperty.getUTCHours() == 0) &&
+                       (dateProperty.getUTCMinutes() == 0) &&
+                       (dateProperty.getUTCSeconds() == 0) &&
                        (dateTimeProperty.getTime() == dateTimeVar.getTime()) &&
                        (dateTimeProperty.getFullYear() == 2009) &&
                        (dateTimeProperty.getMonth() == 5-1) &&
-                       //(dateTimeProperty.getDate() == 12) &&
-                       //(dateTimeProperty.getHours() == 0) &&
-                       (dateTimeProperty.getMinutes() == 0) &&
-                       (dateTimeProperty.getSeconds() == 1) &&
+                       (dateTimeProperty.getUTCDate() == 11) &&
+                       (dateTimeProperty.getUTCHours() == 22) &&
+                       (dateTimeProperty.getUTCMinutes() == 0) &&
+                       (dateTimeProperty.getUTCSeconds() == 1) &&
                        (dateTimeProperty2.getTime() == dateTimeVar2.getTime()) &&
                        (dateTimeProperty2.getFullYear() == 2009) &&
                        (dateTimeProperty2.getMonth() == 5-1) &&
-                       //(dateTimeProperty2.getDate() == 12) &&
-                       //(dateTimeProperty2.getHours() == 23) &&
-                       (dateTimeProperty2.getMinutes() == 59) &&
-                       (dateTimeProperty2.getSeconds() == 59)
+                       (dateTimeProperty2.getUTCDate() == 12) &&
+                       (dateTimeProperty2.getUTCHours() == 21) &&
+                       (dateTimeProperty2.getUTCMinutes() == 59) &&
+                       (dateTimeProperty2.getUTCSeconds() == 59)
     }
 }
diff --git a/tests/auto/qml/qqmlecmascript/data/assignDate.6.qml b/tests/auto/qml/qqmlecmascript/data/assignDate.6.qml
index 73e26db0c8..97cd0d1e60 100644
--- a/tests/auto/qml/qqmlecmascript/data/assignDate.6.qml
+++ b/tests/auto/qml/qqmlecmascript/data/assignDate.6.qml
@@ -3,34 +3,35 @@ import QtQuick 2.0
 
 MyTypeObject {
     dateProperty: if (1) new Date("2009-05-12")
-    dateTimeProperty: if (1) new Date("2009-05-12T02:00:01+02:00")
-    dateTimeProperty2: if (1) new Date("2009-05-13T01:59:59+02:00")
+    dateTimeProperty: if (1) new Date("2009-05-12T00:00:01+02:00")
+    dateTimeProperty2: if (1) new Date("2009-05-12T23:59:59+02:00")
 
     boolProperty: false
     Component.onCompleted: {
         var dateVar = new Date("2009-05-12")
-        var dateTimeVar = new Date("2009-05-12T02:00:01+02:00")
-        var dateTimeVar2 = new Date("2009-05-13T01:59:59+02:00")
+        var dateTimeVar = new Date("2009-05-12T00:00:01+02:00")
+        var dateTimeVar2 = new Date("2009-05-12T23:59:59+02:00")
 
-        // Commented properties do not currently test true:
-        boolProperty = //(dateProperty.getTime() == dateVar.getTime()) &&
+        boolProperty = (dateProperty.getTime() == dateVar.getTime()) &&
                        (dateProperty.getFullYear() == 2009) &&
                        (dateProperty.getMonth() == 5-1) &&
-                       //(dateProperty.getDate() == 12) &&
-                       (dateProperty.getHours() == 0) &&
+                       (dateProperty.getUTCDate() == 12) &&
+                       (dateProperty.getUTCHours() == 0) &&
+                       (dateProperty.getUTCMinutes() == 0) &&
+                       (dateProperty.getUTCSeconds() == 0) &&
                        (dateTimeProperty.getTime() == dateTimeVar.getTime()) &&
                        (dateTimeProperty.getFullYear() == 2009) &&
                        (dateTimeProperty.getMonth() == 5-1) &&
-                       //(dateTimeProperty.getDate() == 12) &&
-                       //(dateTimeProperty.getHours() == 0) &&
-                       (dateTimeProperty.getMinutes() == 0) &&
-                       (dateTimeProperty.getSeconds() == 1) &&
+                       (dateTimeProperty.getUTCDate() == 11) &&
+                       (dateTimeProperty.getUTCHours() == 22) &&
+                       (dateTimeProperty.getUTCMinutes() == 0) &&
+                       (dateTimeProperty.getUTCSeconds() == 1) &&
                        (dateTimeProperty2.getTime() == dateTimeVar2.getTime()) &&
                        (dateTimeProperty2.getFullYear() == 2009) &&
                        (dateTimeProperty2.getMonth() == 5-1) &&
-                       //(dateTimeProperty2.getDate() == 12) &&
-                       //(dateTimeProperty2.getHours() == 23) &&
-                       (dateTimeProperty2.getMinutes() == 59) &&
-                       (dateTimeProperty2.getSeconds() == 59)
+                       (dateTimeProperty2.getUTCDate() == 12) &&
+                       (dateTimeProperty2.getUTCHours() == 21) &&
+                       (dateTimeProperty2.getUTCMinutes() == 59) &&
+                       (dateTimeProperty2.getUTCSeconds() == 59)
     }
 }
diff --git a/tests/auto/qml/qqmlecmascript/data/assignDate.qml b/tests/auto/qml/qqmlecmascript/data/assignDate.qml
index 14fe20787b..73677e99f1 100644
--- a/tests/auto/qml/qqmlecmascript/data/assignDate.qml
+++ b/tests/auto/qml/qqmlecmascript/data/assignDate.qml
@@ -7,28 +7,31 @@ MyTypeObject {
         var dateTimeVar = new Date("2009-05-12T00:00:01")
         var dateTimeVar2 = new Date("2009-05-12T23:59:59")
 
+        // Date, with no zone specified, is implicitly UTC
         dateProperty = dateVar
+        // Date-time, with no zone, is implicitly local-time
         dateTimeProperty = dateTimeVar
         dateTimeProperty2 = dateTimeVar2
 
-        // Commented properties do not currently test true:
-        boolProperty = //(dateProperty.getTime() == dateVar.getTime()) &&
+        boolProperty = (dateProperty.getTime() == dateVar.getTime()) &&
                        (dateProperty.getFullYear() == 2009) &&
                        (dateProperty.getMonth() == 5-1) &&
-                       //(dateProperty.getDate() == 12) &&
-                       (dateProperty.getHours() == 0) &&
+                       (dateProperty.getDate() == 12) &&
+                       (dateProperty.getUTCHours() == 0) &&
+                       (dateProperty.getUTCMinutes() == 0) &&
+                       (dateProperty.getUTCSeconds() == 0) &&
                        (dateTimeProperty.getTime() == dateTimeVar.getTime()) &&
                        (dateTimeProperty.getFullYear() == 2009) &&
                        (dateTimeProperty.getMonth() == 5-1) &&
-                       //(dateTimeProperty.getDate() == 12) &&
-                       //(dateTimeProperty.getHours() == 0) &&
+                       (dateTimeProperty.getDate() == 12) &&
+                       (dateTimeProperty.getHours() == 0) &&
                        (dateTimeProperty.getMinutes() == 0) &&
                        (dateTimeProperty.getSeconds() == 1) &&
                        (dateTimeProperty2.getTime() == dateTimeVar2.getTime()) &&
                        (dateTimeProperty2.getFullYear() == 2009) &&
                        (dateTimeProperty2.getMonth() == 5-1) &&
-                       //(dateTimeProperty2.getDate() == 12) &&
-                       //(dateTimeProperty2.getHours() == 23) &&
+                       (dateTimeProperty2.getDate() == 12) &&
+                       (dateTimeProperty2.getHours() == 23) &&
                        (dateTimeProperty2.getMinutes() == 59) &&
                        (dateTimeProperty2.getSeconds() == 59)
     }