aboutsummaryrefslogtreecommitdiffstats
path: root/tests/auto/quick/qquickflickable
diff options
context:
space:
mode:
authorAndrew den Exter <andrew.den.exter@qinetic.com.au>2015-03-09 16:47:16 +1000
committerAndrew den Exter <andrew.den.exter@qinetic.com.au>2015-03-11 02:54:37 +0000
commit61cfaee2d0e4ae106a00950e917b712a52049d6f (patch)
treeb3d63cccd27862789e5b1df3496eafa21afc5ec7 /tests/auto/quick/qquickflickable
parentd517346086226493e63ffd1b92bae4fb86ed3024 (diff)
Fix flickable stealing gestures when height >= contentHeight.
Or width >= contentWidth. If newY is equal to both maxY and minY then the second assignment to rejectY can clobber the first. Changing the second assignment to an |= means rejectY is true if either is true. Secondly maxY became positive when height was greater than contentHeight instead of having a maximum of 0, which ensured rejectY evaluated to false in the case newY <= maxY and the mouse was stolen. Change-Id: I6416d0e23c3ef898887a7b3e3fcdc1dc12853548 Reviewed-by: Martin Jones <martin.jones@qinetic.com.au>
Diffstat (limited to 'tests/auto/quick/qquickflickable')
-rw-r--r--tests/auto/quick/qquickflickable/tst_qquickflickable.cpp34
1 files changed, 34 insertions, 0 deletions
diff --git a/tests/auto/quick/qquickflickable/tst_qquickflickable.cpp b/tests/auto/quick/qquickflickable/tst_qquickflickable.cpp
index 86baed4e51..5c96cc151e 100644
--- a/tests/auto/quick/qquickflickable/tst_qquickflickable.cpp
+++ b/tests/auto/quick/qquickflickable/tst_qquickflickable.cpp
@@ -1493,6 +1493,40 @@ void tst_qquickflickable::nestedStopAtBounds()
QTest::mouseRelease(&view, Qt::LeftButton, 0, position);
QTRY_VERIFY(!outer->isMoving());
+
+ axis = 200;
+ inner->setContentX(0);
+ inner->setContentY(0);
+ inner->setContentWidth(inner->width());
+ inner->setContentHeight(inner->height());
+
+ // Drag inner with equal size and contentSize
+ QTest::mousePress(&view, Qt::LeftButton, 0, position);
+ QTest::qWait(10);
+ axis += invert ? -threshold * 2 : threshold * 2;
+ QTest::mouseMove(&view, position);
+ axis += invert ? -threshold : threshold;
+ QTest::mouseMove(&view, position);
+ QCOMPARE(outer->isDragging(), true);
+ QCOMPARE(inner->isDragging(), false);
+ QTest::mouseRelease(&view, Qt::LeftButton, 0, position);
+
+ axis = 200;
+ inner->setContentX(0);
+ inner->setContentY(0);
+ inner->setContentWidth(inner->width() - 100);
+ inner->setContentHeight(inner->height() - 100);
+
+ // Drag inner with size greater than contentSize
+ QTest::mousePress(&view, Qt::LeftButton, 0, position);
+ QTest::qWait(10);
+ axis += invert ? -threshold * 2 : threshold * 2;
+ QTest::mouseMove(&view, position);
+ axis += invert ? -threshold : threshold;
+ QTest::mouseMove(&view, position);
+ QCOMPARE(outer->isDragging(), true);
+ QCOMPARE(inner->isDragging(), false);
+ QTest::mouseRelease(&view, Qt::LeftButton, 0, position);
}
void tst_qquickflickable::stopAtBounds_data()