diff options
author | Friedemann Kleint <Friedemann.Kleint@nokia.com> | 2012-06-13 12:10:18 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-06-20 17:22:31 +0200 |
commit | 58f3f50c43f021ebfe214062562498d02b6f2071 (patch) | |
tree | 17e02ef27ee8d0e76eaf25f800836121b4c9b85e /tests/auto/quick/qquickgridview | |
parent | e884e15615dc97c95704835756680b9c38be29ea (diff) |
Fix warnings in declarative tests.
- Unused variables and test data.
- () around operator &&.
- Conversion of false to 0-pointer where QVariant was intended.
- Missing enumeration value.
- Remove duplicated qqmlecmascript entry from qml.pro
(has an internal check for no-widgets).
Change-Id: Ie030167e22bce26e3988a4406c630fb460f61a3c
Reviewed-by: Jason McDonald <jason.mcdonald@nokia.com>
Diffstat (limited to 'tests/auto/quick/qquickgridview')
-rw-r--r-- | tests/auto/quick/qquickgridview/tst_qquickgridview.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/tests/auto/quick/qquickgridview/tst_qquickgridview.cpp b/tests/auto/quick/qquickgridview/tst_qquickgridview.cpp index 9876a36ec3..472b9a0fe1 100644 --- a/tests/auto/quick/qquickgridview/tst_qquickgridview.cpp +++ b/tests/auto/quick/qquickgridview/tst_qquickgridview.cpp @@ -1313,8 +1313,8 @@ void tst_QQuickGridView::moved_defaultLayout(QQuickGridView::Flow flow, for (int i = firstVisibleIndex; i < model.count() && i < items.count(); ++i) { QQuickItem *item = findItem<QQuickItem>(contentItem, "wrapper", i); if (!item && - ( (flow == QQuickGridView::FlowLeftToRight && i >= firstVisibleIndex + (3*6)) - || flow == QQuickGridView::FlowTopToBottom && i >= firstVisibleIndex + (5*3) ) ) { + ( (flow == QQuickGridView::FlowLeftToRight && i >= firstVisibleIndex + (3*6)) + || (flow == QQuickGridView::FlowTopToBottom && i >= firstVisibleIndex + (5*3)) ) ) { continue; // index has moved out of view } QVERIFY2(item, QTest::toString(QString("Item %1 not found").arg(i))); @@ -1559,6 +1559,8 @@ void tst_QQuickGridView::multipleChanges(bool condensed) case ListChange::SetContentY: gridview->setContentY(changes[i].pos); break; + case ListChange::Polish: + break; } if (condensed) { QTRY_COMPARE(QQuickItemPrivate::get(gridview)->polishScheduled, false); @@ -5428,6 +5430,7 @@ void tst_QQuickGridView::displacedTransitions() break; case ListChange::SetCurrent: case ListChange::SetContentY: + case ListChange::Polish: break; } @@ -5674,6 +5677,8 @@ void tst_QQuickGridView::multipleTransitions() gridview->setContentY(changes[i].pos); QTRY_COMPARE(QQuickItemPrivate::get(gridview)->polishScheduled, false); break; + case ListChange::Polish: + break; } } QCOMPARE(gridview->count(), model.count()); |