Don't copy or assign QEvent instances in tests

Copying/assigning polymorphic types is a code smell, use separate
instances instead in the tests. Those should perhaps be rewritten
to use a data driven testing approach, there's a lot of code
repetition.

In the test API implementation, first evaluate the parameters for
the event, then construct the event once with the correct values.

Change-Id: I2572772698cb0204f5ff950741b9fe3805fae15d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>

1 files changed, 16 insertions, 12 deletions

diff --git a/tests/auto/quick/qquicktextedit/tst_qquicktextedit.cpp b/tests/auto/quick/qquicktextedit/tst_qquicktextedit.cpp
index 41538896d2..8f657430bb 100644
--- a/tests/auto/quick/qquicktextedit/tst_qquicktextedit.cpp
+++ b/tests/auto/quick/qquicktextedit/tst_qquicktextedit.cpp
@@ -3589,13 +3589,15 @@ void tst_qquicktextedit::signal_editingfinished()
     QTRY_VERIFY(input1->hasActiveFocus());
     QTRY_VERIFY(!input2->hasActiveFocus());
 
-    QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier, "", false, 1);
-    QGuiApplication::sendEvent(window, &key);
-    QVERIFY(key.isAccepted());
-    QTRY_COMPARE(editingFinished1Spy.count(), 1);
+    {
+        QKeyEvent key(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier, "", false, 1);
+        QGuiApplication::sendEvent(window, &key);
+        QVERIFY(key.isAccepted());
+        QTRY_COMPARE(editingFinished1Spy.count(), 1);
 
-    QTRY_VERIFY(!input1->hasActiveFocus());
-    QTRY_VERIFY(input2->hasActiveFocus());
+        QTRY_VERIFY(!input1->hasActiveFocus());
+        QTRY_VERIFY(input2->hasActiveFocus());
+    }
 
     QSignalSpy editingFinished2Spy(input2, SIGNAL(editingFinished()));
 
@@ -3603,13 +3605,15 @@ void tst_qquicktextedit::signal_editingfinished()
     QTRY_VERIFY(!input1->hasActiveFocus());
     QTRY_VERIFY(input2->hasActiveFocus());
 
-    key = QKeyEvent(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier, "", false, 1);
-    QGuiApplication::sendEvent(window, &key);
-    QVERIFY(key.isAccepted());
-    QTRY_COMPARE(editingFinished2Spy.count(), 1);
+    {
+        QKeyEvent key = QKeyEvent(QEvent::KeyPress, Qt::Key_Tab, Qt::ShiftModifier, "", false, 1);
+        QGuiApplication::sendEvent(window, &key);
+        QVERIFY(key.isAccepted());
+        QTRY_COMPARE(editingFinished2Spy.count(), 1);
 
-    QTRY_VERIFY(input1->hasActiveFocus());
-    QTRY_VERIFY(!input2->hasActiveFocus());
+        QTRY_VERIFY(input1->hasActiveFocus());
+        QTRY_VERIFY(!input2->hasActiveFocus());
+    }
 }
 
 void tst_qquicktextedit::clipRect()