aboutsummaryrefslogtreecommitdiffstats
path: root/tests/manual
diff options
context:
space:
mode:
authorShawn Rutledge <shawn.rutledge@qt.io>2020-07-29 17:08:20 +0200
committerShawn Rutledge <shawn.rutledge@qt.io>2020-07-30 11:11:58 +0200
commit3baa87d0697368aea1a236b47c9971071a7b33ae (patch)
treeca8a0677c20ed74248cccfddfb974afb9bc55ddc /tests/manual
parentf4f63ce44f36c3125aa1d554af7c912b00022b29 (diff)
Remove the pointId += deviceId << 24 hack from translateTouchEvent()
1204ed14dc11e6343a569646428a7ffddd098f8c did this in some places but not others. The result is mismatched pointIds in some cases: e.g. a QObject event filter intercepts a touch press with modified pointIds (because translateTouchEvent() got called) but the release event has the original unmodified ids. So we avoid this hack for touchpoint IDs, but keep it intact for mouse and tablet points, for now. The trouble is that 0 is a really common value, so removing this hack everywhere can also break tests that are checking simultaneous mouse and touch. Eventually we need to start using the available QInputEvent::device() in more places to avoid confusing points that come from different devices. Fixes: QTBUG-85785 Change-Id: I873780b63e964c13dc96ed7fbf92cb019d079237 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Diffstat (limited to 'tests/manual')
0 files changed, 0 insertions, 0 deletions