diff options
| author | Shawn Rutledge <shawn.rutledge@qt.io> | 2020-11-11 21:29:11 +0100 |
|---|---|---|
| committer | Shawn Rutledge <shawn.rutledge@qt.io> | 2020-11-12 07:09:24 +0100 |
| commit | 262d7eb305e1dea8dac660bec3ccc50193258ea9 (patch) | |
| tree | bd4c75dd376c9f7f2dd7b9ae0e7f440afc7468e3 /tests | |
| parent | 62763ff04555ce86619ae9a83a42ca4e45db0ec9 (diff) | |
Fix QQWinPriv::deliverSinglePointEventUntilAccepted for wheel, gestures
WheelHandler was only reacting to one wheel event between mouse moves,
because it got added to the QQPointerHandlerPriv::deviceDeliveryTargets()
vector, and was not removed at the beginning of delivery of subsequent
events, as QQuickWindowPrivate::deliverPointerEvent() does. (In Qt 5
the equivalent vector was cleared in QQuickPointerMouseEvent::reset().)
Wheel events are delivered via deliverSinglePointEventUntilAccepted()
(grabbing the wheel is still not implemented). Native gesture events
are delivered that way too; and sure enough, the same bug happens on the
macOS trackpad, whether you are attempting to do pinch zoom or just
two-finger-flick.
tst_QQuickWheelHandler::nestedHandler() sends multiple wheel events
in a row, so we do have some test coverage, and hopefully this issue
explains why it needed to be blacklisted.
Fixes: QTBUG-88428
Task-number: QTBUG-86729
Change-Id: Id1ed4a38dfa3eb2253c4a60f09f80aea0f69707e
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/tests/auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST b/tests/auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST index a189ebe041..2949d3371f 100644 --- a/tests/auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST +++ b/tests/auto/quick/pointerhandlers/qquickwheelhandler/BLACKLIST @@ -1,6 +1,3 @@ # QTBUG-81993 [singleHandler] macos ci -* # QTBUG-86729 -[nestedHandler] -* # QTBUG-86729 |