diff options
| author | Ulf Hermann <ulf.hermann@qt.io> | 2020-10-02 17:31:10 +0200 |
|---|---|---|
| committer | Ulf Hermann <ulf.hermann@qt.io> | 2020-10-05 14:56:26 +0200 |
| commit | 1b8987ffcc85d0b53c2d688b4e8901f938fdbc44 (patch) | |
| tree | 83611453cd08dee73fb4805b5be349a0cc3ff2a5 /tests | |
| parent | 1b4a2f5def7fc3e9f5b2362a70130d0333d3cfaa (diff) | |
qmllint: Mark anchors3.qml as dirty
This is in fact invalid QML. The assignment shouldn't be accepted but
qmllint cannot see that, yet.
Change-Id: Ifcb2f01edaf10ada5ce4d762726c51af3b4f5087
Reviewed-by: Maximilian Goldstein <max.goldstein@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/auto/qml/qmllint/data/anchors3.qml | 2 | ||||
| -rw-r--r-- | tests/auto/qml/qmllint/data/nanchors3.qml | 2 | ||||
| -rw-r--r-- | tests/auto/qml/qmllint/tst_qmllint.cpp | 6 |
3 files changed, 7 insertions, 3 deletions
diff --git a/tests/auto/qml/qmllint/data/anchors3.qml b/tests/auto/qml/qmllint/data/anchors3.qml index 290b19f98b..2728291651 100644 --- a/tests/auto/qml/qmllint/data/anchors3.qml +++ b/tests/auto/qml/qmllint/data/anchors3.qml @@ -1,6 +1,6 @@ import QtQuick 2.15 -Rectangle { +Rectangle { anchors.horizontalCenter: parent anchors.verticalCenter: parent } diff --git a/tests/auto/qml/qmllint/data/nanchors3.qml b/tests/auto/qml/qmllint/data/nanchors3.qml index 4ba987ed9c..0ac2b62e3d 100644 --- a/tests/auto/qml/qmllint/data/nanchors3.qml +++ b/tests/auto/qml/qmllint/data/nanchors3.qml @@ -1,6 +1,6 @@ import QtQuick 2.15 -Rectangle { +Rectangle { nanchors.horizontalCenter: parent nanchors.verticalCenter: parent } diff --git a/tests/auto/qml/qmllint/tst_qmllint.cpp b/tests/auto/qml/qmllint/tst_qmllint.cpp index da210e6abf..943092beca 100644 --- a/tests/auto/qml/qmllint/tst_qmllint.cpp +++ b/tests/auto/qml/qmllint/tst_qmllint.cpp @@ -199,6 +199,10 @@ void TestQmllint::dirtyQmlCode_data() << QStringLiteral("badEnumFromQtQml.qml") << QString("Warning: Property \"Linear123\" not found on type \"QQmlEasingEnums\"") << QString(); + QTest::newRow("anchors3") + << QStringLiteral("anchors3.qml") + << QString() + << QString(); QTest::newRow("nanchors1") << QStringLiteral("nanchors1.qml") << QString() @@ -224,6 +228,7 @@ void TestQmllint::dirtyQmlCode() const QString output = runQmllint(filename, [&](QProcess &process) { QVERIFY(process.waitForFinished()); QCOMPARE(process.exitStatus(), QProcess::NormalExit); + QEXPECT_FAIL("anchors3", "We don't see that QQuickItem cannot be assigned to QQuickAnchorLine", Abort); QEXPECT_FAIL("nanchors1", "Invalid grouped properties are not detected", Abort); QEXPECT_FAIL("nanchors2", "Invalid grouped properties are not detected", Abort); QEXPECT_FAIL("nanchors3", "Invalid grouped properties are not detected", Abort); @@ -268,7 +273,6 @@ void TestQmllint::cleanQmlCode_data() QTest::newRow("enumFromQtQml") << QStringLiteral("enumFromQtQml.qml"); QTest::newRow("anchors1") << QStringLiteral("anchors1.qml"); QTest::newRow("anchors2") << QStringLiteral("anchors2.qml"); - QTest::newRow("anchors3") << QStringLiteral("anchors3.qml"); } void TestQmllint::cleanQmlCode() |