diff options
| author | Martin Jones <martin.jones@nokia.com> | 2011-07-27 16:56:08 +1000 |
|---|---|---|
| committer | Qt by Nokia <qt-info@nokia.com> | 2011-07-28 05:05:05 +0200 |
| commit | a8d3802938df60a74990c2c915446061b047057d (patch) | |
| tree | 815710e6f7d1d932ce2ae8a3ce0d406e3edb0e9f /tests | |
| parent | aa99d4f5cb4f1f512d1db90536752b518dbea449 (diff) | |
Fix insertion of one item in ListView.
Off-by-one meant that the item was not created by the ListView.
Change-Id: If9658487a615e189c21c419e4d29e7e709e05cef
Fixes: QTBUG-19675
Reviewed-on: http://codereview.qt.nokia.com/2251
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Bea Lam <bea.lam@nokia.com>
Diffstat (limited to 'tests')
| -rw-r--r-- | tests/auto/declarative/qsglistview/tst_qsglistview.cpp | 8 | ||||
| -rw-r--r-- | tests/auto/qtquick1/qdeclarativelistview/tst_qdeclarativelistview.cpp | 8 |
2 files changed, 16 insertions, 0 deletions
diff --git a/tests/auto/declarative/qsglistview/tst_qsglistview.cpp b/tests/auto/declarative/qsglistview/tst_qsglistview.cpp index a3b5cd64bd..e2e4b044ad 100644 --- a/tests/auto/declarative/qsglistview/tst_qsglistview.cpp +++ b/tests/auto/declarative/qsglistview/tst_qsglistview.cpp @@ -620,6 +620,14 @@ void tst_QSGListView::inserted() // QTRY_COMPARE(listview->contentItemHeight(), model.count() * 20.0); + // QTBUG-19675 + model.clear(); + model.insertItem(0, "Hello", "1234"); + QSGItem *item = findItem<QSGItem>(contentItem, "wrapper", 0); + QVERIFY(item); + QCOMPARE(item->y(), 0.); + QVERIFY(listview->contentY() == 0); + delete canvas; delete testObject; } diff --git a/tests/auto/qtquick1/qdeclarativelistview/tst_qdeclarativelistview.cpp b/tests/auto/qtquick1/qdeclarativelistview/tst_qdeclarativelistview.cpp index d55a851ede..0742673373 100644 --- a/tests/auto/qtquick1/qdeclarativelistview/tst_qdeclarativelistview.cpp +++ b/tests/auto/qtquick1/qdeclarativelistview/tst_qdeclarativelistview.cpp @@ -557,6 +557,14 @@ void tst_QDeclarative1ListView::inserted() // QTRY_COMPARE(listview->contentItemHeight(), model.count() * 20.0); + // QTBUG-19675 + model.clear(); + model.insertItem(0, "Hello", "1234"); + QDeclarativeItem *item = findItem<QDeclarativeItem>(contentItem, "wrapper", 0); + QVERIFY(item); + QCOMPARE(item->y(), 0.); + QVERIFY(listview->contentY() == 0); + delete canvas; delete testObject; } |