tools: replace 'foreach' with 'range for'

Catch rvalues to prevent detach()'ing.

Change-Id: I7be159a405c994429c0eee10805bfe96fcf4c806
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>

1 files changed, 5 insertions, 4 deletions

diff --git a/tools/qmllint/main.cpp b/tools/qmllint/main.cpp
index 211427cc64..99a53110a8 100644
--- a/tools/qmllint/main.cpp
+++ b/tools/qmllint/main.cpp
@@ -59,7 +59,8 @@ static bool lint_file(const QString &filename, bool silent)
     bool success = isJavaScript ? parser.parseProgram() : parser.parse();
 
     if (!success && !silent) {
-        foreach (const QQmlJS::DiagnosticMessage &m, parser.diagnosticMessages()) {
+        const auto diagnosticMessages = parser.diagnosticMessages();
+        for (const QQmlJS::DiagnosticMessage &m : diagnosticMessages) {
             qWarning("%s:%d : %s", qPrintable(filename), m.loc.startLine, qPrintable(m.message));
         }
     }
@@ -82,15 +83,15 @@ int main(int argv, char *argc[])
 
     parser.process(app);
 
-    if (parser.positionalArguments().isEmpty()) {
+    const auto positionalArguments = parser.positionalArguments();
+    if (positionalArguments.isEmpty()) {
         parser.showHelp(-1);
     }
 
     bool silent = parser.isSet(silentOption);
     bool success = true;
-    foreach (const QString &filename, parser.positionalArguments()) {
+    for (const QString &filename : positionalArguments)
         success &= lint_file(filename, silent);
-    }
 
     return success ? 0 : -1;
 }