diff options
author | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-01-15 15:23:25 +0300 |
---|---|---|
committer | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-01-15 14:11:38 +0000 |
commit | 201f84f204dc920023ceb64a2aab624f6ab481c8 (patch) | |
tree | ad37de58347912a69a3f5bcca067fb61f894ae3f /tools/qmlprofiler/qmlprofilerdata.cpp | |
parent | 6b4710669a2fbeb2c5a3f703e7597cfd1e80c709 (diff) |
Tools: fix expensive iteration over QHash::keys()
Change-Id: I902bafdbc2ddfceeacfc9ef274513a2b0a23aed7
Reviewed-by: Ulf Hermann <ulf.hermann@theqtcompany.com>
Diffstat (limited to 'tools/qmlprofiler/qmlprofilerdata.cpp')
-rw-r--r-- | tools/qmlprofiler/qmlprofilerdata.cpp | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/tools/qmlprofiler/qmlprofilerdata.cpp b/tools/qmlprofiler/qmlprofilerdata.cpp index dd7e5d561b..c702633d7c 100644 --- a/tools/qmlprofiler/qmlprofilerdata.cpp +++ b/tools/qmlprofiler/qmlprofilerdata.cpp @@ -520,10 +520,13 @@ bool QmlProfilerData::save(const QString &filename) stream.writeStartElement(QStringLiteral("eventData")); stream.writeAttribute(QStringLiteral("totalTime"), QString::number(d->qmlMeasuredTime)); - foreach (const QmlRangeEventData *eventData, d->eventDescriptions.values()) { + const auto eventDescriptionsKeys = d->eventDescriptions.keys(); + for (auto it = d->eventDescriptions.cbegin(), end = d->eventDescriptions.cend(); + it != end; ++it) { + const QmlRangeEventData *eventData = it.value(); stream.writeStartElement(QStringLiteral("event")); stream.writeAttribute(QStringLiteral("index"), QString::number( - d->eventDescriptions.keys().indexOf(eventData->eventHashStr))); + eventDescriptionsKeys.indexOf(eventData->eventHashStr))); if (!eventData->displayName.isEmpty()) stream.writeTextElement(QStringLiteral("displayname"), eventData->displayName); if (eventData->rangeType != QQmlProfilerDefinitions::MaximumRangeType) @@ -581,7 +584,7 @@ bool QmlProfilerData::save(const QString &filename) stream.writeAttribute(QStringLiteral("duration"), QString::number(event.duration)); stream.writeAttribute(QStringLiteral("eventIndex"), QString::number( - d->eventDescriptions.keys().indexOf(event.data->eventHashStr))); + eventDescriptionsKeys.indexOf(event.data->eventHashStr))); if (event.data->message == QQmlProfilerDefinitions::Event) { if (event.data->detailType == QQmlProfilerDefinitions::AnimationFrame) { // special: animation frame |