qmltc: Do not generate bindables and setters for QQmlListProperty

Assigning to a QQmlListProperty does not do what you think it does.

Change-Id: Ie6ac3208d552d8f40d9f2f4d7fb33c1cd64e4b79
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
(cherry picked from commit 134f305b7f96e1a127261bbfac9bdb1f3a22e546)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>

1 files changed, 12 insertions, 8 deletions

diff --git a/tools/qmltc/prototype/codegenerator.cpp b/tools/qmltc/prototype/codegenerator.cpp
index 747db452e9..f60c8b71f9 100644
--- a/tools/qmltc/prototype/codegenerator.cpp
+++ b/tools/qmltc/prototype/codegenerator.cpp
@@ -869,7 +869,9 @@ void CodeGenerator::compileProperty(QQmlJSAotObject &current, const QQmlJSMetaPr
     Qml2CppPropertyData compilationData(p);
 
     // 1. add setter and getter
-    if (p.isWritable()) {
+    // If p.isList(), it's a QQmlListProperty. Then you can write the underlying list through
+    // the QQmlListProperty object retrieved with the getter. Setting it would make no sense.
+    if (p.isWritable() && !p.isList()) {
         QQmlJSAotMethod setter {};
         setter.returnType = u"void"_qs;
         setter.name = compilationData.write;
@@ -890,13 +892,15 @@ void CodeGenerator::compileProperty(QQmlJSAotObject &current, const QQmlJSMetaPr
     mocPieces << u"READ"_qs << getter.name;
 
     // 2. add bindable
-    QQmlJSAotMethod bindable {};
-    bindable.returnType = u"QBindable<" + underlyingType + u">";
-    bindable.name = compilationData.bindable;
-    bindable.body << u"return QBindable<" + underlyingType + u">(std::addressof(" + variableName
-                    + u"));";
-    current.functions.emplaceBack(bindable);
-    mocPieces << u"BINDABLE"_qs << bindable.name;
+    if (!p.isList()) {
+        QQmlJSAotMethod bindable {};
+        bindable.returnType = u"QBindable<" + underlyingType + u">";
+        bindable.name = compilationData.bindable;
+        bindable.body << u"return QBindable<" + underlyingType + u">(std::addressof(" + variableName
+                        + u"));";
+        current.functions.emplaceBack(bindable);
+        mocPieces << u"BINDABLE"_qs << bindable.name;
+    }
 
     // 3. add/check notify (actually, this is already done inside QmltcVisitor)