aboutsummaryrefslogtreecommitdiffstats
path: root/tools
diff options
context:
space:
mode:
authorMaximilian Goldstein <max.goldstein@qt.io>2020-07-01 12:15:15 +0200
committerMaximilian Goldstein <max.goldstein@qt.io>2020-07-02 10:51:39 +0200
commite9d03ec78fd95d10e9d9653c1f3d6dc5433de433 (patch)
treea7e1427ce81a937f1def1d8c93f7c0b40ab0c54c /tools
parent05daefeb27e301a29990e8a97a8c8dec70b4a44c (diff)
qmlformat: Fix multiline bindings
Some bindings may turn multiline while formatting. This change makes sure this is handled properly. Fixes: QTBUG-85289 Change-Id: I6df98b926d69a23480003c3d9705bc34c3dd0d5d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 38e0b279d9c36d029918a2d86575050d13778d86)
Diffstat (limited to 'tools')
-rw-r--r--tools/qmlformat/dumpastvisitor.cpp12
1 files changed, 12 insertions, 0 deletions
diff --git a/tools/qmlformat/dumpastvisitor.cpp b/tools/qmlformat/dumpastvisitor.cpp
index a92bd83c70..ef6e234cc3 100644
--- a/tools/qmlformat/dumpastvisitor.cpp
+++ b/tools/qmlformat/dumpastvisitor.cpp
@@ -1115,8 +1115,20 @@ bool DumpAstVisitor::visit(UiScriptBinding *node) {
addLine(getComment(node, Comment::Location::Front));
+ bool multiline = !needsSemicolon(node->statement->kind);
+
+ if (multiline) {
+ m_indentLevel++;
+ }
+
QString statement = parseStatement(node->statement);
+ if (multiline) {
+ statement = "{\n" + formatLine(statement);
+ m_indentLevel--;
+ statement += formatLine("}", false);
+ }
+
QString result = parseUiQualifiedId(node->qualifiedId) + ":";
if (!statement.isEmpty())