aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
-rw-r--r--src/qml/jsruntime/qv4qobjectwrapper.cpp8
-rw-r--r--tests/auto/qml/qqmlecmascript/data/qtbug_32801.qml10
-rw-r--r--tests/auto/qml/qqmlecmascript/testtypes.h1
-rw-r--r--tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp13
4 files changed, 27 insertions, 5 deletions
diff --git a/src/qml/jsruntime/qv4qobjectwrapper.cpp b/src/qml/jsruntime/qv4qobjectwrapper.cpp
index 3bca862bb7..1fd47c7c66 100644
--- a/src/qml/jsruntime/qv4qobjectwrapper.cpp
+++ b/src/qml/jsruntime/qv4qobjectwrapper.cpp
@@ -1436,14 +1436,15 @@ void *CallArgument::dataPtr()
{
if (type == -1)
return qvariantPtr->data();
- else
+ else if (type != 0)
return (void *)&allocData;
+ return 0;
}
void CallArgument::initAsType(int callType)
{
if (type != 0) { cleanup(); type = 0; }
- if (callType == QMetaType::UnknownType) return;
+ if (callType == QMetaType::UnknownType || callType == QMetaType::Void) return;
if (callType == qMetaTypeId<QJSValue>()) {
qjsValuePtr = new (&allocData) QJSValue();
@@ -1478,9 +1479,6 @@ void CallArgument::initAsType(int callType)
} else if (callType == QMetaType::QJsonValue) {
type = callType;
jsonValuePtr = new (&allocData) QJsonValue();
- } else if (callType == QMetaType::Void) {
- type = -1;
- qvariantPtr = new (&allocData) QVariant();
} else {
type = -1;
qvariantPtr = new (&allocData) QVariant(callType, (void *)0);
diff --git a/tests/auto/qml/qqmlecmascript/data/qtbug_32801.qml b/tests/auto/qml/qqmlecmascript/data/qtbug_32801.qml
new file mode 100644
index 0000000000..c305ba7178
--- /dev/null
+++ b/tests/auto/qml/qqmlecmascript/data/qtbug_32801.qml
@@ -0,0 +1,10 @@
+import Qt.test 1.0
+import QtQuick 2.0
+
+MyQmlObject {
+ signal testSignal(string arg)
+
+ function emitTestSignal() {
+ testSignal("test")
+ }
+}
diff --git a/tests/auto/qml/qqmlecmascript/testtypes.h b/tests/auto/qml/qqmlecmascript/testtypes.h
index c6f6de7337..0fdcdafb95 100644
--- a/tests/auto/qml/qqmlecmascript/testtypes.h
+++ b/tests/auto/qml/qqmlecmascript/testtypes.h
@@ -268,6 +268,7 @@ public slots:
void qjsvalueMethod(const QJSValue &v) { m_qjsvalue = v; }
void v8function(QQmlV4Function*);
void registeredFlagMethod(Qt::MouseButtons v) { m_buttons = v; }
+ QString slotWithReturnValue(const QString &arg) { return arg; }
private:
friend class tst_qqmlecmascript;
diff --git a/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp b/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp
index 47b7a6640c..e764ae783c 100644
--- a/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp
+++ b/tests/auto/qml/qqmlecmascript/tst_qqmlecmascript.cpp
@@ -306,6 +306,7 @@ private slots:
void jsOwnedObjectsDeletedOnEngineDestroy();
void numberParsing();
void stringParsing();
+ void qtbug_32801();
private:
// static void propertyVarWeakRefCallback(v8::Persistent<v8::Value> object, void* parameter);
@@ -7288,6 +7289,18 @@ void tst_qqmlecmascript::stringParsing()
}
}
+void tst_qqmlecmascript::qtbug_32801()
+{
+ QQmlComponent component(&engine, testFileUrl("qtbug_32801.qml"));
+
+ QScopedPointer<QObject> obj(component.create());
+ QVERIFY(obj != 0);
+
+ // do not crash when a QML signal is connected to a non-void slot
+ connect(obj.data(), SIGNAL(testSignal(QString)), obj.data(), SLOT(slotWithReturnValue(QString)));
+ QVERIFY(QMetaObject::invokeMethod(obj.data(), "emitTestSignal"));
+}
+
QTEST_MAIN(tst_qqmlecmascript)
#include "tst_qqmlecmascript.moc"