diff options
Diffstat (limited to 'src/qml')
-rw-r--r-- | src/qml/jit/qv4binop.cpp | 4 | ||||
-rw-r--r-- | src/qml/qml/v8/qqmlbuiltinfunctions.cpp | 11 |
2 files changed, 11 insertions, 4 deletions
diff --git a/src/qml/jit/qv4binop.cpp b/src/qml/jit/qv4binop.cpp index a055dffcac..c6c8023cd7 100644 --- a/src/qml/jit/qv4binop.cpp +++ b/src/qml/jit/qv4binop.cpp @@ -430,13 +430,13 @@ bool Binop::int32Binop(IR::Expr *leftSource, IR::Expr *rightSource, IR::Expr *ta as->lshift32(l, Assembler::ScratchRegister, targetReg); break; - case IR::OpLShift: + case IR::OpRShift: as->move(r, Assembler::ScratchRegister); as->and32(Assembler::TrustedImm32(0x1f), Assembler::ScratchRegister); as->rshift32(l, Assembler::ScratchRegister, targetReg); break; - case IR::OpLShift: + case IR::OpURShift: as->move(r, Assembler::ScratchRegister); as->and32(Assembler::TrustedImm32(0x1f), Assembler::ScratchRegister); as->storeUInt32(targetReg, target); // IMPORTANT: do NOT do a break here! The stored type of an urshift is different from the other binary operations! diff --git a/src/qml/qml/v8/qqmlbuiltinfunctions.cpp b/src/qml/qml/v8/qqmlbuiltinfunctions.cpp index 58542e4479..f53b9a0c7d 100644 --- a/src/qml/qml/v8/qqmlbuiltinfunctions.cpp +++ b/src/qml/qml/v8/qqmlbuiltinfunctions.cpp @@ -814,8 +814,15 @@ ReturnedValue QtObject::method_formatDateTime(QV4::CallContext *ctx) } /*! -\qmlmethod bool Qt::openUrlExternally(url target) -Attempts to open the specified \c target url in an external application, based on the user's desktop preferences. Returns true if it succeeds, and false otherwise. + \qmlmethod bool Qt::openUrlExternally(url target) + + Attempts to open the specified \c target url in an external application, based on the user's + desktop preferences. Returns true if it succeeds, and false otherwise. + + \warning A return value of \c true indicates that the application has successfully requested + the operating system to open the URL in an external application. The external application may + still fail to launch or fail to open the requested URL. This result will not be reported back + to the application. */ ReturnedValue QtObject::method_openUrlExternally(QV4::CallContext *ctx) { |