aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* qmlplugindump: Describe meta object revisions of exported types.Christian Kamm2011-09-213-13/+49
| | | | | | | | Adds the exportMetaObjectRevisions property to generated qmltypes files. Change-Id: Iafe2fe408c88bb6dd02cbb558404a5f654431248 Reviewed-on: http://codereview.qt-project.org/5311 Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
* Fix processing of unary T_MINUS_MINUS tokens after semicolon insertion.Roberto Raggi2011-09-211-1/+1
| | | | | | | | | | There was a typo in the code, instead of pushing a T_MINUS_MINUS token the lexer synthesized a T_PLUS_PLUS. Change-Id: I62dcf263ac363196231fe8f02e98f280899ef85a Reviewed-on: http://codereview.qt-project.org/5293 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Christian Kamm <christian.d.kamm@nokia.com>
* Test qmlmin using the QML/JS files from our test suite.Roberto Raggi2011-09-211-1/+35
| | | | | | | | | | | qmlmin was already tested using files from the QtDeclarative examples. This patch adds all the files from QtDeclarative test suite. Change-Id: I2a7a0e4a45d53f70f53911a5985c860565f10b70 Reviewed-on: http://codereview.qt-project.org/5296 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* qdeclarativesystempalette test: Add missing dependencyKent Hansen2011-09-211-1/+1
| | | | | | | Change-Id: Iefc44448feb621fda81eed6d243bc4a8ee474e7f Reviewed-on: http://codereview.qt-project.org/5313 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
* Make qdeclarativeapplication test compile againKent Hansen2011-09-211-6/+11
| | | | | | | | | | | It shouldn't depend on QtWidgets, but using QGuiApplication doesn't work yet, so skip the tests for now. Change-Id: I79473a9ed0486d51c37f498a5e58c503f9533759 Reviewed-on: http://codereview.qt-project.org/5314 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Samuel Rødal <samuel.rodal@nokia.com>
* Zero-initialize QSGParticleGroup::m_system.Christian Kamm2011-09-211-0/+1
| | | | | | Change-Id: Iaa38e1816ff2f231f588bce155a7b1bf9b21a3e5 Reviewed-on: http://codereview.qt-project.org/5291 Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
* Restructure test to use QTRY_ macro for instability.Toby Tomkins2011-09-211-42/+15
| | | | | | | | | | | Restructure test to use QTRY_ for asynchronous gui functions. Remove reference to specific X11 and generalise event queue processing for all platforms. Change-Id: I9aa27729d35cbf3c2e2a7986210f6128d22696ef Reviewed-on: http://codereview.qt-project.org/4728 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Remove expected failure for qpa platformToby Tomkins2011-09-211-11/+0
| | | | | | | | | | QTBUG-21011 has been resolved, hence the qpa platform can be enabled for this test. Change-Id: I1a1e76077eb102c389b09c79e069f6d9e25e2637 Reviewed-on: http://codereview.qt-project.org/4624 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
* Use QDeclarativeChangeSet to communicate changes to views.Andrew den Exter2011-09-2111-327/+255
| | | | | | | | | | | | | Allows QSGVisualDataModel to send multiple changes at a time. Changes sets with multiple changes will be generated by VisualDataModels with items that have been re-ordered or filtered. Task-number: QTBUG-20107 Change-Id: I28f2620431cc89c61e1061635ffb68dc5801675c Reviewed-on: http://codereview.qt-project.org/4034 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Bea Lam <bea.lam@nokia.com> Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
* Refactor QSGVisualDataModel.Andrew den Exter2011-09-2113-1402/+2000
| | | | | | | | | | | | | Split the wrapper for Package models out into its own visual model class, add a QSGVisualAdaptorModel class which encapsulates the creation and maintenance of delegate context data, and move QSGVisualDataModel to its own source files. Task-number: QTBUG-20107 Change-Id: Icdea2756a119c327ec2c748be893daf622bc1356 Reviewed-on: http://codereview.qt-project.org/4033 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
* Compress consecutive removals.Andrew den Exter2011-09-211-0/+16
| | | | | | | | | | If an applied list of changes has consecutive removals compress them together before applying them to the change set. Change-Id: I75f178a31bbc8480d76be745c62e824125dbd8ba Reviewed-on: http://codereview.qt-project.org/4032 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
* Augment DocumentationAlan Alpert2011-09-211-1/+7
| | | | | | | Change-Id: Ie76de2631521cd3e50aa56f6b134fa33682b81cd Reviewed-on: http://codereview.qt-project.org/5208 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Damian Jansen <damian.jansen@nokia.com>
* Make turbulence respect offsetAlan Alpert2011-09-211-0/+1
| | | | | | | Change-Id: Ife84b900cd9c99aff4f4cb5f860a0853c08a40a3 Reviewed-on: http://codereview.qt-project.org/5206 Reviewed-by: Martin Jones <martin.jones@nokia.com> Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
* Add whitespaceAlan Alpert2011-09-2150-669/+738
| | | | | | Change-Id: Iad55228ffa86bbf63b12a33d0f00ce734807c071 Reviewed-on: http://codereview.qt-project.org/5199 Reviewed-by: Bea Lam <bea.lam@nokia.com>
* CustomEmitter/Affector now affect whole lists at onceAlan Alpert2011-09-219-64/+126
| | | | | | | | | | Better performance potential (fewer drops to JS, possibility of more optimzed JS). Change-Id: If386f06ac8714162a5bfc6b5eef7f2e67f9dae95 Reviewed-on: http://codereview.qt-project.org/5189 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
* Fixed compile of examples and tests.Rohan McGovern2011-09-2114-27/+24
| | | | | | | | | | | | | | | 6aad4122332c0291e2e3249b508c7583428177b9 in qtbase removed implicit linking to libQtWidgets. Projects which implicitly used that module were broken. Either remove the dependency where it is not required, or explicitly opt-in to libQtWidgets where it is required. Change-Id: I6f4fb1d98bdf5bb65b4f02a1d245d334314b163d Reviewed-on: http://codereview.qt-project.org/5268 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Toby Tomkins <toby.tomkins@nokia.com> Reviewed-by: Alan Alpert <alan.alpert@nokia.com>
* Make qdeclarativecomponent::creation() benchmark work againKent Hansen2011-09-208-22/+37
| | | | | | | | | The samegame files were out of date. Change-Id: Idf25a3c1d327ae94a76717aa7dde9a9dd15af9bb Reviewed-on: http://codereview.qt-project.org/5193 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
* QDeclarativeDebug: Allow reconnects to QML debugger portKai Koehne2011-09-203-64/+97
| | | | | | | | | | Allow a new client to attach once the old one was disconnected. Done by Aurindam Jana. Change-Id: Id85045204cc011ec6e02db2658173e652b75c07e Reviewed-on: http://codereview.qt-project.org/5132 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
* Added PerformanceHints flags to QSGPaintedItem.Yoann Lopes2011-09-205-4/+104
| | | | | | | | | | | | At the moment only contains FastFBOResizing. If this flag is set to true and when using a FBO as render target, the FBO will use a larger texture than the size of the item to avoid too many resizing. Change-Id: I3b8a51a5a07329ff3ed010a35dc8235913201a8e Reviewed-on: http://codereview.qt-project.org/4651 Reviewed-by: Yoann Lopes <yoann.lopes@nokia.com> Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
* Refactor QSGParticleAffector internalsAlan Alpert2011-09-203-33/+40
| | | | | | | | | | Putting more of the logic in protected subroutines makes it a lot easier for subclasses to reimplement affectSystem. Change-Id: I07f6553228064f1c9b68c6f55628b12b5c78013b Reviewed-on: http://codereview.qt-project.org/5172 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
* More ImageParticle sharingAlan Alpert2011-09-202-29/+88
| | | | | | | | Basic implementation of explicitAnimation, and RESET methods/docs added Change-Id: Ic522153b5287a97ba35e931cc6bddcde5d139fe7 Reviewed-on: http://codereview.qt-project.org/5182 Reviewed-by: Martin Jones <martin.jones@nokia.com>
* Remove QEXPECT_FAIL from QSGVisualDataModel test.Andrew den Exter2011-09-201-3/+0
| | | | | | | | | | QTBUG-21416 has been resolved. Task-number: QTBUG-21416 Change-Id: Ia8df8431bf429ff1c9d7956b9ed0ea9b95102549 Reviewed-on: http://codereview.qt-project.org/5185 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Andrew den Exter <andrew.den-exter@nokia.com>
* Fix QSGVisualDataModel test failure.Andrew den Exter2011-09-202-4/+5
| | | | | | | | | | | | | | | | Because the list view isn't visible it won't trigger a relayout unless forced by something like calling count() which means the test is looking up a stale list of items. VisualDataModel also wasn't clearing its cache when it changed the root item and so could return an old item if the view didn't release all items before querying a new one. Task-number: QTBUG-21416 Change-Id: I71193e22965f30ea92d9861ccbeff30b64d58309 Reviewed-on: http://codereview.qt-project.org/4953 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
* Initial ImageParticle sharingAlan Alpert2011-09-206-53/+452
| | | | | | | | | | | This allows particles rendered by ImageParticle to share some of their randomly generated state. Still to come are reset methods and animData sharing (so animations can look synced) Change-Id: Ia805e1b3735b15fba7bd14778ed7abd795b11f06 Reviewed-on: http://codereview.qt-project.org/5114 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
* Debugger: Fix compilation warningsKai Koehne2011-09-191-13/+16
| | | | | | | Change-Id: I57d2360566eb35c90db82075851f153727712980 Reviewed-on: http://codereview.qt-project.org/5137 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aurindam Jana <aurindam.jana@nokia.com>
* Make declarative/creation benchmark build againKent Hansen2011-09-192-6/+7
| | | | | | | Change-Id: I9ecbdcfc373e95de38e432aa627f6ab93d92afe6 Reviewed-on: http://codereview.qt-project.org/5138 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Unwrap QJSValue from QVariant in QV8Engine::fromVariantJędrzej Nowacki2011-09-194-1/+93
| | | | | | | | | | | | | | | | | | When QML tries to unwrap real value from a QVariant and the value is a QJSValue instance, then no conversion is needed, QJSValue already contains a v8 handle. This patch, for example, solves a problem of emitting QJSValue instance in a signal that has QVariant as an argument. The QJSValue can be unwrapped and used as a normal JS value in a connected slot. This feature may be used also in a plugin model that stores QJSValues internally. Then the model in data() function can return a QJSValue which would be understood by QML. Change-Id: I1d5ede40ce2637123b09839fd848b27ad3af3dda Reviewed-on: http://codereview.qt-project.org/4451 Reviewed-by: Kent Hansen <kent.hansen@nokia.com> Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
* Move JS RegExp flag definitions to header fileKent Hansen2011-09-192-11/+11
| | | | | | | | | | This way they can be used by tools that use the lexer (e.g. qml minifier). Change-Id: I226d1712089b01defd3b45ccb99db596955bff8b Reviewed-on: http://codereview.qt-project.org/4762 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com>
* Add install rule for qmlminKent Hansen2011-09-191-0/+2
| | | | | | | Change-Id: I7ea6e92e8fe54092bb16d92e69a83b0257a67acf Reviewed-on: http://codereview.qt-project.org/4787 Reviewed-by: Roberto Raggi <roberto.raggi@nokia.com> Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
* Fix typo when recognizing escape charactersRoberto Raggi2011-09-191-1/+1
| | | | | | | Change-Id: Id97d5c12d271794fb9c7c752fd6535af90883eb4 Reviewed-on: http://codereview.qt-project.org/4770 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Fix automatic insertion of semicolons.Roberto Raggi2011-09-191-7/+2
| | | | | | | | | | Use Lexer::canInsertAutomaticSemicolon() when recovering from errors generated by missing T_SEMICOLON tokens. Change-Id: Ie4011d8d3e02b02a7dccd0a09ffa28b1ec9e654d Reviewed-on: http://codereview.qt-project.org/5017 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Add support for minimizing Javascript files containing pragmas.Roberto Raggi2011-09-192-25/+92
| | | | | | | Change-Id: Ib61d5ea42ec810c36ba782b558461bc09be199dc Reviewed-on: http://codereview.qt-project.org/5016 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Add the method tokenKind() to the QML/JS lexer.Roberto Raggi2011-09-192-0/+6
| | | | | | | | | The method returns the last token recognized by the lexer. Change-Id: I9464e96c1276852737ddc8330d08d57326b48888 Reviewed-on: http://codereview.qt-project.org/5015 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Add support for QML/JS pragma directives.Roberto Raggi2011-09-192-0/+119
| | | | | | | | | | | | | The lexer can now recognize the following pragma directives: .pragma library .import <URI> <Version> as <Identifier> .import <file.js> as <Identifier> Change-Id: I2c44140818f356419640266a46b5e172474819ee Reviewed-on: http://codereview.qt-project.org/4897 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Add auto tests for the QML minifier.Roberto Raggi2011-09-193-1/+173
| | | | | | | Change-Id: Iba821eb490ea791e9c375565985af62cef91d1f3 Reviewed-on: http://codereview.qt-project.org/4671 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Fix automatic semicolon insertion.Roberto Raggi2011-09-196-18/+43
| | | | | | | | | | The parser should insert a T_SEMICOLON token when it reaches an error state and the lookahead token is following a closing brace. Change-Id: Ib849e7fbfe50c2a3e679ae0794f5780cc0b94de5 Reviewed-on: http://codereview.qt-project.org/4896 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Fix compile when the parser is included in non GUI applications.Roberto Raggi2011-09-191-1/+1
| | | | | | | Change-Id: I63d910f0f63cd88d919b5487d5b48f6019eca9bd Reviewed-on: http://codereview.qt-project.org/4895 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Added --verify-only option to qmlmin.Roberto Raggi2011-09-191-11/+17
| | | | | | | | | | | | | | | | | qmlmin has three different stages. In the first stage it generates the QML/JS minified code. In the second stage we verify that minified code is equivalent to the original code and in the final stage we produce the output. With --verify-only you can tell qmlmin to quit after the verification step. Note that this option is pretty much equivalent to the unix command qmlmin file.qml -o /dev/null. Change-Id: I91373bc1c1db8c35af2e301ad13d7b34fc384529 Reviewed-on: http://codereview.qt-project.org/4670 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Introduced qmlmin.Roberto Raggi2011-09-193-1/+529
| | | | | | | | | | qmlmin is a simple minifier for QML and Javascript files. It removes comments and layout characters. Change-Id: I387a683cd9b73e8fd225e10a75b3fcec50949938 Reviewed-on: http://codereview.qt-project.org/4442 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Fix the implementation of Lexer::tokenText().Roberto Raggi2011-09-192-7/+11
| | | | | | | | | | Lexer::tokenText() should return the contents of the string literal without the quotes. Change-Id: I968ca2e5142d8c55c75990c24380d2faa9b313a3 Reviewed-on: http://codereview.qt-project.org/4440 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Introduced a QML scanning mode.Roberto Raggi2011-09-193-32/+35
| | | | | | | | | | In QML mode, the lexer will recognize the extra QML keywords, e.g. readonly, as, on, and so on. Change-Id: I148ff857e201f99d41e0265bcfc480a94a1085a0 Reviewed-on: http://codereview.qt-project.org/4518 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kent Hansen <kent.hansen@nokia.com>
* Re-enable QtQuickTest.Rohan McGovern2011-09-193-6/+3
| | | | | | | | | | This was disabled in refactor, but it seems to be working OK, so turn it back on. Change-Id: I35d97342c6ef7be358d9cb593a1eab27c711247c Reviewed-on: http://codereview.qt-project.org/4846 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Charles Yin <charles.yin@nokia.com>
* Get rid of QDeclarativeUtilsKent Hansen2011-09-196-127/+31
| | | | | | | | | | | All the QChar methods needed by QtDeclarative have now been optimized to achieve at least as good performance as the QDeclarativeUtils versions. Change-Id: I5b8dd58f9b597f716b53563d07d39d894c5dd666 Reviewed-on: http://codereview.qt-project.org/5059 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
* Fix QDeclarativeListProperty assignmentChris Adams2011-09-193-1/+46
| | | | | | | | | | | | | This commit ensures that a QDeclarativeListReference can be assigned to another QDeclarativeListProperty, by retrieving each element in the list reference and converting to the appropriate type before appending to the target list property. Task-number: QTBUG-16316 Change-Id: Id8858058f052a53bf43eadc085fd278654478d77 Reviewed-on: http://codereview.qt-project.org/4388 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Aaron Kennedy <aaron.kennedy@nokia.com>
* Make cellWidth/cellHeight reals rather than ints.Michael Brasser2011-09-194-25/+56
| | | | | | | | | | When they were ints, it was relatively easy to end up with a different row or column count than expected, because of rounding. Change-Id: Ifc5eba2b5598cbc0220df25f91f031581c3b51a5 Reviewed-on: http://codereview.qt-project.org/5112 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Bea Lam <bea.lam@nokia.com>
* QtQuick 2.0 elements system testDamian Jansen2011-09-1949-0/+4096
| | | | | | | | | | | Added an application to browse elements. A very basic acceptance test method that each can be performed in under a minute. Added the .qtt for formal usage. Also moved qsgimage system test. Change-Id: Iada9804e2efe1339a072935647962e54aa3b4c6f Reviewed-on: http://codereview.qt-project.org/4380 Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
* PathAnimation updates.Michael Brasser2011-09-199-62/+351
| | | | | | | | | | Allow smooth orientation changes, smooth interruptions, and implicit "from" in PathAnimation. Change-Id: I2191f6df89ec25d78b1d498827281803a07129c9 Reviewed-on: http://codereview.qt-project.org/4378 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Martin Jones <martin.jones@nokia.com>
* Test fixes and reenables.Michael Brasser2011-09-183-40/+28
| | | | | | | Change-Id: I85e3493855b6fefb682ddb120b15abd003fb00fd Reviewed-on: http://codereview.qt-project.org/5045 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Michael Brasser <michael.brasser@nokia.com>
* JSDebugging: Enable break on events.Aurindam Jana2011-09-173-12/+100
| | | | | | | | | | | | The user can request Javascript break on event. The user can provide this info in the Breakpoints Window and provide the slot which will be called when the event occurs. For example: specify "onTriggered" if you need to break on Timer triggerred event. Change-Id: I09f869a5301a9c1f92a8b8c0f3df7f74b1027b4b Reviewed-on: http://codereview.qt-project.org/4751 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Kai Koehne <kai.koehne@nokia.com>
* Re-enable commented tests.Jędrzej Nowacki2011-09-164-7/+7
| | | | | | | | | | The tests used QWidget class so widgets library have to be added to pro file. QDeclarativestates works fine. Change-Id: I55c0798a37c3a894b774ba71671569fe007a49d7 Reviewed-on: http://codereview.qt-project.org/5104 Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com> Reviewed-by: Matthew Cattell <matthew.cattell@nokia.com>