| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Change-Id: Iaeb72aa1eac1b444ccb30529e409f11983573366
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The UIButton can have different configurations (styles), one of which
being a filled button style, which draws a background on the button,
and a plain style that doesn't, making the button look more like a label.
For our Button control in the iOS style, we opted to go with the latter
look (plain style, no background) for the flat button, and draw a
background for the normal state. In that case, draw the button text
in the appropriate colors, similar to the native look.
Change-Id: Ic19c2eb82a3184869af26fcf2980d94d6ceeb189
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
| |
Change-Id: I0e764f817aa6708ef4e47e2e98eb595ddb68f0b8
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add QQuickIOSTheme to initialize the QQuickTheme and set a palette with
the appropriate colors for the iOS style. Use the UIKit's API to get
correct colors in iOS, but hardcode them for macOS, just so we can keep
compiling the iOS style on macOS too.
Note: Ideally, we would use the QPlatformTheme (QIOSTheme) to do this,
but we use a fusion style palette in there because we use the Fusion
style on iOS for widget applications. In the future, we could revisit
this and set a "native-looking" palette to the QIOSTheme, like we are
doing now for the QQuickIOSTheme.
Change-Id: I661ffe5ac3d57b750994f7b46abb9502fd311f44
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
|
| |
Add images for the slider's disabled state and correct the insets'
color for the slider's handle images. The insets had a wrong shade of
red.
Change-Id: I8f0048a2739450bb34d4a47ee9f1262048182113
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
|
|
|
|
|
| |
Change-Id: I1b1c316cd46d57ec28b80d2206495330424face2
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|\
| |
| |
| | |
Change-Id: If094d48e544c4ea14c1e4c21d99322b71b580dde
|
| |
| |
| |
| |
| |
| | |
Pick-to: 6.3 6.2
Change-Id: Iba1799b94b63e4bf4d6aa8333fae867e4d08f429
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This basic block analysis pass uses the tracked types to determine dead
stores. This is better than the one we already have in the code
generator because it also tracks dead stores through renames and it
allows removal of lookup results. Furthermore, it adjusts each store to
write the type most favorable to its readers. This avoids unnecessary
conversions at run time.
It cannot replace the other dead store elimination, yet, because it
doesn't see whether the results of rename operations are read after the
rename. This capability will be added in a separate change that also
tracks the register numbers. Once this is in place, we can delete the
other basic blocks pass.
Task-number: QTBUG-100157
Change-Id: I766c919412b6cf43befa7bdb1a6e5e11b41fe55b
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Produces a warning with clang 15 on Ubuntu:
/home/ag/work/qt5/qtdeclarative/src/qml/../3rdparty/masm/assembler/X86Assembler.h:2368:23: error: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
emitRexIf(byteRegRequiresRex(reg)|byteRegRequiresRex(rm), reg, 0, rm);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Similar logic already uses || so this seems to be a typo.
Pick-to: 6.3 6.2
Change-Id: Ie539600e28748d902fbb443e47892a703003c7e6
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Pick-to: 6.3 6.2
Change-Id: I7a64585cc47c5dd3b1bb2139246bd98eea6335b9
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The type loader is specific to the engine. This way we can
calculate/retrieve the checksum without modifying the property cache,
which makes checksum() threadsafe. The checksums are only needed for
loading and storing compilation units from/to disk. Therefore, there is
no point in keeping them inside the property caches anyway.
Pick-to: 6.3
Task-number: QTBUG-73271
Change-Id: I7bea65e73769f76352bb5947d7229e256e7f2f25
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I6df08dca64ff8670e54c663912ebae980b316a5a
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This helps make our tests more structured and will also allow for
many other improvements down the line.
Also gets rid off our hack of constructing fake logger messages to
check against.
Change-Id: I0bbafc32c99ecb7abc7be1c6416e4d5903aff22c
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| | |
Pick-to: 6.2 6.3
Change-Id: I87acd2ff973b3acce6d575bf6b2e04b8e50f0597
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Make it easier for users to discover the other types of
validators by linking to various pages.
Change-Id: Ifb15b9629ec81bdc7d3e4da4811f2b591a611d23
Fixes: QTBUG-101402
Pick-to: 6.2 6.3
Reviewed-by: Nicholas Bennett <nicholas.bennett@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Migrate to the newer output ir classes (with adjustments)
- Deduplicate code writer and remove now-unused output helpers
from the prototype version
- Remove old output ir
Change-Id: Ie7fe5e6d47e18477c65af02cabd89a890628442c
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Wrap prototype code into Qt namespace
- Move inline component logic from prototype/visitor to qmltcvisitor
and erase (for now) property method setting (in favor of the
prototype logic which is more advanced)
- Move prototype/typeresolver.cpp into qmltctyperesolver.cpp
- Delete (now useless) prototype/{visitor, typeresolver}
- Start cleaning up prototype/qmlcompiler.h
- Adjust prototype/codegenerator accordingly
Change-Id: If49d6aa8bb97093b273915caa356278ca9bbdfe1
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: Ia4ba6a2708c31d56ea9abf9e41634fe79269e95d
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
grabWindow is now implemented for the offscreen plugin, so a large
number of tests relying on that functionality don't need to be skipped
any longer.
Change-Id: I85bfc9e4b327389055041b6187a54f88d9cf81d2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This code was mistakenly removed in
13399bd54d084ed837ec061ca9315dbd173f3b48.
Change-Id: Ibbae3fb51e324df0991123c8a083537e1bf76745
Fixes: QTBUG-101170
Pick-to: 6.3
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It doesn't make sense for these properties to be negative or larger
than 1.0.
The size property is meant to be the size of the scrollbar relative to
the scroll area size, either horizontally or vertically, and should be
in the value range 0 ≤ x ≤ 1, where 1 means that it covers the whole
scrollbar area, and 0, meaning it's invisible. This property can be set
from qml, or by QQuickFlickable with a scrollbar assigned to the
Scrollbar.vertical or Scrollbar.horizontal properties.
The minimumSize property can be set by the qml user, to force the
scrollbar to be larger than the Flickable size / contentSize ratio.
It makes sense to force the 0 ≤ x ≤ 1 constraint for this property's
value as well.
amends ef69623648f6f5ef5ab10dd9dee72f044334d53d
As an additional sanity check, I've added a qt_is_finite() check for all
qreal properties as well, just to prevent our API users from
accidentally setting a property to an invalid floating point value.
Pick-to: 6.3 6.2
Change-Id: I9f2880333483bf584986801d6b7204fea8d66e58
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since Flickable already has horizontalOvershoot() and
verticalOvershoot() functions, there is no reason
to calculate this again in TableView.
This patch will refactor the overshoot code to use the
already available API in Flickable.
Task-number: QTBUG-100696
Change-Id: Ifc666e079b0147c3e1cfc6bba2beb287977b303e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The logicalSize should always be calculated as `QSizeF(pixelSize) /
devicePixelRatio`, so that it accurately reflects the actual size of the
rendering surface.
Extends 17a280995ab546074fa7e9a009642fec5f23c64e.
Task-number: QTBUG-101269
Change-Id: Idd1b2337b6ef3456b570c0e619d5b9365ac93495
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- goUp on qnx
Pick-to: 6.2
Pick-to: 6.3
Task-number: QTBUG-101488
Change-Id: Ifaa9ce726d36d736bc4378e0655e5ae01409da5b
Reviewed-by: CI Insignificant Platforms Monitor Bot <ci_insignificant_platforms_monitor_bot@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Followup to 8503f884bbdb50c4bebc8f8a9fce05275b0612b1: much of the qml
was moved to an example, and the leftovers in this directory no longer
include the main.cpp/main.qml/CMakeLists.txt for building a standalone
executable. It's generally enough to run them individually with the qml
runtime, on desktop platforms at least.
Pick-to: 6.3
Task-number: QTBUG-101451
Change-Id: I4b329d0fabb398308c411246f34789d66e7eda33
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Amends 16f0d38d568b3af135f5db862f5868a6bc669c42.
From 0fc8a511baa6493c8d80046dd99b8eba3634d2a2, it seems that
not only Android is relying on these imports to satify
qmlimportscanner, but also Integrity. So rename the imports
to something generic and remove the explicit mention for Android.
Pick-to: 6.2 6.3
Task-number: QTBUG-97056
Change-Id: I9273fd0f9201a805cad4d588847796f7daecb686
Reviewed-by: Kimmo Ollila <kimmo.ollila@qt.io>
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The current implementation would only find cells that were
inside the bounding rect of the view. By changing the function so
that it also find cells that are halfway outside the view (as long as
they are loaded), it becomes useful also for implementing selection support
(finding cells under the current selection, even those cells that are
halfway outside the viewport).
Task-number: QTBUG-100696
Change-Id: Ie54dc9b8773e7295ead0c9644dbbc5052b8e40fc
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The pattern of checking if there are more rows or columns that can
be loaded around the currently loaded table, is a reoccuring
pattern. So factor it out into a more readable function.
Task-number: QTBUG-100696
Change-Id: Ia0117a6db0495f3ac1173e24084d074581ff5e7d
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It turns out we need the modelIndex() and cellAtIndex()
mapping functions in QQuickTableView as well, and not only
in QQuickTreeView. The reason is that functionality for
moving the current index around need to use them in order
for the logic to end up correctly for both
QQuickTreeView and QQuickTableView.
[ChangeLog][QtQuick][TableView] Added a set of functions to
get the model index for a cell, and vice versa.
Task-number: QTBUG-100696
Change-Id: Ifd2cd3e42bf8141a51c48635e57fb3a22358f1f6
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
On 32-bit Android x86 using a length of 0xffffffe throws an
"RangeError: ArrayBuffer: out of memory" instead of the expected
"RangeError: TypedArray.set: out of range".
Pick-to: 6.2 6.3
Task-number: QTBUG-99193
Change-Id: Id6deea18fe90228db616ddc7550c7832825c297a
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Revisions before QML_ADDED_IN_VERSION and revisions after
QML_REMOVED_IN_VERSION should both result in anonymous types. This way,
you can then derive from the type in question and expose the derived
type in a different set of versions.
Pick-to: 6.3
Change-Id: Ia59258047fc242c809c27525bb75fd2797fe5aab
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When using two-component revisions, we have to use them everywhere.
Pick-to: 6.2 6.3
Change-Id: I6bae8914a56ed27ed82479548d229cb8ce4fec19
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
... and do it only for the first engine (ie engineId == 1). The engineId
is determined using atomic operations, so this is safe now.
Pick-to: 6.3
Task-number: QTBUG-73271
Change-Id: Ife38213fe04e26f35425a29230a2e3b586572dd2
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
warning: unused parameter 'usage' [-Wunused-parameter]
warning: unused parameter 'writable' [-Wunused-parameter]
warning: unused parameter 'executable' [-Wunused-parameter]
warning: unused parameter 'lineCount' [-Wunused-parameter]
Pick-to: 6.2 6.3
Fixes: QTBUG-101383
Change-Id: I22089b1aeea927468e61769dcbbc8e363b9d734e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
ComboBox changes are included because it is button-like when not
editable. MenuItem changes are included because it is an AbstractButton
subclass.
Change-Id: I30a540bc9e277cddc111cbc2400c4130dadedb3c
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
This restores the containers' constness that was temporarily disabled.
Change-Id: I5e52dc5b093c43a3b678fffd16b642bab6c50521
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I23ced371526b9a7a4126a1e8d339460e6029f0fc
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
|
| |
| |
| |
| |
| | |
Change-Id: I287a6e63397c2c6140c3bc3e7d83f3212709531e
Reviewed-by: Maximilian Goldstein <max.goldstein@qt.io>
|
| |
| |
| |
| |
| | |
Change-Id: I983a27458cc154bb9f1c2a6666988d7b5457eb79
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
If we are dealing with dynamic metaobjects, the QML engine may not
create property caches. We cannot see this at compile time. Therefore,
we need to establish a fallback infrastructure that does the same
operations on plain QMetaObject.
Pick-to: 6.2 6.3
Fixes: QTBUG-101349
Change-Id: I8c936fc077b0018df71196620b6987825253cb39
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| | |
This way we can uniquely track the stored types throughout the
compilation.
Change-Id: Ibf3814a37f105c2eede2a08f547ab5fbfa1c16e2
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When a property is required after declaration, now show the scope where
it happens including full location information and context.
Change-Id: Iddd2d0e543406ab479b4af1a5e74682328998d74
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This change makes sure the logger can write messages and show excerpts
from files other than the current one. This is necessary in order to
give users hints about problems that arise due to other components.
It also adds a field to FixSuggestion::Fix which specifies whether a
suggested fix can be applied automatically or is only a hint.
Change-Id: I94a929d3fc3fc966591cffb99e67309d264c38e7
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
-Add dummy_imports.qml to TESTDATA
-Let qmlimportscanner handle plugin import
-Skip cases that depend on mounted filesystem
Task-number: QTBUG-99123
Pick-to: 6.3 6.2
Change-Id: I99e21e423f2114c4c4ee1e24bdf9bb85af51baf7
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Reviewed-by: Tatiana Borisova <tatiana.borisova@qt.io>
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
|
| |
| |
| |
| |
| |
| |
| | |
Task-number: QTBUG-100369
Pick-to: 6.3
Change-Id: Iff8bd85027ff9ca437b5b6d2ed3f43c86ad99746
Reviewed-by: Leena Miettinen <riitta-leena.miettinen@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Some minor grammar issues found in the qtquickcontrols, qtquickdialogs,
and qtquicklayout landing pages.
Task-number: QTBUG-100369
Pick-to: 6.3
Change-Id: I36ffbee1ad8bef755cc676285db8629d79d32e13
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This is in line with what we do in other reverse() and rewind() methods.
Unfortunately we need to dig deep into the QQuickItem internals in order
to get all the flags and callbacks right.
Pick-to: 6.2 6.3
Fixes: QTBUG-101186
Change-Id: Icde1a1b2dab1b9cab5adcbc28485a7526a8ac2b7
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The basic blocks pass will specialize types of registers for their read
locations. Therefore, we have to explicitly convert the results of all
instructions. We cannot rely on the implicit type given by the
instruction to be the same as the output accumulator type anymore.
Change-Id: Ibf1f1d2ebaddafbbd916aeb2e24dcb3ca71010b2
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The QObject one didn't take effect, and we don't need the metatype to
get a metaobject for QObject or QQmlComponent.
Pick-to: 6.3
Change-Id: Ib047d958a79659fe7c5904b2fdc25b72e69b7b2b
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
|