| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| | |
Change-Id: Ice58db1687c0cfbd5a19e84ca9fa81b8d3fa7959
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Add a return to the default branch capturing NoGradient, fixing:
warning: variable 'gradMat' is used uninitialized whenever switch default is taken
Change-Id: Iad9d619b59677a18a0718d750516c9b2fe51569d
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
|
|\|
| |
| |
| | |
Change-Id: I729af792166fd2f6c5843ba564e63adf8ae09a97
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
From now on we prefer nullptr instead of 0 to clarify cases where
we are assigning or testing a pointer rather than a numeric zero.
Also, replaced cases where 0 was passed as Qt::KeyboardModifiers
with Qt::NoModifier (clang-tidy replaced them with nullptr, which
waas wrong, so it was just as well to make the tests more readable
rather than to revert those lines).
Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
|
|/
|
|
|
|
|
| |
One thread
Change-Id: Iab9bd20eb5951c7b0fe0b6f48f1f14ea7560d8f7
Reviewed-by: Morten Johan Sørvig <morten.sorvig@qt.io>
|
|
|
|
|
|
|
| |
Do not store the superfluous window and geometry pointers.
Change-Id: Ib9cf4e62bdc6f32dc99cda25eddfebdfa05d579b
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-61857
Change-Id: Iacefcc3b22b31ed3dbcfbf7f00c8b0ea51c63b95
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
|
|
|
|
|
|
| |
Task-number: QTBUG-61857
Change-Id: I580e503d8266a9dca69bb542c22228df4ff4bf94
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
|
|
|
|
|
|
|
|
|
|
| |
None of the removed code is ever hit in practice since the public JS API
has been removed some time ago. Let's follow it up with removing the
internal details since such an API is not going to come back in the near
future.
Change-Id: I721ab296a7a2acb3a5f61ce705da7aa66d3ad765
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
| |
Do not leave them in quick/items' qrc.
Change-Id: I12360a54caa368219a7a80645f92af66aa9de9ba
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
|
|
|
|
|
|
|
|
| |
Also guard fillGradient for now.
Task-number: QTBUG-61632
Change-Id: I5fa2607cc1ede0922519258afd455bee4d0187c7
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To make Coverity happy:
*** CID 181275: Null pointer dereferences (FORWARD_NULL)
/qtdeclarative/src/imports/shapes/qquickshapegenericrenderer.cpp: 503 in QQuickShapeGenericRenderer::updateNode()()
497 QQuickShapeGenericNode **nodePtr = &m_rootNode;
498 QQuickShapeGenericNode *prevNode = nullptr;
499
500 for (ShapePathData &d : m_sp) {
501 if (!*nodePtr) {
502 *nodePtr = new QQuickShapeGenericNode;
>>> CID 181275: Null pointer dereferences (FORWARD_NULL)
>>> Dereferencing null pointer "prevNode".
503 prevNode->m_next = *nodePtr;
504 prevNode->appendChildNode(*nodePtr);
505 }
506
507 QQuickShapeGenericNode *node = *nodePtr;
508
Change-Id: I76e79ef6fe94aa8b0e77f79724101b4682dab6d3
Coverity-Id: 181275
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thus application code becomes:
ShapePath {
...
fillGradient: LinearGradient {
...
GradientStop { ... }
}
}
which is even more clean and readable. The duplication for stops is
now avoided.
Change-Id: I50ae2f388e21683a37dc4787763dc71e16eef4f5
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: J-P Nurmi <jpnurmi@qt.io>
|
|
Change-Id: I299354da0632fb0b8487cfb13748ed58b97d75fd
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
|