aboutsummaryrefslogtreecommitdiffstats
path: root/tests
Commit message (Collapse)AuthorAgeFilesLines
...
| | * | Fix tst_qquicktextinput for fullscreen platformsRafael Roquetto2013-07-251-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I42683f69a439608f778fbccf90573173bbc03f5b Reviewed-by: Wolfgang Bremer <wbremer@blackberry.com> Reviewed-by: Frederik Gladhorn <frederik.gladhorn@digia.com>
| | * | Resizing items out of the list viewport should not change the viewportAlbert Astals Cid2013-07-242-0/+105
| | |/ | | | | | | | | | | | | | | | | | | | | | Consider the old geometry, not the new one to check if an item was outside the viewport or not Change-Id: I108412d560faf86130044f3d091254c07af0c004 Reviewed-by: Alan Alpert <aalpert@blackberry.com>
* | | Merge branch 'wip/v4' of ssh://codereview.qt-project.org/qt/qtdeclarative ↵Simon Hausmann2013-08-06217-3492/+15331
|\ \ \ | | | | | | | | | | | | | | | | | | | | into dev Change-Id: I278524d0f43d2237201d9cf78c1c36a5ecc83d84
| * | | Fix some GC related tests to work with MSVCSimon Hausmann2013-08-062-9/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using alloca instead of memset we can convince even MSVC to allocate memory on the stack, to overwrite any previous dead V4 pointers. Change-Id: Ic01bebfc6368e9c3ce1f6155a0f0ea206b90764c Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | Skip the date time conversion tests on WindowsSimon Hausmann2013-08-051-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's an issue in QDateTime, now that we're using that in our ECMAScript date implementation... Change-Id: I7599900a670097623d1b7e5b9bb086ef43d6e7e6 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | Disable some GC sensitive tests with MSVCSimon Hausmann2013-08-051-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We can't get these tests to work reliably with MSVC because it depends on how MSVC optimizes away memory stores that are "dead" stores for the compiler but not for our conservative collector. Change-Id: Ia5ca197573a09358c220d926deccaaf0bacc3a0b Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | Fix race condition in tst_QQuickFolderListModel::basicPropertiesSimon Hausmann2013-08-051-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The FLM updates its contents asynchronously using a thread, so before we query for the new properties after changing the folder, make sure the thread finished updating. Change-Id: Icbd72801f639f9dffdc0dd85fbbd8b3ee53fedda Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | Improve reliability of GC related testsSimon Hausmann2013-07-297-32/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes propertyVarCircular2 in clang release builds for example. Some of the QML/GC related tests had functions like function deassign() { someVariableThatWasholdingSomethingThatShouldBeCollectedNow = null; gc(); } which work fine with an exact GC like in v8, but with our conservative collector they are not that reliable and much more vulnerable to a reference to the object still being around somewhere. So to improve the reliability of the test, this patch moves the gc() calls out of the JavaScript function and back to the C++ caller side (these functions are invoked via QMetaObject::invokeMethod), where the existing gc() helper function will call the collector and also process posted deferred deletion events for QObjects. Change-Id: I8c1f715d56d66bc567ea8bd1575f171460b15ac8 Reviewed-by: Jędrzej Nowacki <jedrzej.nowacki@digia.com>
| * | | Silence qqmlecmascript::propertyVarInheritance failures with clang release ↵Simon Hausmann2013-07-261-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | builds There's no equivalent to #pragma GCC optimize ("O0") yet, so we cannot run these test (sort of) reliably with clang. Change-Id: Ie41d3ba7911cefacca00165941761b20579107a2 Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
| * | | Initial support for debugging in the v4 interpreterSimon Hausmann2013-07-263-1/+296
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This adds breakpoint support to the Debugger, a helper function in the engine for enabling debugging (which will switch from JIT to the interpreter) and a DebuggingAgent interface, for use by v4 clients. Change-Id: I78e17a6cbe7196b0dfe4ee157fc028532131caa3 Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
| * | | Merge branch 'dev' of ssh://codereview.qt-project.org/qt/qtdeclarative into ↵Simon Hausmann2013-07-2626-51/+42436
| |\| | | | | | | | | | | | | | | | | | | | | | merge Change-Id: I5824a3eb624b325de10acfd5109c4c1bdabcf780
| * | | Merge branch 'dev' of ssh://codereview.qt-project.org/qt/qtdeclarative into ↵Simon Hausmann2013-07-2220-10/+391
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | wip/v4 Conflicts: src/quick/items/context2d/qquickcontext2d.cpp tests/auto/quick/qquickvisualdatamodel/qquickvisualdatamodel.pro Change-Id: I36a4fd28b3156839aecd70039a3ba566bf19a0bc
| * | | | Move QV4::Exception into a separate compilation unit with header fileSimon Hausmann2013-07-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is in preparation for some platform specific code regarding throwing exceptions, as well as a general cleanup :) Change-Id: I23fb4f12fd09423a1f2cb225145780925002677b Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
| * | | | Get rid of the first half of QQmlGuard usageLars Knoll2013-07-051-7/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | QQmlGuard was being used as a more performant replacement for QPointer. QPointer got now fixed in Qt 5.0, making this class obsolete. Change-Id: I77eef066c4823af4b074ef32d4d78dbd67c36cd0 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | Fix failing GC related tests with gcc in release buildsSimon Hausmann2013-07-051-3/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Our conservative collector might is more likely to find old pointers to QV4::Objects on the C stack in release builds, when gcc optimizes out stores that seem unnecessary. These two tests are prone to that due to temporary QV4::Values potentially ending up on the stack on x86, because vmeProperty returns then through an invisible first argument that is a pointer a a location on the stack. This patch makes those temporaries explicit, clears them out after usages and adds GCC pragmas to disable optimizations for these two test functions. Change-Id: Ie43841e869346792296911fee6fed80c745faeff Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | Get rid of the signal expression rewriterSimon Hausmann2013-07-032-18/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This replaces the entire rewriter with more or less: expressionToEval = "(function(<named params here>) { " + expr + " } )" This also fixes crashes at run-time when the signal rewriter was executed from the loader thread and tried to use a v4 identifier hash with the same engine that's also in the main thread. Change-Id: Ib1e4927d330706a593411fbff64ed3da1e23d0e0 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | Fix automatic semicolon insertion. Again.Erik Verbruggen2013-07-021-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After a do-token, no automatic semicolon can be inserted, because that would result in an empty statement. The issue was that the correct state was set when a do-token was found, but the state updating logic would immediately reset it back, resulting in a semicolon insertion. Change-Id: If867510dfaa182d0fe8b73a5bb1cab299c4faecc Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | Fix missing license headers for test262.pySergio Ahumada2013-06-241-0/+40
| | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I805cf8951fb50518372aad0024fc287ee5955bbd Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | Fix some missing license headersSergio Ahumada2013-06-241-0/+40
| | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I758fe0a61d1ecb9418087ac318ac93f227013248 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | Merge branch 'dev' of ssh://codereview.qt-project.org/qt/qtdeclarative into ↵Simon Hausmann2013-06-24114-241/+2830
| |\ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | wip/v4 Conflicts: src/imports/qtquick2/plugins.qmltypes src/qml/debugger/qv8debugservice.cpp src/qml/qml/qml.pri src/qml/qml/qqmlcompiler.cpp src/qml/qml/qqmlcomponent.cpp src/qml/qml/qqmlcontext.cpp src/qml/qml/qqmldata_p.h src/qml/qml/qqmlengine_p.h src/qml/qml/qqmljavascriptexpression.cpp src/qml/qml/qqmlxmlhttprequest.cpp src/qml/qml/v4/qv4bindings.cpp src/qml/qml/v4/qv4irbuilder.cpp src/qml/qml/v4/qv4jsonobject_p.h src/qml/qml/v8/qqmlbuiltinfunctions.cpp src/qml/qml/v8/qv8bindings.cpp src/qml/qml/v8/qv8contextwrapper.cpp src/qml/qml/v8/qv8listwrapper.cpp src/qml/qml/v8/qv8qobjectwrapper.cpp src/qml/qml/v8/qv8qobjectwrapper_p.h src/qml/qml/v8/qv8sequencewrapper_p_p.h src/qml/qml/v8/qv8typewrapper.cpp src/qml/qml/v8/qv8valuetypewrapper.cpp src/qml/types/qqmldelegatemodel.cpp src/quick/items/context2d/qquickcanvasitem.cpp src/quick/items/context2d/qquickcontext2d.cpp sync.profile tests/auto/qml/qjsengine/tst_qjsengine.cpp tests/benchmarks/qml/animation/animation.pro tools/qmlprofiler/qmlprofiler.pro Change-Id: I18a76b8a81d87523247fa03a44ca334b1a2360c9
| * | | | | Mark automatic-semicolon insertion bugs as XFAILSimon Hausmann2013-06-241-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (but marked as needs-fix in trello) Change-Id: I7cfebc9494dd0d5cb027b36f8c8cbcd02a520302 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Fix expected error messages in singleonType testSimon Hausmann2013-06-231-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Writing to a property of a frozen object doesn't throw a type error exception in non-strict mode. Change-Id: I408078a2a09d16868b95f275f13f2f7a176f66e9 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Mark qqmlecmascript::hasOwnProperty as xfailSimon Hausmann2013-06-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hasOwnProperty is not currently properly supported on dynamic objects that re-implement get. Change-Id: Ib6cfe13bbdbe4457adf05cd20e42d3a5e85ac318 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Fix qqmlmodulepluginSimon Hausmann2013-06-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Adjust the expected error message after commit 227f7ed60cfb34f7c3d91b27b07ddc5bbd1a2922 Change-Id: I328072dfb0151d6cd9b8452d8d3f9a306a132203 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Fix tst_qqmlcomponent::onDestructionLookupSimon Hausmann2013-06-211-1/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Don't rely on the JIT generated code to immediately discard and ignore the return value of createObject(). Instead move that call into another function that, so that the return value of createObject() is guaranteed to be invisible to the GC and thus collect the recently created object as expected. Change-Id: I08a0a35fc895482792deffbae7f7f6437727d871 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Mark a sub-test in qqmlecmascript::scope() as xfailSimon Hausmann2013-06-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This test relies on the global object vs. context ordering and consequently fails right now Change-Id: I6b6cec38bf2d2074c2fcfacf9b499bc7a97cca44 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Fix expected error messageLars Knoll2013-06-211-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I41ebd1506b0d1675cac1205d5fd8f60fd751a4aa Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Fix expected test output for one list model testLars Knoll2013-06-212-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | There's no reason to disallow calling model.set() with an ArrayObject as argument. Change-Id: I44baad677ca34e1fb4188b89f0a548af84580b4f Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Remove XFAILs that was due to strict modeSimon Hausmann2013-06-211-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In non-strict mode we can use with() and eval() again, and so these tests pass. Change-Id: I66b16653a28b1d7e420e53c012d7908c8fc6c29a Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Mark test as xfail that assumes writability of the global objectSimon Hausmann2013-06-211-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As discussed, this needs to be fixed post merge Change-Id: Iebdc06da4977158b5d6190b3f093f8962459e109 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Disable the v8profiler, not the qml profilerLars Knoll2013-06-211-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I6113ef5cefa5be8d53e45857ab76c23deb6fe805 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Skip some tests that are failing because of our date time parserLars Knoll2013-06-211-16/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The parser needs to be fixed to better parse localized dates, times and timezone fields Change-Id: I6542ee459e7135b6f845fb5fc89685cb8c2d67c5 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Disable some debugger tests until we have a reimplementation for v4Lars Knoll2013-06-211-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I273fba969c72299e84c091afd7d4a43f9dbd1bf8 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Fix scope chain for eval in strict modeLars Knoll2013-06-211-2/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ie00046f98a126cd46cd79758a78be1d0e1d17c61 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Fix instanceStateValues xhr testSimon Hausmann2013-06-201-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Writing to a read-only property or trying to deleting will throw an exception in strict mode and thus abort the execution. Make the test work in strict and non-strict mode by surrounding the offending statements with individual try/catch pairs. Change-Id: I25f803b6ffd7ef721ac874f53a37b3208b5c05ab Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Fix tst_qqmlecmascript::functionAssignmentfromJS_invalidSimon Hausmann2013-06-181-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Remove the column number from the expected output, as we generate those QQmlBinding objects from within a v4 callback and produce the line number and column number from the stack trace of the engine, which currently doesn't produce column numbers. Change-Id: I9840f0ab571d4261570dd079436aaa9f81e27abf Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Fix tst_qqmlecmascript::functionAssignment_fromJSSimon Hausmann2013-06-181-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Make the test-case compile with strict mode, where function declarations are not allowed within blocks. An alternative would be to use function expressions here. Change-Id: If7e1cc23ef4a0c6a83e4ba8ae03dc9c6b678730d Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Fix two more errors in the worker script auto testLars Knoll2013-06-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ib1359a985efae18cd4fc8344b81092af57f1a9d4 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Fix url test in qqmllanguageSimon Hausmann2013-06-171-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In V4 URLs were mapped to strings, with V8 they were mapped to opaque variants, which is also what we do with v4 at the moment. In the future we want to provide a real JS API for URLs, but that is a feature that should be discussed in a wider scope and developed on the dev branch. Change-Id: I17660066b2797239eddebad03f49ffa424f86f78 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Fix the console autotestsLars Knoll2013-06-171-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I8936c6baa274e673c23c65637fa199a6140e0a15 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Fix qmlmin testLars Knoll2013-06-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Exclude the test262 test suite, as qmlmin can't deal with all of the test cases there. Change-Id: Ie56c0d9adecc6b1ae0ddcbcd3edd5b0eaf30cd4d Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Fix the remaining test failures in the jsonbinding autotestLars Knoll2013-06-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Skip properties that are function objects when converting a V4 Object to a QJsonObject. For arrays the function object gets replaced with null. Fix the test case for arrays to have the correct expected output. Change-Id: I3ee63935d038e0922e33ac6e64e9c31ecfbd4a7e Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Fix and enable the qmldirparser autotestLars Knoll2013-06-173-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I2e9b64e5df63dbd9fffc204b7058d3c77255b09c Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Fix most qjsonbinding auto testsLars Knoll2013-06-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: I67476bc7e931e2f4790e859d4a3c00c050752271 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Mark the eval() test as xfailSimon Hausmann2013-06-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | eval() works differently in strict mode, and it's nicely covered by test262 Change-Id: I9bb84753032d5106c94d78afe765680f3d85348d Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Adjust expected error message for qqmlecmascript::qtbug_22843Simon Hausmann2013-06-171-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Change-Id: Ib6f58c2d7ee5e4f03fcc755d2290bdf204e3aa61 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Re-enable two disabled var property tests and make them passSimon Hausmann2013-06-151-30/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When marking the var properties of a VME-metaobject (we decided to keep its QObject alive), then we must also mark the var properties of the parent VME-metaobject. The two property var inheritance tests verify that. Change-Id: If1f0d4f3daef78d42adb7052cc1ce7bbdd6da585 Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Fix qqmlproperty::warnOnInvalidBindingSimon Hausmann2013-06-152-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Add column to expected warning message * Get rid of eval that doesn't make sense with only one JS engine and doesn't work in strict mode Change-Id: I63cd3784cd8c255af8832ea5ca1e6e5e2d48431e Reviewed-by: Lars Knoll <lars.knoll@digia.com>
| * | | | | Comment out test of octal numbersLars Knoll2013-06-141-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We don't currently support octal numbers in v4 Change-Id: Icb31d399a199eb573068b431954a22d169de9b9e Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
| * | | | | Implement error.fileName and error.lineNumberLars Knoll2013-06-141-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Useful extensions to the error object. This also helped track down a few places in the parser where we wouldn't give correct error information. Change-Id: Id03653e096216e097c13a7a6e698ca142d92da13 Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>