From b29fac2d05424fd2263ed2ffdd39d2062007a86b Mon Sep 17 00:00:00 2001 From: Gunnar Sletta Date: Thu, 14 Aug 2014 13:53:11 +0200 Subject: The cached objects can be deleted, so keep them in a QPointer. Change-Id: Ieaebd2e7b9823cbe22efc331e42ceab8fbbda0e8 Task-number: QTBUG-40201 Reviewed-by: Lars Knoll --- src/qml/types/qqmldelegatemodel_p_p.h | 2 +- .../auto/qmltest/stability/tst_unloadrepeater.qml | 103 +++++++++++++++++++++ 2 files changed, 104 insertions(+), 1 deletion(-) create mode 100644 tests/auto/qmltest/stability/tst_unloadrepeater.qml diff --git a/src/qml/types/qqmldelegatemodel_p_p.h b/src/qml/types/qqmldelegatemodel_p_p.h index d64f641a1b..5464ce91a2 100644 --- a/src/qml/types/qqmldelegatemodel_p_p.h +++ b/src/qml/types/qqmldelegatemodel_p_p.h @@ -143,7 +143,7 @@ public: QV4::ExecutionEngine *v4; QQmlDelegateModelItemMetaType * const metaType; QQmlContextData *contextData; - QObject *object; + QPointer object; QPointer attached; QQDMIncubationTask *incubationTask; int objectRef; diff --git a/tests/auto/qmltest/stability/tst_unloadrepeater.qml b/tests/auto/qmltest/stability/tst_unloadrepeater.qml new file mode 100644 index 0000000000..dfb631493b --- /dev/null +++ b/tests/auto/qmltest/stability/tst_unloadrepeater.qml @@ -0,0 +1,103 @@ +/**************************************************************************** +** +** Copyright (C) 2014 Jolla Ltd, author: +** Contact: http://www.qt-project.org/legal +** +** This file is part of the test suite of the Qt Toolkit. +** +** $QT_BEGIN_LICENSE:LGPL$ +** Commercial License Usage +** Licensees holding valid commercial Qt licenses may use this file in +** accordance with the commercial license agreement provided with the +** Software or, alternatively, in accordance with the terms contained in +** a written agreement between you and Digia. For licensing terms and +** conditions see http://qt.digia.com/licensing. For further information +** use the contact form at http://qt.digia.com/contact-us. +** +** GNU Lesser General Public License Usage +** Alternatively, this file may be used under the terms of the GNU Lesser +** General Public License version 2.1 as published by the Free Software +** Foundation and appearing in the file LICENSE.LGPL included in the +** packaging of this file. Please review the following information to +** ensure the GNU Lesser General Public License version 2.1 requirements +** will be met: http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html. +** +** In addition, as a special exception, Digia gives you certain additional +** rights. These rights are described in the Digia Qt LGPL Exception +** version 1.1, included in the file LGPL_EXCEPTION.txt in this package. +** +** GNU General Public License Usage +** Alternatively, this file may be used under the terms of the GNU +** General Public License version 3.0 as published by the Free Software +** Foundation and appearing in the file LICENSE.GPL included in the +** packaging of this file. Please review the following information to +** ensure the GNU General Public License version 3.0 requirements will be +** met: http://www.gnu.org/copyleft/gpl.html. +** +** +** $QT_END_LICENSE$ +** +****************************************************************************/ + +import QtQuick 2.2 +import QtTest 1.0 + +Item { + width : 800 + height : 600 + + Timer { + id: probablyOkNow + interval: 2000 + running: true + repeat: false + onTriggered: testCase.when = true; + } + + TestCase { + id: testCase + name: "unloaded-repeater" + when: false + function test_endresult() + { + havocTimer.running = false; + verify(true, "If we didn't crash by now, all is good") + } + } + + Timer { + id: havocTimer + interval: 1 + running: true + repeat: true + + onTriggered: { + loader.sourceComponent = null + loader.sourceComponent = component1 + } + + } + + Loader { + id : loader + asynchronous : true + } + + Component { + id : component1 + Grid { + columns: 70 + spacing: 2 + + Repeater { + model : 2000 + + Rectangle { + width : 3 + height : 3 + color : "blue" + } + } + } + } +} -- cgit v1.2.3