From c5e7d26580377175cb9129d575b9c24eea1c6d71 Mon Sep 17 00:00:00 2001 From: Shawn Rutledge Date: Wed, 7 Sep 2022 17:58:08 +0200 Subject: Avoid dangling pointers in handler for QQuickPixmapReply::finished Fixes: QTBUG-106357 Change-Id: I78156b403618c88da26d381be7a6e777a6d22f87 Reviewed-by: Richard Moe Gustavsen (cherry picked from commit 88aff6f851a70e5bb5082b04943a5c8ddf026d44) Reviewed-by: Qt Cherry-pick Bot --- src/quick/util/qquickpixmapcache.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/quick/util/qquickpixmapcache.cpp b/src/quick/util/qquickpixmapcache.cpp index 51be6f8e51..a6e45d769d 100644 --- a/src/quick/util/qquickpixmapcache.cpp +++ b/src/quick/util/qquickpixmapcache.cpp @@ -1747,8 +1747,7 @@ void QQuickPixmap::loadImageFromDevice(QQmlEngine *engine, QIODevice *device, co QQuickPixmapReader::readerMutex.lock(); d->reply = QQuickPixmapReader::instance(engine)->getImage(d); if (oldD) { - QObject::connect(d->reply, &QQuickPixmapReply::finished, [oldD, this]() { - oldD->declarativePixmaps.remove(this); + QObject::connect(d->reply, &QQuickPixmapReply::finished, [oldD]() { oldD->release(); }); } -- cgit v1.2.3