From df6338a7b4ff43b1bb0538c44c632d122a7c3766 Mon Sep 17 00:00:00 2001 From: Christiaan Janssen Date: Wed, 11 Jan 2012 17:50:51 +0100 Subject: QDeclarativeExpression: storing column number in expression location Change-Id: I2d69738158abfc76f80b1cfc0e0ccb145fda2245 Reviewed-by: Aaron Kennedy --- src/declarative/debugger/qdeclarativeenginedebugservice.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'src/declarative/debugger/qdeclarativeenginedebugservice.cpp') diff --git a/src/declarative/debugger/qdeclarativeenginedebugservice.cpp b/src/declarative/debugger/qdeclarativeenginedebugservice.cpp index fa23bc1024..2a66c8fcb6 100644 --- a/src/declarative/debugger/qdeclarativeenginedebugservice.cpp +++ b/src/declarative/debugger/qdeclarativeenginedebugservice.cpp @@ -540,7 +540,8 @@ void QDeclarativeEngineDebugService::setBinding(int objectId, const QVariant &expression, bool isLiteralValue, QString filename, - int line) + int line, + int column) { QObject *object = objectForId(objectId); QDeclarativeContext *context = qmlContext(object); @@ -552,7 +553,7 @@ void QDeclarativeEngineDebugService::setBinding(int objectId, bool inBaseState = true; if (m_statesDelegate) { m_statesDelegate->updateBinding(context, property, expression, isLiteralValue, - filename, line, &inBaseState); + filename, line, column, &inBaseState); } if (inBaseState) { @@ -561,11 +562,11 @@ void QDeclarativeEngineDebugService::setBinding(int objectId, } else if (hasValidSignal(object, propertyName)) { QDeclarativeExpression *declarativeExpression = new QDeclarativeExpression(context, object, expression.toString()); QDeclarativePropertyPrivate::setSignalExpression(property, declarativeExpression); - declarativeExpression->setSourceLocation(filename, line); + declarativeExpression->setSourceLocation(filename, line, column); } else if (property.isProperty()) { QDeclarativeBinding *binding = new QDeclarativeBinding(expression.toString(), object, context); binding->setTarget(property); - binding->setSourceLocation(filename, line); + binding->setSourceLocation(filename, line, column); binding->setNotifyOnValueChanged(true); QDeclarativeAbstractBinding *oldBinding = QDeclarativePropertyPrivate::setBinding(property, binding); if (oldBinding) -- cgit v1.2.3 From e6b224aa2872d7d1030fa98bd30603e16f8f9604 Mon Sep 17 00:00:00 2001 From: Jason McDonald Date: Fri, 20 Jan 2012 14:04:27 +1000 Subject: Update obsolete contact address. Replace Nokia contact email address with Qt Project website. Change-Id: I6a730abc0c396fb545a48b2d6938abedac2e3f1c Reviewed-by: Rohan McGovern Reviewed-by: Alan Alpert --- src/declarative/debugger/qdeclarativeenginedebugservice.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/declarative/debugger/qdeclarativeenginedebugservice.cpp') diff --git a/src/declarative/debugger/qdeclarativeenginedebugservice.cpp b/src/declarative/debugger/qdeclarativeenginedebugservice.cpp index 2a66c8fcb6..c235b55480 100644 --- a/src/declarative/debugger/qdeclarativeenginedebugservice.cpp +++ b/src/declarative/debugger/qdeclarativeenginedebugservice.cpp @@ -2,7 +2,7 @@ ** ** Copyright (C) 2012 Nokia Corporation and/or its subsidiary(-ies). ** All rights reserved. -** Contact: Nokia Corporation (qt-info@nokia.com) +** Contact: http://www.qt-project.org/ ** ** This file is part of the QtDeclarative module of the Qt Toolkit. ** -- cgit v1.2.3